From nobody Fri Mar 11 16:42:44 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 314B61A1BF28; Fri, 11 Mar 2022 16:42:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KFWv90t80z4cch; Fri, 11 Mar 2022 16:42:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647016965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nwGIhs+0/m6pzHYHkqrJexugmnez6xqekboVI6JMWPM=; b=J2pC2OQUC11yHQzMi5ci5xqrQgXjKqs3gMhBI7+hmtCaVQiwUDdauuBLqBHanVfwylcEMY OFgHSST5IjYd+FD5BdQeMbV3JwSVbC1t4hrMabeeuD3MGt2XNfhhaFpuct7swoPEzwQpi0 AMl8sjPNk5flBMNttOPOSPlgrHpbN9NWa1bOTCrbRp5O3xs8wg4Jz3BEm177G6aeIpZM2W XJmVVWtvOsVGpN5KdnEuvYXxZV4polqpJfD74UGYuuyat3DImzTqphUXKvnI1iXlEeFfgE 2lDpJP33UTWzqZ5M6xAAig70P84eP83rnN5Z72vjrtkc/bFMeHSCJSSZTdwjTg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F1DA51C9E0; Fri, 11 Mar 2022 16:42:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 22BGgiq0097007; Fri, 11 Mar 2022 16:42:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 22BGgiqJ097006; Fri, 11 Mar 2022 16:42:44 GMT (envelope-from git) Date: Fri, 11 Mar 2022 16:42:44 GMT Message-Id: <202203111642.22BGgiqJ097006@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hans Petter Selasky Subject: git: 88a29d89ebab - main - lindebugfs: Zero the linux_file structure before use. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 88a29d89ebab1ed60607c3dab73143c3b59a0f83 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647016965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nwGIhs+0/m6pzHYHkqrJexugmnez6xqekboVI6JMWPM=; b=OvIW88+10OqQmImQ1HpI0ZjgSN3Z+CXrk6suRv+cobG4kCHCzNWJx9af2I49L5GFE9NOL5 r4Hg3rv934bx/ZZIEFkQc0IrCvKq2UlwP9fSTw/nJcYb5ZO4lUcM/jUTyKGWRvhoQOGrBh trUCzk4a2dgJZBArwcpxhv+XKwZWnCNBS5lU24SieJai2+OBjgAU0qPrcSEOQd3s0BTH+N ux0yEwJfVOlZLlnXBv5egsw4e/eKuhjR2yZqQVFey5z70xH/4IxcDhiOnYz68j1MV4aROm wYCXYcWpLtfm1HLPhod4W+BsQx0L5SWosLUSpJhtzdKvkfh/jKT205NLq5KuAw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647016965; a=rsa-sha256; cv=none; b=rsrIHzrVWFLng9ocDx0qLHjabB0GNunRtSXGzC6N+O75nuF7oowyj1r7uBpva60G69e6R2 YUI+S3PnVjadotqcARM99gA1WJSm3Uqp1thuvqtqdESbzL8UutnQyFeRfwqZqx9bNsDGfy PAOysTtiXcmpwlmw1rKkhRXicC31mOpdnxi3Gv+Y/mfBNuIuF2P97/8a+1q1XFPDXJ+Wue 5Ezk/IDGTiCov1vohCgmWKfCpjck90Ufof4ojAV3HwkshwHZrOqvuYPQ8ZcDEE+fWm2z35 kk+LGVAkZqmE3IOvZcqETKqFWil7Sbr+Ka/jqRaFzlovJxNYKQ7m+QXsszqK+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=88a29d89ebab1ed60607c3dab73143c3b59a0f83 commit 88a29d89ebab1ed60607c3dab73143c3b59a0f83 Author: Hans Petter Selasky AuthorDate: 2022-03-11 16:29:54 +0000 Commit: Hans Petter Selasky CommitDate: 2022-03-11 16:41:33 +0000 lindebugfs: Zero the linux_file structure before use. This avoids clients using garbage values on the stack and makes debugging easier. MFC after: 1 week Sponsored by: NVIDIA Networking --- sys/compat/lindebugfs/lindebugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/lindebugfs/lindebugfs.c b/sys/compat/lindebugfs/lindebugfs.c index 8eaa41412fd2..9507cded9ebd 100644 --- a/sys/compat/lindebugfs/lindebugfs.c +++ b/sys/compat/lindebugfs/lindebugfs.c @@ -117,7 +117,7 @@ static int debugfs_fill(PFS_FILL_ARGS) { struct dentry_meta *d; - struct linux_file lf; + struct linux_file lf = {}; struct seq_file *sf; struct vnode vn; void *buf; @@ -139,7 +139,6 @@ debugfs_fill(PFS_FILL_ARGS) len = sbuf_len(sb); } off = 0; - lf.private_data = NULL; rc = d->dm_fops->open(&vn, &lf); if (rc < 0) { #ifdef INVARIANTS