From nobody Wed Mar 09 22:50:12 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 18BD81A06ED7; Wed, 9 Mar 2022 22:50:21 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDS8D4grsz4Tdg; Wed, 9 Mar 2022 22:50:20 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646866220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SNIpi4xAYqw2YR4gUeNrs9TwDszqc+l4jfx+c67zfDM=; b=EHlrH3bHPmrKOcgYrZVolDSnlILaOUWHiEx/xABKxi9EM3m5twC/FTYfVH2QrLOxKR6EjP GrPcNCdWfsL9POyOji2WS5h/qMko/404cG8ff1jtcUx/bwudEUZBOdIBk2hSGkz6cynLKM AAdzBnde8lp3ZhbdKR2T3Z2WOGD+p2IojtwvrCbpuMSPD1FepfndOj/r8MSsMYYHe0EECN 4Noa49INNpWNaxtyNg1lQVt1j0qYIgUtlVLXoR4nsTAZcJswwi+w2maPiNNcCgRm9/Re2q Fa3oV4RXUWC38r/uJfjM1iqRSVD6nA0Zr9ZG5J++oJgf5iNf+YRC2/+Kfr4ZQQ== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 5BCBC825D; Wed, 9 Mar 2022 22:50:20 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id CBB6939034; Wed, 9 Mar 2022 23:50:18 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_6E128573-23BB-478A-A548-700362A28FB2"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\)) Subject: Re: git: 7ecd99fa424d - main - Build compiler-rt against libunwind, not libcxxrt From: Dimitry Andric In-Reply-To: <1eb62898-4f0a-504f-26a8-ee01c46093a6@FreeBSD.org> Date: Wed, 9 Mar 2022 23:50:12 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: <1129443B-EFC8-4F02-B87E-37CA04A0AD64@FreeBSD.org> References: <202203092130.229LUKFS011484@gitrepo.freebsd.org> <1eb62898-4f0a-504f-26a8-ee01c46093a6@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3693.60.0.1.1) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646866220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SNIpi4xAYqw2YR4gUeNrs9TwDszqc+l4jfx+c67zfDM=; b=iEFm18OPFw/J7PsdSythMFSHKFfD3eI6KKhyf0uQcv3//Exm5/FyBNSOhJjRuOxk+IxLM3 A55ULhDxecnFxGs2TW2t0RKZzBi4f0et8ak4gAeK2pNYtueb+btgxKvq9/cyZRTPpJW/ay r9PiSRTpi5mkQ9cAsbKtQ7Fy5ZECb/IxbHL+skdE0YgPSmmRAnvDT3YLvw2jrGDwmFVvCC oJqA948Q1V0y4kZ5HprcXCrYA2CQ3vWK2tIbuqs3bZXCOEghFBrFUT0kLzGeJnQLDVkcDf JeVQFhb8u451rFeDOcXAav+qYxenG8JEUC3TpQ4L4RE2SX5uyEasVohLxNRF/g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646866220; a=rsa-sha256; cv=none; b=ViKQBFAPZRWAHqeAft8MVFF9b1JSU59EHAGyEQVWFEZq+YBrxvnHe3XECQGsKzA4D9APFG vIPf0eJ9/Wq68Dr3z28KQva2DevvFf7DeGBQyPU1lFaJ2wF2viejQZg09J8aU1AFZpDjvG dX+AWuhaWdFHpMdChU0uXGCvMlZTGeX8mwfqlmiY7OqDZbF7vfCqkDi3IGqpLb0E+65vxg kGVt3+7FXZ1ccW1ru50nneRaD4eX5aB0k3YG8LPtMsNY08aWtwYk34htX+EkdHDF31NROg CELyDhf20hohjBa65PGNnlHRFZcVeyA1k9vnC1Hhsc4DDy41pPr8o32BQ77NNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_6E128573-23BB-478A-A548-700362A28FB2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 9 Mar 2022, at 22:45, John Baldwin wrote: >=20 > On 3/9/22 1:30 PM, Dimitry Andric wrote: >> The branch main has been updated by dim: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D7ecd99fa424df001028c5cddc52d25b2= 9232f1af >> commit 7ecd99fa424df001028c5cddc52d25b29232f1af >> Author: Dimitry Andric >> AuthorDate: 2022-03-09 21:23:35 +0000 >> Commit: Dimitry Andric >> CommitDate: 2022-03-09 21:23:35 +0000 >> Build compiler-rt against libunwind, not libcxxrt >> Parts of compiler-rt are also built for libgcc_eh and = libgcc_s, and >> these were already pointing to the libunwind unwind.h. For the = sake of >> consistency, also build compiler-rt itself against the libunwind >> unwind.h, not the libcxxrt one. >=20 > Do we even need the explicit -I at all now that we install unwind.h = into /usr/include? That depends on the build order; if libcompiler_rt is built before = libunwind's headers are installed into ${WORLDTMP}, it might look at the = wrong file? I guess this is just a 'better safe than sorry' approach. That said, for = libcxxrt we used to have the unwind headers only in the C++ include = path, so maybe this was a way to get that to work? -Dimitry --Apple-Mail=_6E128573-23BB-478A-A548-700362A28FB2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCYikvJAAKCRCwXqMKLiCW o/iXAJwJMelfy+bN4PMsNOWVFmklj7+sPACg/Z0EF+pI1uX1XGCI3/tCoINEkhs= =C8cR -----END PGP SIGNATURE----- --Apple-Mail=_6E128573-23BB-478A-A548-700362A28FB2--