From nobody Mon Mar 07 19:09:02 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 880921A1F890; Mon, 7 Mar 2022 19:09:08 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KC7Kv2KXQz4nhS; Mon, 7 Mar 2022 19:09:06 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x832.google.com with SMTP id s15so14130008qtk.10; Mon, 07 Mar 2022 11:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=14AG/EWtH3uDQtD9BM9BVo1/gKQSJSqpUDVr2iDqOVg=; b=RfGC4tgNGXw63idJU/ypyld+NBRvIUWZW4SxmBShhicDkaZo5/9s01NghM4ejT3NVn pLKg3YknsLNO0ufQr+mscVRZfmHopP08FUN7NJ+1Dtowc95YQXS7UcBnrrbMxv7lG7BZ bxlxrJa0sdnq4JIkftveryOe6XolqbX20+9tnkEyKrJu5p0nXhesefAs3cqwyZpmxzsM RcNvk4jU7huflSS/yhPM6z3anFa+9P28XY+bnWjDulVfytiNZol6kM4SG3HR4VQMQKSR DnzGCYjJn2nuP5yERpxyCqZURtddCHR3r3ipwGbK1naBt/Pi9eQvuoNfyPLgVmrOv4Ve RQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=14AG/EWtH3uDQtD9BM9BVo1/gKQSJSqpUDVr2iDqOVg=; b=NZvgH4gf76tzMe0Gbr1um2bGL5U+tpt8VfnPTnnlnnjtRKWItuQ3ci8ftb5WOZ5aZb oFhJka14s7+wIjrswytQXajdsz3CZ9EcEqkNHxkPdU675Ik9EVb3vqdEBKHEeFXnZ2v3 /dQtZlYfq+wvFXktdDljyN7aMe7Y5KShwCPu+NhMPdijoyD2YoY26SefZ61ZsNDiWwQA aEpYv0CjN/5o/rFD5cUE7aSY2MyX+m7JOZSFw7Ez5V9vig2Q2AW49lJH+sg3UU3l2pUo 5z8LEdkguqMvP40W9LouBXucOphD/MFm/rNh3j15qWr7kZxwhtO4mpOPR34qmHjrE9za Vecg== X-Gm-Message-State: AOAM530q+h9I0ZizuewUwM35U56uUfoo1KP8DqBHcY+VWSvYs57QzZhW AybpaqwJD9OPI9eO/H+O4xrMD2T2VHU= X-Google-Smtp-Source: ABdhPJzwY2TlV/sGspqnNFoIdKLeutDEkJZHP5od0WOVGe463KlHO1O/9E2vL+Nf5wYWanVaY/rUuA== X-Received: by 2002:ac8:57d4:0:b0:2de:6f5c:4214 with SMTP id w20-20020ac857d4000000b002de6f5c4214mr10950868qta.200.1646680145850; Mon, 07 Mar 2022 11:09:05 -0800 (PST) Received: from nuc (198-84-189-58.cpe.teksavvy.com. [198.84.189.58]) by smtp.gmail.com with ESMTPSA id f14-20020a05620a12ee00b00508b2c61482sm6457582qkl.25.2022.03.07.11.09.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 11:09:05 -0800 (PST) Date: Mon, 7 Mar 2022 14:09:02 -0500 From: Mark Johnston To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3fe1f21fb364 - main - ctf: Avoid passing a caddr_t to roundup2() Message-ID: References: <202203071621.227GL47F099339@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4KC7Kv2KXQz4nhS X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=RfGC4tgN; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::832 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::832:from]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-ThisMailContainsUnwantedMimeParts: N On Mon, Mar 07, 2022 at 11:04:51AM -0800, John Baldwin wrote: > On 3/7/22 8:21 AM, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3fe1f21fb364e38f2bf7e7100dad59b067b27080 > > > > commit 3fe1f21fb364e38f2bf7e7100dad59b067b27080 > > Author: Mark Johnston > > AuthorDate: 2022-03-07 16:18:40 +0000 > > Commit: Mark Johnston > > CommitDate: 2022-03-07 16:20:57 +0000 > > > > ctf: Avoid passing a caddr_t to roundup2() > > > > For some reason I can't reproduce this locally, but Jenkins complains. > > > > Reported by: Jenkins > > Fixes: bdf290cd3e1a ("ctf: Add v3 support to CTF tools, ctf{convert,dump,merge}") > > Odd, do you have a copy of the warning/error you got (and which compiler and arch?) /usr/src/cddl/contrib/opensolaris/tools/ctf/cvt/ctf.c:1336:11: error: invalid operands to binary expression ('caddr_t' (aka 'char *') and 'int') dptr = roundup2(dptr, 4); ^~~~~~~~~~~~~~~~~ /usr/include/sys/param.h:310:38: note: expanded from macro 'roundup2' #define roundup2(x, y) (((x)+((y)-1))&(~((y)-1))) /* if y is powers of two */ ~~~~~~~~~~~~~^~~~~~~~~~~ I'm not sure which compiler was in use. All platforms failed. I later tried building world in a 13.0-RELEASE amd64 jail, and that reproduced the failure. So maybe the version of LLVM shipped there (11.0) is more picky? > Even for CHERI (which can be pickier about such things) roundup2() works fine on > caddr_t / char *. > > -- > John Baldwin