From nobody Sun Mar 06 17:36:24 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6C82719FF7BF; Sun, 6 Mar 2022 17:36:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KBTKN2ZmQz4dLv; Sun, 6 Mar 2022 17:36:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646588184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XEelQp2zI2ZZqkTr39ZpkuJR8yJlQWdL7+lZj3NNalU=; b=V2w/n7/AmIYdIjsxbKP0kN/dp51gLuV6waMy/kx3ptSy+JjsDbSoY3l+LJ6qbzcm+eLtA+ ecMc9nDPlNS0ddGYGFWFLxfJcEX3wmmx75rSPIau+KEa4BB7K2hXsqZ4O7qM3Geat5FOfd mbqNizBQ5boj1F3sOclGGwKo6/iEjZlQ24zdb10Bmwd55yBFYDg6XjTB+i+LX6L0PpERJe 5G6ALX1nppcoeJ8cZG9+ZXkXWT3HJx1PQIwkk/zJvqI27/Kqpt3sabIJSKvFyHvRGnUDjF Ip9+7UnlplHKWZ3rIir1WEB0wBL2lGYJpWiqekJaXDZdtSVrwKQtHAvEFJoN/g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 383B018C0B; Sun, 6 Mar 2022 17:36:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 226HaOpn060707; Sun, 6 Mar 2022 17:36:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 226HaO2i060706; Sun, 6 Mar 2022 17:36:24 GMT (envelope-from git) Date: Sun, 6 Mar 2022 17:36:24 GMT Message-Id: <202203061736.226HaO2i060706@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vincenzo Maffione Subject: git: dd6ab49a9aeb - main - netmap: add a tunable for the maximum number of VALE switches List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vmaffione X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dd6ab49a9aebb5fbb85973d9a859d24daa5e2165 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646588184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XEelQp2zI2ZZqkTr39ZpkuJR8yJlQWdL7+lZj3NNalU=; b=EtRgtZgsbQFSQjbDJSxeILDMa//0ykEaA/JPNzZRUYrpw+UPiKDmKTS2/eT6KybWPaN6H9 O6Rur8zDIBoZ8FitOiKltgpdJy7lGtm5jfvbJrbU0viR/Ab96xC7zTSt/DleByJCVMK55I yACow7YutxvQ2MjY0MWoTcscJhTqSQooRa9WEQ5mUoAiwANnfoaM6p/NBOsw2l9NNgmCBA vXnSmEqkBDXBCQXAfxQRt1UfNxlrb6L/nYE5zWuFr0Aw9WnfTVgNadxIfOv9zxPbNw3wC1 kQAE+qcEl3qmyHcevSw4pqdCB9mpJPWT9dNqcJW1Oi9XNbvVyQa/3IPIq3fqnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646588184; a=rsa-sha256; cv=none; b=thvilzjS1t8LIR3tCbMxau2PUBxIsQ8OFSWh9Q0cN0+W5w5biiM6kSVD+34IvwPIEd9lvK ZAIClXFeIjIvsT0TOk6U62KlTD+/4ISdLHwAdae74OeYtLuo/2QuFiM2ghqwHjA3lwjvb8 moNWJDPxAwU9raFseW0LNZ4A1oJ8WUkrxOmXb3aZGcpm9zJYZYmBd6mu4mg+KBTI56FYMU Fh1Zotq8QGDtWeSBXmbH4FU3GZo0aj3yKs9FEn39Nap4TlzA1Fys5yF7JtoDGg6bPn+R8H gD8apyN4vgnlTaJNd4RgaHxaYlXzMVRYzyPGITRoS99lYqHNsWeiSpgVlkCwYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by vmaffione: URL: https://cgit.FreeBSD.org/src/commit/?id=dd6ab49a9aebb5fbb85973d9a859d24daa5e2165 commit dd6ab49a9aebb5fbb85973d9a859d24daa5e2165 Author: Vincenzo Maffione AuthorDate: 2022-03-06 17:28:44 +0000 Commit: Vincenzo Maffione CommitDate: 2022-03-06 17:29:44 +0000 netmap: add a tunable for the maximum number of VALE switches The new dev.netmap.max_bridges sysctl tunable can be set in loader.conf(5) to change the default maximum number of VALE switches that can be created. Current defaults is 8. MFC after: 2 weeks --- share/man/man4/netmap.4 | 7 ++++++- share/man/man4/vale.4 | 5 +++-- sys/dev/netmap/netmap_bdg.c | 4 ++-- sys/dev/netmap/netmap_kern.h | 4 +++- sys/dev/netmap/netmap_vale.c | 13 +++++++++---- 5 files changed, 23 insertions(+), 10 deletions(-) diff --git a/share/man/man4/netmap.4 b/share/man/man4/netmap.4 index 46a2f53b9b1f..535b2dfdfb4e 100644 --- a/share/man/man4/netmap.4 +++ b/share/man/man4/netmap.4 @@ -27,7 +27,7 @@ .\" .\" $FreeBSD$ .\" -.Dd October 3, 2020 +.Dd March 6, 2022 .Dt NETMAP 4 .Os .Sh NAME @@ -933,6 +933,11 @@ Batch size used when moving packets across a switch. Values above 64 generally guarantee good performance. +.It Va dev.netmap.max_bridges: 8 +Max number of +.Nm VALE +switches that can be created. This tunable can be specified +at loader time. .It Va dev.netmap.ptnet_vnet_hdr: 1 Allow ptnet devices to use virtio-net headers .El diff --git a/share/man/man4/vale.4 b/share/man/man4/vale.4 index a28114470a6e..f805b1b4031b 100644 --- a/share/man/man4/vale.4 +++ b/share/man/man4/vale.4 @@ -28,7 +28,7 @@ .\" $FreeBSD$ .\" $Id: $ .\" -.Dd February 6, 2020 +.Dd March 6, 2022 .Dt VALE 4 .Os .Sh NAME @@ -77,7 +77,8 @@ See for details on the API. .Ss LIMITS .Nm -currently supports up to 8 switches, with 254 ports per switch. +currently supports up to 254 ports per switch. The maximum +number of switches is provided by the max_bridges sysctl variable. .Sh SYSCTL VARIABLES See .Xr netmap 4 diff --git a/sys/dev/netmap/netmap_bdg.c b/sys/dev/netmap/netmap_bdg.c index 103a3b00762e..1d49a97eec12 100644 --- a/sys/dev/netmap/netmap_bdg.c +++ b/sys/dev/netmap/netmap_bdg.c @@ -1828,7 +1828,7 @@ netmap_init_bridges(void) #ifdef CONFIG_NET_NS return netmap_bns_register(); #else - nm_bridges = netmap_init_bridges2(NM_BRIDGES); + nm_bridges = netmap_init_bridges2(vale_max_bridges); if (nm_bridges == NULL) return ENOMEM; return 0; @@ -1841,6 +1841,6 @@ netmap_uninit_bridges(void) #ifdef CONFIG_NET_NS netmap_bns_unregister(); #else - netmap_uninit_bridges2(nm_bridges, NM_BRIDGES); + netmap_uninit_bridges2(nm_bridges, vale_max_bridges); #endif } diff --git a/sys/dev/netmap/netmap_kern.h b/sys/dev/netmap/netmap_kern.h index 5d8957241c21..f8d824f08ebb 100644 --- a/sys/dev/netmap/netmap_kern.h +++ b/sys/dev/netmap/netmap_kern.h @@ -1559,6 +1559,8 @@ int netmap_get_vale_na(struct nmreq_header *hdr, struct netmap_adapter **na, void *netmap_vale_create(const char *bdg_name, int *return_status); int netmap_vale_destroy(const char *bdg_name, void *auth_token); +extern unsigned int vale_max_bridges; + #else /* !WITH_VALE */ #define netmap_bdg_learning(_1, _2, _3, _4) 0 #define netmap_get_vale_na(_1, _2, _3, _4) 0 @@ -1606,7 +1608,7 @@ extern struct nm_bridge *nm_bridges; #define netmap_bns_get() #define netmap_bns_put(_1) #define netmap_bns_getbridges(b, n) \ - do { *b = nm_bridges; *n = NM_BRIDGES; } while (0) + do { *b = nm_bridges; *n = vale_max_bridges; } while (0) #endif /* Various prototypes */ diff --git a/sys/dev/netmap/netmap_vale.c b/sys/dev/netmap/netmap_vale.c index aac4cfe6736a..7813984ad295 100644 --- a/sys/dev/netmap/netmap_vale.c +++ b/sys/dev/netmap/netmap_vale.c @@ -84,10 +84,9 @@ __FBSDID("$FreeBSD$"); /* * system parameters (most of them in netmap_kern.h) - * NM_BDG_NAME prefix for switch port names, default "vale" + * NM_BDG_NAME prefix for switch port names, default "vale" * NM_BDG_MAXPORTS number of ports - * NM_BRIDGES max number of switches in the system. - * XXX should become a sysctl or tunable + * NM_BRIDGES max number of switches in the system. * * Switch ports are named valeX:Y where X is the switch name and Y * is the port. If Y matches a physical interface name, the port is @@ -115,10 +114,16 @@ __FBSDID("$FreeBSD$"); * last packet in the block may overflow the size. */ static int bridge_batch = NM_BDG_BATCH; /* bridge batch size */ + +/* Max number of vale bridges (loader tunable). */ +unsigned int vale_max_bridges = NM_BRIDGES; + SYSBEGIN(vars_vale); SYSCTL_DECL(_dev_netmap); SYSCTL_INT(_dev_netmap, OID_AUTO, bridge_batch, CTLFLAG_RW, &bridge_batch, 0, "Max batch size to be used in the bridge"); +SYSCTL_UINT(_dev_netmap, OID_AUTO, max_bridges, CTLFLAG_RDTUN, &vale_max_bridges, 0, + "Max number of vale bridges"); SYSEND; static int netmap_vale_vp_create(struct nmreq_header *hdr, struct ifnet *, @@ -366,7 +371,7 @@ netmap_vale_list(struct nmreq_header *hdr) j = req->nr_port_idx; NMG_LOCK(); - for (error = ENOENT; i < NM_BRIDGES; i++) { + for (error = ENOENT; i < vale_max_bridges; i++) { b = bridges + i; for ( ; j < NM_BDG_MAXPORTS; j++) { if (b->bdg_ports[j] == NULL)