From nobody Sat Mar 05 00:50:43 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3D37819E14DD; Sat, 5 Mar 2022 00:50:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K9R3W12wZz4VPm; Sat, 5 Mar 2022 00:50:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf2f.google.com with SMTP id b12so7934362qvk.1; Fri, 04 Mar 2022 16:50:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b2jJ+VW+YO1EQewa2Gh1fuMPgc3PhKhbEEd48xCvkJ4=; b=qwnCPiUua7cPUrvDYsJ+KKc11eQ1G/62ATa26xmsiopdCJgYXk/Pys0tNWLRH9O1iw PzgGjfP9gwIeIrSHbYFbN5mioAAHN6isB7Ie37MwQLZ7jZbSD9Gk0jCnrxvNVIWdlUq2 ET2PbVIfNKSf+YKfqub8zE+IQYDTQiL5Q7rX6rPEaABisBboOZQl+NMv8tGFIHmrfMXm HzMBkKLs6hH0Vuc1lRSCasc7axCVAC1C3fSSorpyVSuhE4OLwZAKWk3LujucZhgLrX80 2XMFmWqqJsbpkUaVz8k4iD6zeoVoIvLeyrszMgFPihqc8E9TN1xYYdqzM1ghYNg5jz+h VCgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=b2jJ+VW+YO1EQewa2Gh1fuMPgc3PhKhbEEd48xCvkJ4=; b=g4mx2ROeClj8M6zRo/dYCxu7895a3ZYcO+u0Fhy0KaCYQA8pqjBjCARa6ZrvfB3LPh KQ01RFyX0Qk4O6O7JnpE7MsWlDcCJoTKpmp4ohL17R9McytonNSzlKP7GB+GofK053Ql KUgGrxdX2yC6KV4dFePJoia6q3xE9dHeY4yPyuc3yhebhEMTAjMJubIGfhFcf5B2Q+bF a2Xd6y+vVr3cSdJUuwGJ25UG1tZ6+WpwuDlESTlgxB3tlgKT5IpWK475skfGtPK2QhtH 7W0o/Rjifsk86Mw1qxwvaDXxhZI7UmtQwTxaPvZmGPcLXR97kboqJ1YF6nVshpta2d0i SmPA== X-Gm-Message-State: AOAM532CGZZv7ueJCBURmLMKMWFrC23DbcvCslEQpP1Ges4fTlfgLzhR 1GcO0+T7bV/rhRMrxtvL0JPWbCDXx9M= X-Google-Smtp-Source: ABdhPJzbRKkkmo4jHOdQnYwTFw3ztQMt1iERr8AMCWmYN5jhWBaIm3R/klvYyKPXMUAmgM/uWuJmlw== X-Received: by 2002:a05:6214:5193:b0:435:2071:fe81 with SMTP id kl19-20020a056214519300b004352071fe81mr919527qvb.34.1646441446693; Fri, 04 Mar 2022 16:50:46 -0800 (PST) Received: from nuc (198-84-189-58.cpe.teksavvy.com. [198.84.189.58]) by smtp.gmail.com with ESMTPSA id w13-20020a05622a190d00b002dd2600afc2sm4447977qtc.62.2022.03.04.16.50.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 16:50:46 -0800 (PST) Date: Fri, 4 Mar 2022 19:50:43 -0500 From: Mark Johnston To: Shawn Webb Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 84369dd52369 - main - x86: Probe the TSC frequency earlier Message-ID: References: <202203011439.221EdtpY038505@gitrepo.freebsd.org> <20220304142447.bmo7r6syd6gsunnt@mutt-hbsd> <20220304175226.avi2r57dvjfeyr7w@mutt-hbsd> <20220304181529.isvkyyx3qwcbt6v7@mutt-hbsd> <20220304211027.ztkf4knrpeeyhkld@mutt-hbsd> <20220304230904.tx26rtpu4xrpflju@mutt-hbsd> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304230904.tx26rtpu4xrpflju@mutt-hbsd> X-Rspamd-Queue-Id: 4K9R3W12wZz4VPm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Fri, Mar 04, 2022 at 06:09:04PM -0500, Shawn Webb wrote: > On Fri, Mar 04, 2022 at 04:10:27PM -0500, Shawn Webb wrote: > > On Fri, Mar 04, 2022 at 01:31:10PM -0500, Mark Johnston wrote: > > > On Fri, Mar 04, 2022 at 01:15:29PM -0500, Shawn Webb wrote: > > > > On Fri, Mar 04, 2022 at 12:52:26PM -0500, Shawn Webb wrote: > > > > > On Fri, Mar 04, 2022 at 10:13:54AM -0500, Mark Johnston wrote: > > > > > > On Fri, Mar 04, 2022 at 09:24:47AM -0500, Shawn Webb wrote: > > > > > > > On Tue, Mar 01, 2022 at 02:39:55PM +0000, Mark Johnston wrote: > > > > > > > > The branch main has been updated by markj: > > > > > > > > > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=84369dd52369cbae28970dca20a53d3de1719907 > > > > > > > > > > > > > > > > commit 84369dd52369cbae28970dca20a53d3de1719907 > > > > > > > > Author: Mark Johnston > > > > > > > > AuthorDate: 2022-03-01 14:39:35 +0000 > > > > > > > > Commit: Mark Johnston > > > > > > > > CommitDate: 2022-03-01 14:39:35 +0000 > > > > > > > > > > > > > > > > x86: Probe the TSC frequency earlier > > > > > > > > > > > > > > > > This lets us use the TSC to implement early DELAY, limiting the use of > > > > > > > > the sometimes-unreliable 8254 PIT. > > > > > > > > > > > > > > > > PR: 262155 > > > > > > > > Reviewed by: emaste > > > > > > > > Tested by: emaste, mike tancsa , Stefan Hegnauer > > > > > > > > MFC after: 1 month > > > > > > > > Sponsored by: The FreeBSD Foundation > > > > > > > > Differential Revision: https://reviews.freebsd.org/D34367 > > > > > > > > --- > > > > > > > > sys/amd64/amd64/machdep.c | 14 +++++- > > > > > > > > sys/i386/i386/machdep.c | 11 ++++- > > > > > > > > sys/x86/include/clock.h | 3 +- > > > > > > > > sys/x86/isa/clock.c | 4 +- > > > > > > > > sys/x86/x86/tsc.c | 123 +++++++++++++++++++++++++--------------------- > > > > > > > > 5 files changed, 94 insertions(+), 61 deletions(-) > > > > > > > > > > > > > > Hey Mark, > > > > > > > > > > > > > > Something about this commit breaks booting in Hyper-V. Reverting this > > > > > > > particular commit makes Hyper-V happy again. > > > > > > > > > > > > The patch below might be sufficient. I'll test it in Azure but it'll > > > > > > take me some time. > > > > > > > > > > > > diff --git a/sys/x86/x86/delay.c b/sys/x86/x86/delay.c > > > > > > index c767250954da..95b994b15f81 100644 > > > > > > --- a/sys/x86/x86/delay.c > > > > > > +++ b/sys/x86/x86/delay.c > > > > > > @@ -89,7 +89,7 @@ delay_tc(int n) > > > > > > return (1); > > > > > > } > > > > > > tc = timecounter; > > > > > > - if (tc->tc_quality <= 0) > > > > > > + if (tc == NULL || tc->tc_quality <= 0) > > > > > > return (0); > > > > > > func = tc->tc_get_timecount; > > > > > > mask = tc->tc_counter_mask; > > > > > > > > > > Great! I'll give this patch a try and report back. > > > > > > > > The proposed patch did not result in successful boot. > > > > > > Ok, I forgot about the dummy timecounter, so that patch did nothing. > > > Can you try this one instead, please? https://reviews.freebsd.org/D34444 > > > > > > I wasn't able to reproduce any problems on Azure, but there HyperV > > > provides an emulated 8254 timer. > > > > Can do. I'll report back soon (possibly tomorrow due to time > > constraints.) > > That patch indeed made the Hyper-V VM happy. Boot was successful. Thanks, committed as 075e2779aca7cbd8f201ce0e1bb60318d0cbd8b8.