From nobody Thu Mar 03 17:15:18 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8B9F019E25A7; Thu, 3 Mar 2022 17:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K8d0Q3Hbkz4YYc; Thu, 3 Mar 2022 17:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646327718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EbnfWSa13I5+pf6z58t/yjJk+f86qApfoNoRHkj6c28=; b=oWN/jHfEnKXapDjTEb99ZZeldim2ZS7Pnh2a9B8HlfW2nkRTy67fGi9Usx7luS0spH7WoR EaObKw/1OqsoXw/zeLNIjWVhnZ/RQ3qDu4gbrOaRlQXy5TguThbo/pZEjMp0OnJ3w07ivl r0UiHlJ4hnxZc4SYg3HPP1nRZ+vWWfr13A1aGKayn2PnuevmKsIHoh5zQYrT9TVXdHITOf cxwFXICwlSrAqyfPT/SFcLbyXiRsjr3Vu7NO4UU7Cau4vat7y5WeMycUddOf5lXttS2hfu mj+U6w5Hc4etqYxv/9Vd6TfjAsapDxpHWGINNi2i6/pt2PwfZOJ+8f9EzPWahw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4E2AC1BC2A; Thu, 3 Mar 2022 17:15:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 223HFIKT029823; Thu, 3 Mar 2022 17:15:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 223HFI05029822; Thu, 3 Mar 2022 17:15:18 GMT (envelope-from git) Date: Thu, 3 Mar 2022 17:15:18 GMT Message-Id: <202203031715.223HFI05029822@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hans Petter Selasky Subject: git: 33cbbf268f7d - main - xhci(4): Add quirk for "TUSB73x0 USB3.0 xHCI Controller". List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 33cbbf268f7d0f3daff0c2aa06836d932faf56a9 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646327718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EbnfWSa13I5+pf6z58t/yjJk+f86qApfoNoRHkj6c28=; b=yCaRiftONC5O+5tteH9P853oSwxUsrlkUSSCQPB50jgLPiyQ4XOqc+s4iLNkptJALeIJjl whlSa58oHuVmNIYJd2fB8AxSEeye5WUoBpg6+iXmnfopvmerrU2D72AiA93V3PW7DXKiH3 lsLA8cOh92jXc+563P454TM5GpgYBL9DWO6mgR6pXTr6W4LAtjkMTgUhoo5J2GzrT5thtd bGi7GLCgCNlyHatC/QPn58x3NT4gG6sMA6QcaVkOnnjrPnp1NhU0nCfKaw4lqx0YYx1xkj xSPAHMdwFdzCFiaoEMLxLVUmH4s/JzNdQxiEYgDUa6RNtvFr3vcvZqXLnjUtvA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646327718; a=rsa-sha256; cv=none; b=l/aCktUgkybGmUa5IeNSYmS4d/dCGBkXii9dcwSFbud8IMZ8O1q/Ka803+rt+EYl7HyfiA +DQ8Z3zwX4JlCwQJQWFYq3h6FZr7/aVUWBxrcjyXe893l+ioD/5gxyKETjIFFQQsueDLld Q8wBxD20GszitpZMzKoar5mx/rHqwTDOgNRyvkklp6ZUEDsfqb/bPhcmc20/HNzXk/0WDi WW2njKaLq7gXS4nbg61QImZT8hMvKMOLjYmQci5myZD6b6SlHa/YeL1DGnVUdgizBGnFxQ pKu+iHcvhWeHewpwlEfnHJ3DXU/O5H4yl+6AWppV6a4kl5x35wHI3OMbjyZgfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=33cbbf268f7d0f3daff0c2aa06836d932faf56a9 commit 33cbbf268f7d0f3daff0c2aa06836d932faf56a9 Author: Hans Petter Selasky AuthorDate: 2022-03-03 16:32:20 +0000 Commit: Hans Petter Selasky CommitDate: 2022-03-03 17:14:21 +0000 xhci(4): Add quirk for "TUSB73x0 USB3.0 xHCI Controller". Tested by: br@ MFC after: 1 week Sponsored by: NVIDIA Networking --- sys/dev/usb/controller/xhci.c | 11 +++++++++-- sys/dev/usb/controller/xhci.h | 5 ++++- sys/dev/usb/controller/xhci_pci.c | 7 ++++++- 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/sys/dev/usb/controller/xhci.c b/sys/dev/usb/controller/xhci.c index febb5f3d82cb..f95996b7ab32 100644 --- a/sys/dev/usb/controller/xhci.c +++ b/sys/dev/usb/controller/xhci.c @@ -2,7 +2,7 @@ /*- * SPDX-License-Identifier: BSD-2-Clause-FreeBSD * - * Copyright (c) 2010 Hans Petter Selasky. All rights reserved. + * Copyright (c) 2010-2022 Hans Petter Selasky * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -104,6 +104,10 @@ static int xhcictlquirk = 1; SYSCTL_INT(_hw_usb_xhci, OID_AUTO, ctlquirk, CTLFLAG_RWTUN, &xhcictlquirk, 0, "Set to enable control endpoint quirk"); +static int xhcidcepquirk; +SYSCTL_INT(_hw_usb_xhci, OID_AUTO, dcepquirk, CTLFLAG_RWTUN, + &xhcidcepquirk, 0, "Set to disable endpoint deconfigure command"); + #ifdef USB_DEBUG static int xhcidebug; static int xhciroute; @@ -1477,8 +1481,11 @@ xhci_cmd_configure_ep(struct xhci_softc *sc, uint64_t input_ctx, temp = XHCI_TRB_3_TYPE_SET(XHCI_TRB_TYPE_CONFIGURE_EP) | XHCI_TRB_3_SLOT_SET(slot_id); - if (deconfigure) + if (deconfigure) { + if (sc->sc_no_deconfigure != 0 || xhcidcepquirk != 0) + return (0); /* Success */ temp |= XHCI_TRB_3_DCEP_BIT; + } trb.dwTrb3 = htole32(temp); diff --git a/sys/dev/usb/controller/xhci.h b/sys/dev/usb/controller/xhci.h index ff7ec23ca5f2..e5c189697067 100644 --- a/sys/dev/usb/controller/xhci.h +++ b/sys/dev/usb/controller/xhci.h @@ -3,7 +3,7 @@ /*- * SPDX-License-Identifier: BSD-2-Clause-FreeBSD * - * Copyright (c) 2010 Hans Petter Selasky. All rights reserved. + * Copyright (c) 2010-2022 Hans Petter Selasky * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -555,6 +555,9 @@ struct xhci_softc { /* size of context */ uint8_t sc_ctx_is_64_byte; + /* deconfiguring USB device is not fully supported */ + uint8_t sc_no_deconfigure; + /* Isochronous Scheduling Threshold */ uint8_t sc_ist; diff --git a/sys/dev/usb/controller/xhci_pci.c b/sys/dev/usb/controller/xhci_pci.c index bb9baee6800d..be12d8c33382 100644 --- a/sys/dev/usb/controller/xhci_pci.c +++ b/sys/dev/usb/controller/xhci_pci.c @@ -1,7 +1,7 @@ /*- * SPDX-License-Identifier: BSD-2-Clause-FreeBSD * - * Copyright (c) 2010 Hans Petter Selasky. All rights reserved. + * Copyright (c) 2010-2022 Hans Petter Selasky * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -287,6 +287,9 @@ xhci_pci_attach(device_t self) sc->sc_io_size = rman_get_size(sc->sc_io_res); switch (pci_get_devid(self)) { + case 0x8241104c: /* TUSB73x0 USB3.0 xHCI Controller */ + sc->sc_no_deconfigure = 1; + break; case 0x01941033: /* NEC uPD720200 USB 3.0 controller */ case 0x00141912: /* NEC uPD720201 USB 3.0 controller */ /* Don't use 64-bit DMA on these controllers. */ @@ -310,6 +313,8 @@ xhci_pci_attach(device_t self) sc->sc_imod_default = XHCI_IMOD_DEFAULT_LP; sc->sc_ctlstep = 1; break; + default: + break; } if (xhci_init(sc, self, usedma32)) {