From nobody Tue Mar 01 20:10:08 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4753919DA2D5; Tue, 1 Mar 2022 20:10:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K7Sz4710cz3BtS; Tue, 1 Mar 2022 20:10:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646165409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J4KBIbqHxkCL7pA54CSpbFkpSBnIQ/y3N6baZcO/kAY=; b=XJSjFcunfSzui8bWnFm7dllmjo6AMk/C7uoJpe3u6n7GIWz5oBvkm/tt9AZVsb8FxK/upM tLXrnAkqhT1R6kbzBeFSgUhdNOgumXr9auiA/Z8BlbZ2W886QRH7wgnoGg/mPECViZM6Ui qgW9a7IYc9hPjfQnLhpCczs4X5sIUhRk7LWYFo3AB3/a1qwZTvNfNIAQmAiDqvleUqLcgH RqQUkaQi/FLvO5GCUsiDS/2z8hS7ZrlliiYPrh9Z4gdFvxF1P4rYXWfpNg2m2pxG/EWRzw fnaSh3QMfagyNgLMNoZwCJh6pcZcg4f0lZB/wKFhemafxGZ4HQGQN3qs7Q52Zg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C20CD15EBA; Tue, 1 Mar 2022 20:10:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 221KA81m086154; Tue, 1 Mar 2022 20:10:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 221KA8ll086151; Tue, 1 Mar 2022 20:10:08 GMT (envelope-from git) Date: Tue, 1 Mar 2022 20:10:08 GMT Message-Id: <202203012010.221KA8ll086151@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 879b0604a894 - main - proc: Remove assertion that P_WEXIT is not set in proc_rwmem() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 879b0604a8940f575f03bde5457bcf13e64c1ae8 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646165409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J4KBIbqHxkCL7pA54CSpbFkpSBnIQ/y3N6baZcO/kAY=; b=rfL7G5QbJ8mAogza8QTpnCD6iegAxYTol2kyc++EIE88DFQqI2LJ2txsEfDJP2/i3DxhLf XqchAxCvsYa8S/yuhjHb8zDEVlEEbwqUoH85cxHE11ZmHwP4A6APSOEXV16XUkO6ixP1K+ S4CaFSifmfzVF4n5oY1LjqnHvYvSBQ5mOyBg6OLYa/43Ot/uYx0u6xbaNB3LEMw1yTtfRc qvRRJE7RzZrwalUWi1LrJiE3QG/r6dopaHOVKjgYJJW6mAZmZtLiIefx2LnqdFj7KuaytL X7EcCtoEHc8wed+rpG78wHCPn7Hk02WqhZYinHxt1ukGGcEAXYNjZE1ADAH1lQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646165409; a=rsa-sha256; cv=none; b=FIxVpbXT8migpo2JLeDygL/oq+BG4qCN+NGJ5BiW5I8sWuQBc/rF+m0tWFRD7Cd62MIDFd fFdLPWAbmQzxnEaHQte0j3OVExG/z6Wi/uDMVsAdrkZu+i/NAKk94sCaXNT6qWqJATdm/O ps6SkmCSBomG20C6DTTbQIuO7zRm7fZpwpG4KsD5Wao282122UbOG4Kd0i7iZ04Wb3bysm YVJ6GJbxWYvLspIQqEZWowUtM+hJuzfLfg+LCNXfL4+3k92WKhXB/t2lYG7L2LfNCRmVo1 PhJ6vm1eBPB/GjxjEcYcEqpjk6N1X8coElsjZUN2fBA9+UBVxqx0ymEMLENMDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=879b0604a8940f575f03bde5457bcf13e64c1ae8 commit 879b0604a8940f575f03bde5457bcf13e64c1ae8 Author: Mark Johnston AuthorDate: 2022-03-01 20:08:25 +0000 Commit: Mark Johnston CommitDate: 2022-03-01 20:09:45 +0000 proc: Remove assertion that P_WEXIT is not set in proc_rwmem() exit1() sets P_WEXIT before waiting for holding threads to finish, rather than after, so this assertion is racy. Fixes: 12fb39ec3e6b ("proc: Relax proc_rwmem()'s assertion on the process hold count") Reported by: Jenkins --- sys/kern/sys_process.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/kern/sys_process.c b/sys/kern/sys_process.c index 8d8c5a1d34ff..965e22a38598 100644 --- a/sys/kern/sys_process.c +++ b/sys/kern/sys_process.c @@ -340,8 +340,6 @@ proc_rwmem(struct proc *p, struct uio *uio) */ if (p != curproc) PROC_ASSERT_HELD(p); - KASSERT((p->p_flag & P_WEXIT) == 0, - ("%s: process %p is exiting", __func__, p)); PROC_LOCK_ASSERT(p, MA_NOTOWNED); /*