From nobody Wed Jun 29 18:32:15 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id A68AB87EA32; Wed, 29 Jun 2022 18:32:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LY96l2k1zz4d8M; Wed, 29 Jun 2022 18:32:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656527535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z6sG6rG8zqBJRu9WMZKUVhlmbdfqltX1KQvw4AnDcvY=; b=nFm3FYQohT5UoPI1YXoDaE12s47PXt3bHLQXymxDjxZXDHbXHZLWc3lHnR0g0s6Te+OaNi 0RPUFtbJti+apphVh+ZKxyC1lP9E4ArUdNVXrV6AQe9HqvmTipwTdfKhKwSCsdXHtmkQIj Cx2aorMrHSvG0dgyO8xKXocfsQ2bzCmCJs5v0V8X7qVc8aevwq/heEHavEwUg1K5CuPOXs XZnnUBtQ7pn5xAM0Ej51XBuVumUPiowUWUqDZmoNEmto3eD6ySht4VVz39Rf6DCIkZiyUP frgM5pVQhieB8l0TLtj2G247nO61OPEtykhHlgn2I+aduWNVxpdhMuCmF/Wn6A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2D9F916EB3; Wed, 29 Jun 2022 18:32:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25TIWFCr051743; Wed, 29 Jun 2022 18:32:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25TIWFfJ051742; Wed, 29 Jun 2022 18:32:15 GMT (envelope-from git) Date: Wed, 29 Jun 2022 18:32:15 GMT Message-Id: <202206291832.25TIWFfJ051742@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: ad175a107b4e - main - vfs_mount.c: convert explicit panics and KASSERTs to MPASSERT/MPPASS List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad175a107b4e0fdc0128c98c3ca9d6cf8006aba7 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656527535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z6sG6rG8zqBJRu9WMZKUVhlmbdfqltX1KQvw4AnDcvY=; b=Cn6FZJgy8zBKZSED51vw/pmDMTzJ0XCkOeel6bAqvCflb9qsBAHXcMymfvEGmiPPWZjGHh jQgD2qE9WKWeyEG6v3HyJevl+Xdjy6SDPOOZUy6TCIKr8Fb46Rzu2qAGE44tip5hAfaxvy FMw6+j24zRnwHsHf6XALhjh+LqWYOKFg4cTdmAetgfbqEFS6WwXqN0hxd+buXLa1fCDyq2 cOC33uwmplba7/DCuE4gRbcv9HUMpalmKxv7IMxHxbFUg/TYjFew0X0EkWA02C2pLI43Aw g5yPQwRloDlKal+BFAlSVnuUckC92pRvb5BdwR7YEZ/ld5YHSu5Ur5Vf7jeZLQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656527535; a=rsa-sha256; cv=none; b=N5vY6vlOXrpnz0aPc+9PcsVB/baVh5WURHYtmAyVeMhhS7Q9JPgo5GCyNso3OlCqaugMUs uMpIpbpiExC0aaJ8+e43vyHQLpFSNU1SoBSY/Dbl6cAmMoSqnmfCPL/RYnOnkntlRiqvsW lLvTMLKr6cIKknwACsUWwAPL0GQikvlTYrzuYbliJiMx1NNGN35YH+oAjBCqCuQ5HLziNz Hidzb0aNgToNdFpdklN5hs7lUlCrbFXLdif1/Rkj7g/yJOJKWr2VVuoRO6Q7MxVSsa9vGV C3kQy3toV8kUsaCIu2gwexxkeyCJePTCl70FPPmLTLE8YVLA2bxeAbQLTNFS3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=ad175a107b4e0fdc0128c98c3ca9d6cf8006aba7 commit ad175a107b4e0fdc0128c98c3ca9d6cf8006aba7 Author: Konstantin Belousov AuthorDate: 2022-06-29 11:37:58 +0000 Commit: Konstantin Belousov CommitDate: 2022-06-29 18:31:47 +0000 vfs_mount.c: convert explicit panics and KASSERTs to MPASSERT/MPPASS Reviewed by: imp, mjg Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D35652 --- sys/kern/vfs_mount.c | 57 +++++++++++++++++++++------------------------------- 1 file changed, 23 insertions(+), 34 deletions(-) diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c index 73cc34da79ea..7d74ec8b0a9e 100644 --- a/sys/kern/vfs_mount.c +++ b/sys/kern/vfs_mount.c @@ -679,12 +679,10 @@ vfs_mount_alloc(struct vnode *vp, struct vfsconf *vfsp, const char *fspath, mp->mnt_nvnodelistsize = 0; TAILQ_INIT(&mp->mnt_lazyvnodelist); mp->mnt_lazyvnodelistsize = 0; - if (mp->mnt_ref != 0 || mp->mnt_lockref != 0 || - mp->mnt_writeopcount != 0) - panic("%s: non-zero counters on new mp %p\n", __func__, mp); - if (mp->mnt_vfs_ops != 1) - panic("%s: vfs_ops should be 1 but %d found\n", __func__, - mp->mnt_vfs_ops); + MPPASS(mp->mnt_ref == 0 && mp->mnt_lockref == 0 && + mp->mnt_writeopcount == 0, mp); + MPASSERT(mp->mnt_vfs_ops == 1, mp, + ("vfs_ops should be 1 but %d found", mp->mnt_vfs_ops)); (void) vfs_busy(mp, MBF_NOWAIT); atomic_add_acq_int(&vfsp->vfc_refcount, 1); mp->mnt_op = vfsp->vfc_vfsops; @@ -717,8 +715,7 @@ void vfs_mount_destroy(struct mount *mp) { - if (mp->mnt_vfs_ops == 0) - panic("%s: entered with zero vfs_ops\n", __func__); + MPPASS(mp->mnt_vfs_ops != 0, mp); vfs_assert_mount_counters(mp); @@ -733,10 +730,8 @@ vfs_mount_destroy(struct mount *mp) KASSERT(mp->mnt_ref == 0, ("%s: invalid refcount in the drain path @ %s:%d", __func__, __FILE__, __LINE__)); - if (mp->mnt_writeopcount != 0) - panic("vfs_mount_destroy: nonzero writeopcount"); - if (mp->mnt_secondary_writes != 0) - panic("vfs_mount_destroy: nonzero secondary_writes"); + MPPASS(mp->mnt_writeopcount == 0, mp); + MPPASS(mp->mnt_secondary_writes == 0, mp); atomic_subtract_rel_int(&mp->mnt_vfc->vfc_refcount, 1); if (!TAILQ_EMPTY(&mp->mnt_nvnodelist)) { struct vnode *vp; @@ -748,21 +743,16 @@ vfs_mount_destroy(struct mount *mp) KASSERT(mp->mnt_upper_pending == 0, ("mnt_upper_pending")); KASSERT(TAILQ_EMPTY(&mp->mnt_uppers), ("mnt_uppers")); KASSERT(TAILQ_EMPTY(&mp->mnt_notify), ("mnt_notify")); - if (mp->mnt_nvnodelistsize != 0) - panic("vfs_mount_destroy: nonzero nvnodelistsize"); - if (mp->mnt_lazyvnodelistsize != 0) - panic("vfs_mount_destroy: nonzero lazyvnodelistsize"); - if (mp->mnt_lockref != 0) - panic("vfs_mount_destroy: nonzero lock refcount"); + MPPASS(mp->mnt_nvnodelistsize == 0, mp); + MPPASS(mp->mnt_lazyvnodelistsize == 0, mp); + MPPASS(mp->mnt_lockref == 0, mp); MNT_IUNLOCK(mp); - if (mp->mnt_vfs_ops != 1) - panic("%s: vfs_ops should be 1 but %d found\n", __func__, - mp->mnt_vfs_ops); + MPASSERT(mp->mnt_vfs_ops == 1, mp, + ("vfs_ops should be 1 but %d found", mp->mnt_vfs_ops)); - if (mp->mnt_rootvnode != NULL) - panic("%s: mount point still has a root vnode %p\n", __func__, - mp->mnt_rootvnode); + MPASSERT(mp->mnt_rootvnode == NULL, mp, + ("mount point still has a root vnode %p", mp->mnt_rootvnode)); if (mp->mnt_vnodecovered != NULL) vrele(mp->mnt_vnodecovered); @@ -1747,9 +1737,10 @@ vfs_op_enter(struct mount *mp) mp->mnt_writeopcount += mpcpu->mntp_writeopcount; mpcpu->mntp_writeopcount = 0; } - if (mp->mnt_ref <= 0 || mp->mnt_lockref < 0 || mp->mnt_writeopcount < 0) - panic("%s: invalid count(s) on mp %p: ref %d lockref %d writeopcount %d\n", - __func__, mp, mp->mnt_ref, mp->mnt_lockref, mp->mnt_writeopcount); + MPASSERT(mp->mnt_ref > 0 && mp->mnt_lockref >= 0 && + mp->mnt_writeopcount >= 0, mp, + ("invalid count(s): ref %d lockref %d writeopcount %d", + mp->mnt_ref, mp->mnt_lockref, mp->mnt_writeopcount)); MNT_IUNLOCK(mp); vfs_assert_mount_counters(mp); } @@ -1760,13 +1751,11 @@ vfs_op_exit_locked(struct mount *mp) mtx_assert(MNT_MTX(mp), MA_OWNED); - if (mp->mnt_vfs_ops <= 0) - panic("%s: invalid vfs_ops count %d for mp %p\n", - __func__, mp->mnt_vfs_ops, mp); - KASSERT(mp->mnt_vfs_ops > 1 || - (mp->mnt_kern_flag & (MNTK_UNMOUNT | MNTK_SUSPEND)) == 0, - ("%s: vfs_ops too low (%d) for mp %p in unmount or suspend", - __func__, mp->mnt_vfs_ops, mp)); + MPASSERT(mp->mnt_vfs_ops > 0, mp, + ("invalid vfs_ops count %d", mp->mnt_vfs_ops)); + MPASSERT(mp->mnt_vfs_ops > 1 || + (mp->mnt_kern_flag & (MNTK_UNMOUNT | MNTK_SUSPEND)) == 0, mp, + ("vfs_ops too low %d in unmount or suspend", mp->mnt_vfs_ops)); mp->mnt_vfs_ops--; }