From nobody Mon Jun 27 00:51:15 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F044D878A4C for ; Mon, 27 Jun 2022 00:51:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LWTgc1cBBz4jjf for ; Mon, 27 Jun 2022 00:51:24 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f42.google.com with SMTP id r20so10857683wra.1 for ; Sun, 26 Jun 2022 17:51:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=0JF1BUg9S+F2rAv0+zO1Aur5+P8z7lR1/Z0Re/36tA8=; b=uqwV3JwTNzRnxa7DMC8JY98YTdgNFnn97rwIDyEsInRwbZubkHL6Rn2JBYM0as037P XIKk1NVCJXGj0qaYR+AuNSTzADpjHZqmf1uT9P2kRqYa14O2tQg6fIm23qybTXd3g60a LlWgRlhsZKbSqT+LlX4pjHa+NkiAnUgjrezLQCUdEvLFbvVKnIWGKLjUDXqac8Ny18eJ iamvw4XEKPAv2QATvVvY0+A3IIUsBy4Fnw/g7uALJl5xn8B3n6FWrntrAodLgNZcVlBJ UGq+2gGv9y5xdq32XlEmXXEGcBywIgUUvNr+Ji3QuExEpeh7AJTRYCR+1/VDYwVbwh8k 4E8w== X-Gm-Message-State: AJIora9x7zQq8KiRq7B6pHCn3VXxZX1B6yssaI0Cb+E1zuKjmIVEtx/4 DelqLEFFWizvKbJA2/PJAF9PxSjYrJSLcg== X-Google-Smtp-Source: AGRyM1v1GrFCuknb+y4/e/Pf12N/6XMF/9hmVw98zwURFm7FrKXyymxK9fq7RXboj6P/2GBXOegb0w== X-Received: by 2002:adf:d1e1:0:b0:21b:b852:e801 with SMTP id g1-20020adfd1e1000000b0021bb852e801mr9461149wrd.479.1656291076979; Sun, 26 Jun 2022 17:51:16 -0700 (PDT) Received: from smtpclient.apple (global-5-142.nat-2.net.cam.ac.uk. [131.111.5.142]) by smtp.gmail.com with ESMTPSA id m22-20020a05600c3b1600b00397402ae674sm16119849wms.11.2022.06.26.17.51.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 Jun 2022 17:51:16 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: e3572eb65473 - main - Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU. From: Jessica Clarke In-Reply-To: Date: Mon, 27 Jun 2022 01:51:15 +0100 Cc: Toomas Soome , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202206262217.25QMHOuH076130@gitrepo.freebsd.org> To: "Bjoern A. Zeeb" X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4LWTgc1cBBz4jjf X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[jrtc27]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.42:from]; MLMMJ_DEST(0.00)[dev-commits-src-main]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.42:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 27 Jun 2022, at 01:26, Bjoern A. Zeeb wrote: >=20 > On Mon, 27 Jun 2022, Jessica Clarke wrote: >=20 >> On 26 Jun 2022, at 23:17, Toomas Soome wrote: >>>=20 >>> The branch main has been updated by tsoome: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3De3572eb654733a94e1e765fe9e95e057= 9981d851 >>>=20 >>> commit e3572eb654733a94e1e765fe9e95e0579981d851 >>> Author: Aleksandr Rybalko >>> AuthorDate: 2022-02-16 00:19:19 +0000 >>> Commit: Toomas Soome >>> CommitDate: 2022-06-26 18:52:26 +0000 >>>=20 >>> Allocate event for DMC-620 and CMN-600 controllers PMU. Add events = supported by DMC-620 and CMN-600 controllers PMU. >>>=20 >>> Allocate event for DMC-620 and CMN-600 controllers PMU. >>> Add events supported by DMC-620 and CMN-600 controllers PMU. >>>=20 >>> Reviewed by: bz >>> Sponsored By: ARM >>> Sponsored By: Ampere Computing >>> Differential Revision: https://reviews.freebsd.org/D35609 >>=20 >> This includes the following (skipped due to lines) diff: >>=20 >>> * 0x14100 0x0100 ARMv8 events >>> + * 0x14200 0x0020 ARM DMC-620 clkdiv2 events >>> + * 0x14220 0x0080 ARM DMC-620 clk events >>> + * 0x14300 0x0100 ARM CMN-600 events >>=20 >>=20 >> Not enough space was allocated for Armv8 events as it goes up to = 0x3ff >> in Armv8 (and beyond in later versions of the architecture). = Downstream >> we extend this range in CheriBSD as required for Morello=E2=80=99s = events. >> Please relocate these new events well past the end of the existing >> Armv8 events so the space can remain contiguous. >=20 > Should this be 0x3ff then as well btw? > = https://github.com/CTSRD-CHERI/cheribsd/commit/4ea869cd8b717ca0b07672eb7ac= c99bf949249de Well, 0x400 for count not max, but yes. We only extended as far as we needed, not to cover the entire range (but intended to eventually upstream it as the full v8 range). > Looking more closely it seems from ARMv8.1 onwards it goes up to = 0xFFFF > if I read 'Table D8-7 Allocation of the PMU event number space' of ARM > DDI 0487H.a correctly? Yes, if you want to cover all the v8.1 space then you need to go that high too, but it=E2=80=99ll get quite sparse in that range so it=E2=80=99s= unclear if we want to go ahead and do that already or try and be smarter (the current EVENT_xH list would get a bit silly). We should probably reserve all of it though at least so we can if we want to in future. Jess > So we should bump this to 0x15000 at least and use that space for > other events? >=20 > I wonder if anyone will do the 700 soon as well? >=20 > /bz >=20 > --=20 > Bjoern A. Zeeb r15:7