Re: git: 1f1e2261e341 - main - zfs: merge openzfs/zfs@deb121309
Date: Fri, 24 Jun 2022 07:47:02 UTC
Blake3 support needs to be integrated into the boot code anyway. We may need a "compact" implementation in sys/cddl/boot/zfs/ stand/libsa/zfs/zfsimpl.c sys/cddl/boot/zfs/zfssubr.c Cheers, mm On 23. 6. 2022 20:44, Larry Rosenman wrote: > On 06/23/2022 1:43 pm, Toomas Soome wrote: >>> On 23. Jun 2022, at 21:41, Larry Rosenman <ler@lerctr.org> wrote: >>> >>> On 06/23/2022 1:39 pm, Toomas Soome wrote: >>>>> On 23. Jun 2022, at 21:10, Larry Rosenman <ler@lerctr.org> wrote: >>>>> On 06/23/2022 1:02 pm, Toomas Soome wrote: >>>>>>> On 23. Jun 2022, at 20:58, Larry Rosenman <ler@lerctr.org> wrote: >>>>>>> On 06/23/2022 10:50 am, Martin Matuska wrote: >>>>>>>> The branch main has been updated by mm: >>>>>>>> URL: >>>>>>>> https://cgit.FreeBSD.org/src/commit/?id=1f1e2261e341e6ca6862f82261066ef1705f0a7a >>>>>>>> >>>>>>>> commit 1f1e2261e341e6ca6862f82261066ef1705f0a7a >>>>>>>> Merge: a320e9dd51e6 deb1213098e2 >>>>>>>> Author: Martin Matuska <mm@FreeBSD.org> >>>>>>>> AuthorDate: 2022-06-23 15:47:42 +0000 >>>>>>>> Commit: Martin Matuska <mm@FreeBSD.org> >>>>>>>> CommitDate: 2022-06-23 15:49:33 +0000 >>>>>>>> zfs: merge openzfs/zfs@deb121309 >>>>>>>> Notable upstream pull request merges: >>>>>>>> #12918 Introduce BLAKE3 checksums as an OpenZFS feature >>>>>>>> #13553 Reduce ZIO io_lock contention on sorted scrub >>>>>>>> #13537 Improve sorted scan memory accounting >>>>>>>> #13540 AVL: Remove obsolete branching optimizations >>>>>>>> #13563 FreeBSD: Improve crypto_dispatch() handling >>>>>>> Can we get this feature added to gptzfsboot/loader.efi/et al so >>>>>>> we can boot from a pool >>>>>>> with this feature turned on? >>>>>>> zroot feature@blake3 disabled local >>>>>> I think so. >>>>>> Rgds, >>>>>> Toomas >>>>>>> -- >>>>>>> Larry Rosenman http://www.lerctr.org/~ler >>>>>>> Phone: +1 214-642-9640 E-Mail: ler@lerctr.org >>>>>>> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 >>>>> Can we also make it POLICY that if you are adding features to ZFS >>>>> that that boot code (loader.efi/gptzfsboot/et al) >>>>> MUST be updated in the same commit that adds the feature? >>>> Not sure that is always desirable. However, there is alternate >>>> mechanism in OpenZFS for such cases, that should be used (see >>>> zpool-features(7)). >>>> rgds, >>>> toomas >>> What case in zpool-features(7) are you referring to here? >>> >> >> Compatibility feature sets. >> >> rgds, >> toomas > > How does that help here? And PREVENTING foot-shooting?