Re: git: 0f7b9777f8f3 - main - rtw88: split driver up into a core and pci part

On 6/12/22 11:43 AM, Bjoern A. Zeeb wrote:
> The branch main has been updated by bz:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=0f7b9777f8f39fbc230b3e1de2f844d9f839adea
> 
> commit 0f7b9777f8f39fbc230b3e1de2f844d9f839adea
> Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
> AuthorDate: 2022-06-12 18:35:58 +0000
> Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
> CommitDate: 2022-06-12 18:35:58 +0000
> 
>      rtw88: split driver up into a core and pci part
>      
>      Split the driver up into two modules (if_rtw88_pci.ko and rtw88_core.ko).
>      This is in preparation for the hopefully eventually upcoming USB support
>      using the same driver core.
>      
>      Note: this changes the module name to load to if_rtw88_pci.ko instead of
>      if_rtw88.ko.  If using devmatch(8) everything should stay the same as
>      the driver name (used for net.wlan.devices) stays rtw88.  If using
>      kld_list in rc.conf or loader.conf you will need to adjust the name.
>      Update man page for this.
>      
>      MFC after:      3 days

This sort of split in a .ko is kind of rare for drivers in the tree that support
multiple bus attachments.  Usually we just lump all the attachments into the same
.ko.  It's true that with the death of ISA, etc. we no longer have as many drivers
with multiple bus attachments, but the norm has been to include them all in a
single .ko.  Is there a reason you can't follow the normal practice here?

-- 
John Baldwin