From nobody Thu Jul 21 16:43:14 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lpdg54dsnz4X2MY; Thu, 21 Jul 2022 16:43:29 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lpdg5243Fz4QXH; Thu, 21 Jul 2022 16:43:29 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 26LGhE5r078164; Thu, 21 Jul 2022 09:43:14 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 26LGhEsF078163; Thu, 21 Jul 2022 09:43:14 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <202207211643.26LGhEsF078163@gndrsh.dnsmgr.net> Subject: Re: git: 1dfcff294e44 - main - release: increase IMAGE_SIZE for arm, arm64, riscv [odd alignment for SBC images] In-Reply-To: To: Warner Losh Date: Thu, 21 Jul 2022 09:43:14 -0700 (PDT) CC: Kyle Evans , Mark Millard , Glen Barber , Ed Maste , "Rodney W. Grimes" , dev-commits-src-main@FreeBSD.org, "Dr. Rolf Jansen" , freebsd-arm X-Mailer: ELM [version 2.4ME+ PL121h (25)] List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Rspamd-Queue-Id: 4Lpdg5243Fz4QXH X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > On Thu, Jul 21, 2022 at 8:55 AM Kyle Evans wrote: > > > On Wed, Jul 20, 2022 at 10:08 AM Mark Millard wrote: > > > > > > On 2022-Jul-19, at 15:45, Warner Losh wrote: > > > > > > > On Tue, Jul 19, 2022, 2:42 PM Glen Barber wrote: > > > >>> . . . > > > >> > > > >> My concern with this is kern.geom.part.mbr.enforce_chs is always '1' > > on > > > >> the builders, which effectively means all arm builds will fail every > > > >> time. I think we need to get to the actual root of the problem here, > > > >> versus applying band-aids to a shark bite. > > > > > > > > I think this is the actual problem. While such pedantry can be useful > > for ancient picky BIOSes, these days only the LBA fields of the MBR are > > used. And the fake BIOS geometry is crazy weird. We can likely tweak it to > > be more friendly. > > > > > > > > Why is it == 1 on the builder? If people want things aligned gpart has > > an option for years iirc to do that. And we want that off for the builds. > > > > > > Would it seem appropriate to use a week (this week?) to do all > > > the snapshot builds with the builders all set to have > > > kern.geom.part.mbr.enforce_chs=0 and see what breaks, if anything? > > > (Sort of a snapshot exp run.) > > > > > > > https://svnweb.freebsd.org/base?view=revision&revision=332731 says: > > > > Note: In addition to this merge, kern.geom.part.mbr.enforce_chs has > > been enabled on the build machine to mitigate against the issue in > > the PR referenced. > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226536 > > ("glabel/partition mixup on sdcard images") > > > > Having read through all that, I think it's safe to disable it again. We > changed the build process > to avoid the original bug, so no longer need the rounding to prevent the > situation from happening. > There are no old branches or legacy reasons to keep it enabled unless > there's another side effect > of it that I'm not seeing... I have come to this same conclusion after reading as well. > Warner -- Rod Grimes rgrimes@freebsd.org