From nobody Mon Jul 18 10:07:24 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lmd1d1Fg9z4Ww4F; Mon, 18 Jul 2022 10:07:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lmd1b6gVNz3H9G; Mon, 18 Jul 2022 10:07:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 26IA7Ogg096616 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 18 Jul 2022 13:07:27 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 26IA7OFA096615; Mon, 18 Jul 2022 13:07:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 18 Jul 2022 13:07:24 +0300 From: Konstantin Belousov To: Dmitry Chagin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: fc90f3a28145 - main - ktrace: Increase precision of timestamps. Message-ID: References: <202207160950.26G9o2AZ034355@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4Lmd1b6gVNz3H9G X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.30 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.982]; NEURAL_HAM_MEDIUM(-0.32)[-0.318]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_XAW(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sun, Jul 17, 2022 at 09:27:09PM +0300, Dmitry Chagin wrote: > On Sat, Jul 16, 2022 at 04:52:28PM +0300, Konstantin Belousov wrote: > > On Sat, Jul 16, 2022 at 09:50:02AM +0000, Dmitry Chagin wrote: > > > The branch main has been updated by dchagin: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=fc90f3a28145872afb7106d391bc922572eb2b71 > > > > > > commit fc90f3a28145872afb7106d391bc922572eb2b71 > > > Author: Dmitry Chagin > > > AuthorDate: 2022-07-16 09:46:12 +0000 > > > Commit: Dmitry Chagin > > > CommitDate: 2022-07-16 09:46:12 +0000 > > > > > > ktrace: Increase precision of timestamps. > > > > > > Replace struct timeval in header with struct timespec. > > > To differentiate header formats, add a new KTR_VERSIONED flag > > > set in the header type field similar to the existing KTRDROP flag. > > > > > > To make it easier to extend ktrace headers in the future, > > > extend the existing header with a version field (version 0 is > > > reserved for older records without KTR_VERSIONED) as well as > > > new fields holding the thread ID and CPU ID. > > It would be nice to have a way to force kernel to write v0 format. > > > > For instance, one of my usual work flow case is to generate ktrace.out > > on HEAD and kdump it on stable/13. > I can merge it into the stable/13 tomorrow as it is on my stable/13 prod > for a long time. And inot the stable/12 +-two week. will that work for > you? I think that this change is not acceptable for stable/12, due to ABI stability guarantees. I am not sure that it is acceptable for stable/13 as well, but there we could have a discussion about long-term viability of the branch. Can you make at least the kdump changes merged (and some modified header files merge as well), so both formats can be parsed by kdump(1)?