From nobody Sat Jul 16 19:13:54 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LldDy30j8z4T3mM; Sat, 16 Jul 2022 19:13:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LldDy2JK3z42FS; Sat, 16 Jul 2022 19:13:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657998834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T4xzqkubA8uDmV09hbjtVe0I0qk8BlRr+f30EQoClEg=; b=VBCmEa4FlUR7VFb7BY4vRB8y+dIXMOddFhKPHrMpgbTRrDzh/LEn9RVX/DYNwlK9sH0OxE Lj9mRcvzutC9UwZ1KZ6LAKejbaOupUxLY+y+hBPC6cq4jSGADXux5EI+fxOpGrXL/jDhuw CIlpKvYRA3kOyNZViYhTM+uWZdiAoeu340m63+tqdiE/k4EwgwWeK76jj9MRIgdsR8SHQ3 5BAWpp4FWBMBPo1KM2rqc80k2A0oH3JzIw4wdDAwykLAVDfVgNj9oXKUzpc2Cp9BtSpbrF yAfYGQcUBFCrEdvyN13MXn2mp2oApC143PQDp/fXUdFjSniCRvJ1Trwlp8eWvA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LldDy1LS0zXr5; Sat, 16 Jul 2022 19:13:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 26GJDsHf004032; Sat, 16 Jul 2022 19:13:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 26GJDsQe004031; Sat, 16 Jul 2022 19:13:54 GMT (envelope-from git) Date: Sat, 16 Jul 2022 19:13:54 GMT Message-Id: <202207161913.26GJDsQe004031@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: cab040039d6f - main - Remove unused but set variable in cxgb_sge List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cab040039d6fe1b2a6de8f2ba2cc882c313d3c75 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657998834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=T4xzqkubA8uDmV09hbjtVe0I0qk8BlRr+f30EQoClEg=; b=Rd2KJDdOAu8ffobHWvGRGCbGmO9yU7fUhDLcX/hKMfNkXfElgAyRHUYVjnvKf2GyHxDxVW fhfnQTetuHs8u7YT7HCys0sDPn1mbQEaYmaAasrvRtB45vDdsHrr7j+tDZoViZ/pGd07A+ EhiC2MuHGAaEyjbyvrvjQ0Kg9MJAen/jrAKh8NsEmwlFYym/u+zZp/l+KfDJ6JIitrhgH+ ihAKoiDUkFKsm3V76ro0CVqdwUcVjkYr7z3Lwd1Ll1Dkn1uUtbwz4XfQHF6H9RsEZlc/A2 QbihSWIqSxy14zuCADvU8uTHNWCnFYmg8AgTe/cMnd0b8NTwV04nc3aOH71ccA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657998834; a=rsa-sha256; cv=none; b=hlFL1iPvS3WTgDIwXwvnMCFoEJMn1jgLae2/q+s3Avu4jjnydR7jlSnqZ7jykYW2G4i1UG 8WNFP8lYoyAmEEav/EA8yagq+L5hnsJMTmQbNSAsOftNu69vDL7NZXKJRMk0mqWonxD2Ke obzG5J+MeGwdg3cLvIFp2+xpopSArjoW2jDU7BPE5W1HtzCwQi/f+JpEY2J6EK75O/Zspb GYTN0bg3EL34ouGkqHMRB+4o3bzZ6zUzck8fcGp04qXG6DHCYDkBUXEnpElPODZjd1hH2F nesHWqZqD5NsFO9Pq+ckKpU8/vxgBNVJ7bkZZSXvJ2FMGGPOQGMTwAZS9pX9kw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=cab040039d6fe1b2a6de8f2ba2cc882c313d3c75 commit cab040039d6fe1b2a6de8f2ba2cc882c313d3c75 Author: Dimitry Andric AuthorDate: 2022-07-16 18:16:36 +0000 Commit: Dimitry Andric CommitDate: 2022-07-16 19:13:37 +0000 Remove unused but set variable in cxgb_sge Clang 15 warns: sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable] struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; ^ It appears 'txsd' is a leftover from a previous refactoring (see 3f345a5d09b6), but is no longer used for anything, and can be removed without any functional change. MFC after: 3 days Reviewed by: np Differential Revision: https://reviews.freebsd.org/D35833 --- sys/dev/cxgb/cxgb_sge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/cxgb/cxgb_sge.c b/sys/dev/cxgb/cxgb_sge.c index dbc0ddea6b7c..f79149e8e7e6 100644 --- a/sys/dev/cxgb/cxgb_sge.c +++ b/sys/dev/cxgb/cxgb_sge.c @@ -1287,7 +1287,6 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs { struct work_request_hdr *wrp = (struct work_request_hdr *)txd; - struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx]; if (__predict_true(ndesc == 1)) { set_wr_hdr(wrp, htonl(F_WR_SOP | F_WR_EOP | V_WR_DATATYPE(1) | @@ -1318,12 +1317,10 @@ write_wr_hdr_sgl(unsigned int ndesc, struct tx_desc *txd, struct txq_state *txqs fp += avail; txd++; - txsd++; if (++txqs->pidx == txq->size) { txqs->pidx = 0; txqs->gen ^= 1; txd = txq->desc; - txsd = txq->sdesc; } /*