From nobody Thu Jul 14 18:33:50 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LkNRj0LgVz3vQkN; Thu, 14 Jul 2022 18:33:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LkNRh6yqnz3Fs4; Thu, 14 Jul 2022 18:33:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657823633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LeQm5RbAEm3q/hnb/WVAloFYvW6y27TF+RodTLgSogI=; b=RYDwuYmxw69RkM5gtGmdP+Xl9ggvCQEpvOCl06DMUR/ptCgOMLnja+ajzRIaVm8lCcUOG1 qPay277ZJXMPDe3Lzc1hZcSBm/wTmEwgerwYE8PvW1fZwfzUoiMD5NcQOcJpuvinOs6odj D3sIdofPwY8XTmCtsOVGXanSAH6andL8ar8n5JzJ4FTIpd7xuLQCkENrB/wXbe+eOOB8dt 1AdFVz1cd/GRxN7oQqBMzeRVzsefeeyu7Il6Mvcpxp4g81uisAgHkniUNaWVQb2XdU/1ua Gx2rb7/ESh0sZeukf9g8CYVseGie3lpE4ZujMOoTwi/Tq8E+WB9O8Q1a9V2JJQ== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4LkNRh2m8GzhMZ; Thu, 14 Jul 2022 18:33:52 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <488c11ab-aec3-3e7c-c987-2db779c828e9@FreeBSD.org> Date: Thu, 14 Jul 2022 11:33:50 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Mark Johnston , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202205250018.24P0IHaY006037@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: c728c56c870a - main - kqueue tests: Add file and line info to some test failure output In-Reply-To: <202205250018.24P0IHaY006037@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1657823633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LeQm5RbAEm3q/hnb/WVAloFYvW6y27TF+RodTLgSogI=; b=cXrXeu5rqZYfek1m8NGjCT/c/4gxCFP+OWaulkswMNp3JUO6DAd6uAlZTVqG3Uyj+40HkL E9rVvWx9ooa9X2Jou1s1HymoiFEaUK9oDznwYJWHbeg0GPa+8S2jgDBa/3uhMk0moWUJSK yfA3sY1fd9Qe0RZQpBqpuOy92ycdV6hqse9coCpi3maur7xVPmcjMa56fgNa9qNN3IGtw4 MoEk/uvgn2DbVUExgoCIT7zBvN8Ppc32dFRWj0SXkfbQOnx12nr7idOOudZEG2SsTwZThg HyPKu2pQ2QpJED9UhXKV/hiGEMieTUaoyBpPsNq+QhCBfToljztvyk2XnA0GYw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1657823633; a=rsa-sha256; cv=none; b=IRvFMqqEB9SZWO4USyvBYT+y3CcZ3onUbponm3xd6y74fM63kZ3nSJRkxz0L+6l64blUpZ oh1YxAnhU/4P8vbapKYpOg66xGtOCIPNJ378AJhQ7XekjS4avESWebH3UrGKB633SzqMlY AX00XsANUOvqSdiyuuHE0L1/71WOUTGZCMPDm1C5PEqSSTyKMR/4mTw55OACxGzYdPB6SD II/ab8GZR2DoySikpK8KXnBOPabaOOEoqINFROEW3XwY1M1sF0EPevDzoXcZe26E4NLr04 Nzq+xQEgJC47teQghHMtJ5/19ylqsfIZ+eUhN/ITXu/E8IrUkiFzZ6/2W7nUCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 5/24/22 5:18 PM, Mark Johnston wrote: > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c728c56c870abe230e45cee5c477f0d890ebacef > > commit c728c56c870abe230e45cee5c477f0d890ebacef > Author: Mark Johnston > AuthorDate: 2022-05-25 00:14:20 +0000 > Commit: Mark Johnston > CommitDate: 2022-05-25 00:14:20 +0000 > > kqueue tests: Add file and line info to some test failure output > > This brings us slightly closer to upstream and is useful when debugging > test failures. > > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation For some reason this has caused build errors with NO_CLEAN builds on pretty much every host I've tried to upgrade such as: ld.lld: error: undefined symbol: test_no_kevents >>> referenced by read.c:169 (/usr/home/john/work/cheri/git/cheribsd/tests/sys/kqueue/libkqueue/read.c:169) >>> read.o:(test_evfilt_read) >>> referenced by read.c:75 (/usr/home/john/work/cheri/git/cheribsd/tests/sys/kqueue/libkqueue/read.c:75) >>> read.o:(test_evfilt_read) >>> referenced by read.c:137 (/usr/home/john/work/cheri/git/cheribsd/tests/sys/kqueue/libkqueue/read.c:137) >>> read.o:(test_evfilt_read) >>> referenced 31 more times >>> did you mean: _test_no_kevents >>> defined in: main.o ld.lld: error: undefined symbol: kevent_cmp >>> referenced by read.c:72 (/usr/home/john/work/cheri/git/cheribsd/tests/sys/kqueue/libkqueue/read.c:72) >>> read.o:(test_evfilt_read) >>> referenced by read.c:145 (/usr/home/john/work/cheri/git/cheribsd/tests/sys/kqueue/libkqueue/read.c:145) >>> read.o:(test_evfilt_read) >>> referenced by read.c:193 (/usr/home/john/work/cheri/git/cheribsd/tests/sys/kqueue/libkqueue/read.c:193) >>> read.o:(test_evfilt_read) >>> referenced 14 more times >>> did you mean: _kevent_cmp >>> defined in: main.o It seems like read.o at least doesn't get rebuilt even though common.h changed. I can see common.h listed in .depend.kqtest.read.o, but make doesn't think it needs to be rebuilt based on the timestamps in the object directory: -rw-r--r-- 1 john src 131 Jun 27 10:27 .depend.kqtest -rw-r--r-- 1 john src 6201 Jun 27 16:28 .depend.kqtest.main.o -rw-r--r-- 1 john src 6201 Jun 27 16:28 .depend.kqtest.proc.o -rw-r--r-- 1 john src 6201 Jun 27 16:28 .depend.kqtest.read.o -rw-r--r-- 1 john src 6205 Jun 27 16:28 .depend.kqtest.signal.o -rw-r--r-- 1 john src 6203 Jun 27 16:28 .depend.kqtest.timer.o -rw-r--r-- 1 john src 6201 Jun 27 16:28 .depend.kqtest.user.o -rw-r--r-- 1 john src 6203 Jun 27 16:28 .depend.kqtest.vnode.o -rw-r--r-- 1 john src 136 Jul 14 10:40 .depend.kqueue_test -rw-r--r-- 1 john src 6201 Jul 14 10:40 .depend.kqueue_test.main.o -rw-r--r-- 1 john src 6203 Jul 14 10:40 .depend.kqueue_test.timer.o -rw-r--r-- 1 john src 117 Jun 27 10:27 Kyuafile -rwxr-xr-x 1 john src 41256 Jul 6 10:42 kqtest -rwxr-xr-x 1 john src 62248 Jul 6 10:42 kqtest.debug -rwxr-xr-x 1 john src 63128 Jul 6 10:42 kqtest.full -rwxr-xr-x 1 john src 36488 Jul 6 10:42 kqtest.stripped -rwxr-xr-x 1 john src 386 Jun 27 10:27 kqueue_test -rw-r--r-- 1 john src 28560 Jul 14 10:40 main.o -rw-r--r-- 1 john src 17920 Jun 27 16:28 proc.o -rw-r--r-- 1 john src 17872 Jun 27 16:28 read.o -rw-r--r-- 1 john src 12568 Jun 27 16:28 signal.o -rw-r--r-- 1 john src 29888 Jul 14 10:40 timer.o -rw-r--r-- 1 john src 10784 Jun 27 16:28 user.o -rw-r--r-- 1 john src 18984 Jun 27 16:28 vnode.o Oh, I think I see the problem. kqueue_test went from being a shell script to being an executable in a later commit. I guess that is a case that needs handling in depend-cleanup.sh. -- John Baldwin