Re: git: 09cdf4878c62 - main - dwc3: add more quirks and checks

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Mon, 04 Jul 2022 23:38:03 UTC
On Sun, 3 Jul 2022, Bjoern A. Zeeb wrote:

> The branch main has been updated by bz:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=09cdf4878c621be4cd229fa88cdccdcdc8c101f7
>
> commit 09cdf4878c621be4cd229fa88cdccdcdc8c101f7
> Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
> AuthorDate: 2022-07-02 20:56:07 +0000
> Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
> CommitDate: 2022-07-03 22:17:35 +0000
>
>    dwc3: add more quirks and checks
>
>    Rather than just printing the Global SNPS ID Register store it as well
>    so we can do a version check later.
>    In addition, for debugging purposes, read the Global Hardware Parameters
>    Registers and print them.
>
>    Based on the snpsid disable an XHCI feature using a quirk prepared
>    in 447c418da03454a2a00bc115a69c62055a6d5272.
>    Add the "snps,dis_u3_susphy_quirk" quirk and handle Suspend USB3.0 SS PHY
>    after power-on-reset/during core initialization (suggested to be cleared)
>    based on the DWC3_GHWPARAMS0 register.
>
>    MFC after:      2 weeks
>    Obtained from:  an old debugging patch
>    Reviewed by:    mw (earlier version), mmel
>    Differential Revision: https://reviews.freebsd.org/D35699
> ---
> sys/dev/usb/controller/dwc3.c | 54 +++++++++++++++++++++++++++++++++++++++----
> sys/dev/usb/controller/dwc3.h |  3 +++
> 2 files changed, 53 insertions(+), 4 deletions(-)

One of the changes here makes dwc3 fail now;  you'll see an error about
"Controller does not support 4K page size" from xhci.c.

I am checking which part it was.. and where it slipped in.  I guess
the old debugging patch got rusty ...  though I had booted the
original one for months and still do on another not-yet-updated
machine just fine.

/bz

-- 
Bjoern A. Zeeb                                                     r15:7