From nobody Mon Jul 04 06:35:16 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AF2458BEADE; Mon, 4 Jul 2022 06:35:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lbwz84WHbz3sc6; Mon, 4 Jul 2022 06:35:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656916516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ke1cxIo0Lty1PoEoJpJSKKhqejectBtEpHcXGENJUYU=; b=M4tKiOo1SUSH+zZ6uqa8ADTPLHLcBQcnr08JJz2zH2MobFYgg4nL8rgX3c5AO4CHlzbEBT UQsklsKuA7CM4BJwnA4TdmpM70kYl0m8FLCrJ+N09qhJZCf+eB0+NfoxnJLr5FX3tfmIq8 T9IkN1M7CmP5/dc3I2gCkrdqLDwLFn3LACL9oRSoFJLGgyHIZr6z9l4swXGUUN/QQ9Hrfu eBjRwVMdTXGOztA41ubZhPMZ5mkO3Fu1uGX3WubIzs7hcwEDL7s6GOqoMhDpqAIzFqAHbz O+2cszFRMwP4o/wXCoY7W6x9ME/rUw1aZHO/NbayX6EQffk4LAkcNFAQ5W+wqA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7AD923F58; Mon, 4 Jul 2022 06:35:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2646ZGwE026814; Mon, 4 Jul 2022 06:35:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2646ZGdj026813; Mon, 4 Jul 2022 06:35:16 GMT (envelope-from git) Date: Mon, 4 Jul 2022 06:35:16 GMT Message-Id: <202207040635.2646ZGdj026813@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Philip Paeps Subject: git: 177f8b3294ef - main - ipmi: do not omit lun in BMC addresses List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: philip X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 177f8b3294ef5717060c287fe1206c52ba3ecc53 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656916516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ke1cxIo0Lty1PoEoJpJSKKhqejectBtEpHcXGENJUYU=; b=HgfU4/84GQOr0i++zRyFObGYBUQekJaQLgZ3kq5qZBYA4LB8/F/KRzhySKWYvezDSJZu5O XrBA062X/TEuSWt/owDUFnTfor4sisLGN5Q91c1fFN4pN4lcB166TLGCkGIDJpF59ewHfC ycIA8VKxm2O3o1seGpr9eZCVWq1upCXmDyCnUwiioQiRR5t7vR5bw4gIKChc7EhVUv1XD5 BkccQ5VEGuzvGKZXAsuxbYN1fuzSz/mN8/zbovulDnRL7uEUB41N0L3pRYJMTWQ6Ax6o3b ivrfmyen9XJYM68JMXmtXO+VxBuL7czsQ3I17N5/G0pb4DfB0FS9PkZyMw0hMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656916516; a=rsa-sha256; cv=none; b=DUb69dPuKqdLOsBmSedvRmV87LP/ZAHKSGCh0F9pnm4+NIJhgeqIQy52jVsuOcFIarh5h7 b7QYaErZ8/lile92eQJ0cCtUrtj3CGan/GxQ9adzjmSUrKBRvCcyo7MMpK4s8ZCLBY0DCJ NRkKmPjZi0vDftkXjuYhcMRDv/FTDb2gxMNO7pR1UIqNtFv7hMSjXHNSXFEr+S8bI8CEk0 1aIikYsYHFZmirdY6331+c042lI4F797zhAWb06eZwBdFutUVM9aQl2wwMnyKDhvvh++b9 /MpjUqBxTsdKYjjivwV/TS7yWJGxV3PoVYpvRcVt3hM/B/38euOgGNfSUveGCg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by philip: URL: https://cgit.FreeBSD.org/src/commit/?id=177f8b3294ef5717060c287fe1206c52ba3ecc53 commit 177f8b3294ef5717060c287fe1206c52ba3ecc53 Author: Yuri AuthorDate: 2022-07-04 06:29:52 +0000 Commit: Philip Paeps CommitDate: 2022-07-04 06:30:39 +0000 ipmi: do not omit lun in BMC addresses Some systems put sensors on non-0 lun, so we should not omit it. This was the only difference with the Linux driver, where DIMM sensors could be queried, but not on FreeBSD. See this report[1] on the FreeBSD forums: https://forums.freebsd.org/threads/freebsd-cannot-get-dimm-temperature-sensor-value.85166/ Reviewed by: philip Tested by: Andrey Lanin[1] MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D35612 --- sys/dev/ipmi/ipmi.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sys/dev/ipmi/ipmi.c b/sys/dev/ipmi/ipmi.c index 775734d3e1aa..7afafa492b6f 100644 --- a/sys/dev/ipmi/ipmi.c +++ b/sys/dev/ipmi/ipmi.c @@ -309,9 +309,12 @@ ipmi_ioctl(struct cdev *cdev, u_long cmd, caddr_t data, return (error); if (addr.addr_type == IPMI_SYSTEM_INTERFACE_ADDR_TYPE) { + struct ipmi_system_interface_addr *saddr = + (struct ipmi_system_interface_addr *)&addr; + kreq = ipmi_alloc_request(dev, req->msgid, - IPMI_ADDR(req->msg.netfn, 0), req->msg.cmd, - req->msg.data_len, IPMI_MAX_RX); + IPMI_ADDR(req->msg.netfn, saddr->lun & 0x3), + req->msg.cmd, req->msg.data_len, IPMI_MAX_RX); error = copyin(req->msg.data, kreq->ir_request, req->msg.data_len); if (error) {