From nobody Mon Jan 24 18:53:57 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8DC0119697A7; Mon, 24 Jan 2022 18:53:59 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JjJzq3Vd6z52x4; Mon, 24 Jan 2022 18:53:59 +0000 (UTC) (envelope-from gbe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643050439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XxSTEDBLSVmPsMt27AQzaM3Iq3Ae6+og6FM2nXjNEkk=; b=B9zZvfhf563HEYgnJrJsJx9m++ECYPGT1Uqb4LF1/x6sUt0xrE3KFKBtUE+BXpwU0iz8uk Ila+P6NuQQQ3W9CIzF5iVGNfU8e1hBqRjDB+9KJFGbTAWdM0/YXi6NY0NIkuFxZfZXMukM vS1iizFK5s6mbeH/UJulGBX9TJjP15FosEJg3kzwUZ3vlkyo4pfhU1tb3Z1NSnb3GqfM9j 4a+9uNSy1aeQ40NTexwhaVEGJ9i+RDVdNkKpx1gdE/Cpml+d1CAQH3Xm2tO0NyoUf/qF/u AqQwgP+U46kf8pzcO4D8FP9V1cz6Vl/7GGe8e89oG6Q+BLwdCmpbvXP0kfXCDQ== Received: from localhost (p200300cb87275cf4d93264d32c782a9e.dip0.t-ipconnect.de [IPv6:2003:cb:8727:5cf4:d932:64d3:2c78:2a9e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id C011D14CA; Mon, 24 Jan 2022 18:53:58 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Mon, 24 Jan 2022 19:53:57 +0100 From: Gordon Bergling To: Michael Tuexen Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 1b90dfa5d2b0 - main - tcp_bbr(4): Fix a few typos in sysctl descriptions Message-ID: References: <202201021704.202H48LB097317@gitrepo.freebsd.org> <85AF2A88-552E-42F8-B3D2-13D75FE41221@macmic.franken.de> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85AF2A88-552E-42F8-B3D2-13D75FE41221@macmic.franken.de> X-Url: X-Operating-System: FreeBSD 12.3-STABLE amd64 X-Host-Uptime: 7:50PM up 2 days, 1:15, 2 users, load averages: 0.35, 0.27, 0.28 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643050439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XxSTEDBLSVmPsMt27AQzaM3Iq3Ae6+og6FM2nXjNEkk=; b=D4T6rQW9x7JOx3gOixA55EZVy0PGshEZL+h2xG3G6YAiD0MBVjMeefehmii5xWgS9TSf0G q0whV4bjn03HkglYSnA4qpIUscR6QVY3qpJB6pyoZ8sZcRB0w1WpQk08fAkaYyH4j0mppM J8/oqeEKYgObgZTwueee9Zf8PYL9z9AVdBIZzJnK/3dl5grvfdcYjiDyYfq7nnVoMweFrE eBRZrSKnFTluXS9pH6SRsU478sMacG11bYwq18IQUNqXD9FqPGjakrZwu3Ye3Xb7zAbwhU ZdGoX5g+mNK+g57Sw1/hBTbcUpzhbytLAQLgSf1Vb/Yan/KhIjpowIYG14fKIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643050439; a=rsa-sha256; cv=none; b=mTNsK4dJiHK6POoIhe3bm0wj1mGyTC+a0gCC7ynG5WI1pG6deY/KA+lFBB4M8ox5IIfDe0 FYp8BgLl79Ss8G39jbwy9O+QJnO35/zHoeqEaLZ59OhMM1EBO3dr8HyQsXzSdAtiCmJm4t Mdz5XCQ4gCkzX40TYt/ZHOA2qR16Qr2PwcshCW0ycNltu0+5TJdaGlR7AYAl5m3zq0uBi3 rzR+xfJUUbWniih/DAAOWxXGr8eyWg9bGNm7Jr0dno6uS5QjdoDOWfKuM8mTIi3Wn7DS17 JVi274GLLifBbBxpc6eQ4fzTnnfHEI4a/rudkFhEZpy9/HQT5T/i+OD+Djd7qg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Jan 05, 2022 at 08:14:51AM +0100, Michael Tuexen wrote: > > On 2. Jan 2022, at 18:04, Gordon Bergling wrote: > > > > The branch main has been updated by gbe (doc committer): > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1b90dfa5d2b01549b51d9829206acac39a432bbb > > > > commit 1b90dfa5d2b01549b51d9829206acac39a432bbb > > Author: Gordon Bergling > > AuthorDate: 2022-01-02 17:03:10 +0000 > > Commit: Gordon Bergling > > CommitDate: 2022-01-02 17:03:10 +0000 > > > > tcp_bbr(4): Fix a few typos in sysctl descriptions > > > > - s/measurment/measurement/ > > > > MFC after: 3 days > > --- > > sys/netinet/tcp_stacks/bbr.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c > > index 4bb0015e3cf5..56e6ebaef2e7 100644 > > --- a/sys/netinet/tcp_stacks/bbr.c > > +++ b/sys/netinet/tcp_stacks/bbr.c > > @@ -191,7 +191,7 @@ static int32_t bbr_hptsi_max_div = 2; /* time, 0 means turned off. We need this > > static int32_t bbr_policer_call_from_rack_to = 0; > > static int32_t bbr_policer_detection_enabled = 1; > > static int32_t bbr_min_measurements_req = 1; /* We need at least 2 > > - * measurments before we are > > + * measurement before we are > Shouldn't it be measurements instead of measurement? > > Best regards > Michael Sorry for the late reply. You right about the grammar typo. I correct this tomorrow, was AFK for a few days. --Gordon > > * "good" note that 2 == 1. > > * This is because we use a > > > * comparison. This means if > > @@ -1402,7 +1402,7 @@ bbr_init_sysctls(void) > > SYSCTL_CHILDREN(bbr_measure), > > OID_AUTO, "min_measure_good_bw", CTLFLAG_RW, > > &bbr_min_measurements_req, 1, > > - "What is the minimum measurment count we need before we switch to our b/w estimate"); > > + "What is the minimum measurement count we need before we switch to our b/w estimate"); > > SYSCTL_ADD_S32(&bbr_sysctl_ctx, > > SYSCTL_CHILDREN(bbr_measure), > > OID_AUTO, "min_measure_before_pace", CTLFLAG_RW, > > @@ -1558,7 +1558,7 @@ bbr_init_sysctls(void) > > SYSCTL_CHILDREN(bbr_cwnd), > > OID_AUTO, "tar_rtt", CTLFLAG_RW, > > &bbr_cwndtarget_rtt_touse, 0, > > - "Target cwnd rtt measurment to use (0=rtt_prop, 1=rtt_rack, 2=pkt_rtt, 3=srtt)?"); > > + "Target cwnd rtt measurement to use (0=rtt_prop, 1=rtt_rack, 2=pkt_rtt, 3=srtt)?"); > > SYSCTL_ADD_S32(&bbr_sysctl_ctx, > > SYSCTL_CHILDREN(bbr_cwnd), > > OID_AUTO, "may_shrink", CTLFLAG_RW, > > @@ -2971,7 +2971,7 @@ use_initial_window: > > rtt = (uint64_t)get_filter_value_small(&bbr->r_ctl.rc_rttprop); > > if (rtt && (rtt < 0xffffffff)) { > > /* > > - * We have an RTT measurment. Use that in > > + * We have an RTT measurement. Use that in > > * combination with our initial window to calculate > > * a b/w. > > */ > --