Re: git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces

From: Ronald Klop <ronald-lists_at_klop.ws>
Date: Fri, 14 Jan 2022 22:41:22 UTC 
Van: Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
Datum: 14 januari 2022 21:45
Aan: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Onderwerp: git: 9f0b56872c1f - main - carp(4): Make regex additionally match on VLAN interfaces

> 
> 
> The branch main has been updated by debdrup (doc committer):
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=9f0b56872c1fb790f67ee45a56ceeeed5d17ddea
> 
> commit 9f0b56872c1fb790f67ee45a56ceeeed5d17ddea
> Author:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
> AuthorDate: 2022-01-14 20:32:06 +0000
> Commit:     Daniel Ebdrup Jensen <debdrup@FreeBSD.org>
> CommitDate: 2022-01-14 20:44:13 +0000
> 
>     carp(4): Make regex additionally match on VLAN interfaces
>     
>     This tiny change to the example makes devd capable of reacting to carp
>     status change events on VLAN interfaces.
>     
>     Reported by:    Thomas Steen Rasmussen (tykling) <thomas at gibfest.dk>
> ---
>  share/man/man4/carp.4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/share/man/man4/carp.4 b/share/man/man4/carp.4
> index 8d54d56afa03..2785b97e76ac 100644
> --- a/share/man/man4/carp.4
> +++ b/share/man/man4/carp.4
> @@ -290,7 +290,7 @@ status change events can be set up by using the following devd.conf rule:
>  .Bd -literal -offset indent
>  notify 0 {
>     match "system"          "CARP";
> -   match "subsystem"       "[0-9]+@[0-9a-z]+";
> +   match "subsystem"       "[0-9]+@[0-9a-z.]+";
>     match "type"            "(MASTER|BACKUP)";
>     action "/root/carpcontrol.sh $subsystem $type";
>  };
> 
> 
> 
> 
> 


Hi,

I don’t think you need to escape a dot inside a character class.
But maybe this regex engine does need it. 



Nice change about the vlan though. 


Regards,
Ronald