git: 94f4afd7720b - main - rk805 / rk808: re-add system poweroff support

From: Andriy Gapon <avg_at_FreeBSD.org>
Date: Tue, 11 Jan 2022 14:25:22 UTC
The branch main has been updated by avg:

URL: https://cgit.FreeBSD.org/src/commit/?id=94f4afd7720b1b5c55bfb486aabb5fd98fc92678

commit 94f4afd7720b1b5c55bfb486aabb5fd98fc92678
Author:     Andriy Gapon <avg@FreeBSD.org>
AuthorDate: 2022-01-11 14:22:36 +0000
Commit:     Andriy Gapon <avg@FreeBSD.org>
CommitDate: 2022-01-11 14:22:36 +0000

    rk805 / rk808: re-add system poweroff support
    
    This was lost by accident in 98c60dc31f.
    
    Reviewed by:    manu
    MFC after:      2 weeks
    Differential Revision:  https://reviews.freebsd.org/D33844
---
 sys/dev/iicbus/pmic/rockchip/rk805.c    |  2 ++
 sys/dev/iicbus/pmic/rockchip/rk808.c    |  2 ++
 sys/dev/iicbus/pmic/rockchip/rk808reg.h |  4 ++++
 sys/dev/iicbus/pmic/rockchip/rk8xx.c    | 38 ++++++++++++++++++++++++++++++++-
 sys/dev/iicbus/pmic/rockchip/rk8xx.h    |  6 ++++++
 5 files changed, 51 insertions(+), 1 deletion(-)

diff --git a/sys/dev/iicbus/pmic/rockchip/rk805.c b/sys/dev/iicbus/pmic/rockchip/rk805.c
index e8752a3a7bef..b3182d4909a6 100644
--- a/sys/dev/iicbus/pmic/rockchip/rk805.c
+++ b/sys/dev/iicbus/pmic/rockchip/rk805.c
@@ -176,6 +176,8 @@ rk805_attach(device_t dev)
 	sc->rtc_regs.ctrl_ampm_mask = RK805_RTC_AMPM_MODE;
 	sc->rtc_regs.ctrl_gettime_mask = RK805_RTC_GET_TIME;
 	sc->rtc_regs.ctrl_readsel_mask = RK805_RTC_READSEL;
+	sc->dev_ctrl.dev_ctrl_reg = RK805_DEV_CTRL;
+	sc->dev_ctrl.pwr_off_mask = RK805_DEV_CTRL_OFF;
 
 	return (rk8xx_attach(sc));
 }
diff --git a/sys/dev/iicbus/pmic/rockchip/rk808.c b/sys/dev/iicbus/pmic/rockchip/rk808.c
index 34d1884db088..b9214fc74b61 100644
--- a/sys/dev/iicbus/pmic/rockchip/rk808.c
+++ b/sys/dev/iicbus/pmic/rockchip/rk808.c
@@ -251,6 +251,8 @@ rk808_attach(device_t dev)
 	sc->rtc_regs.ctrl_ampm_mask = RK808_RTC_AMPM_MODE;
 	sc->rtc_regs.ctrl_gettime_mask = RK808_RTC_GET_TIME;
 	sc->rtc_regs.ctrl_readsel_mask = RK808_RTC_READSEL;
+	sc->dev_ctrl.dev_ctrl_reg = RK808_DEV_CTRL;
+	sc->dev_ctrl.pwr_off_mask = RK808_DEV_CTRL_OFF;
 
 	return (rk8xx_attach(sc));
 }
diff --git a/sys/dev/iicbus/pmic/rockchip/rk808reg.h b/sys/dev/iicbus/pmic/rockchip/rk808reg.h
index 054cac45f1d6..444b1fded12e 100644
--- a/sys/dev/iicbus/pmic/rockchip/rk808reg.h
+++ b/sys/dev/iicbus/pmic/rockchip/rk808reg.h
@@ -107,6 +107,10 @@
 #define	RK808_LDO8_ON_VSEL	0x49
 #define	RK808_LDO8_SLEEP_VSEL	0x4A
 
+#define	RK808_DEV_CTRL		0x4B
+#define	 RK808_DEV_CTRL_OFF	(1 << 0)
+#define	 RK808_DEV_CTRL_SLP	(1 << 1)
+
 enum rk808_regulator {
 	RK808_BUCK1 = 0,
 	RK808_BUCK2,
diff --git a/sys/dev/iicbus/pmic/rockchip/rk8xx.c b/sys/dev/iicbus/pmic/rockchip/rk8xx.c
index 46f9ed24ca39..0e6839ff0152 100644
--- a/sys/dev/iicbus/pmic/rockchip/rk8xx.c
+++ b/sys/dev/iicbus/pmic/rockchip/rk8xx.c
@@ -31,8 +31,10 @@ __FBSDID("$FreeBSD$");
 #include <sys/param.h>
 #include <sys/bus.h>
 #include <sys/clock.h>
+#include <sys/eventhandler.h>
 #include <sys/kernel.h>
 #include <sys/module.h>
+#include <sys/reboot.h>
 #include <sys/mutex.h>
 #include <sys/rman.h>
 #include <machine/bus.h>
@@ -76,7 +78,6 @@ rk8xx_start(void *pdev)
 
 	dev = pdev;
 	sc = device_get_softc(dev);
-	sc->dev = dev;
 
 	/* No version register in RK808 */
 	if (bootverbose && sc->type == RK805) {
@@ -101,6 +102,30 @@ rk8xx_start(void *pdev)
 	config_intrhook_disestablish(&sc->intr_hook);
 }
 
+static void
+rk8xx_poweroff(void *arg, int howto)
+{
+	struct rk8xx_softc *sc = arg;
+	int error;
+	uint8_t val;
+
+	if ((howto & RB_POWEROFF) == 0)
+		return;
+
+	device_printf(sc->dev, "Powering off...\n");
+	error = rk8xx_read(sc->dev, sc->dev_ctrl.dev_ctrl_reg, &val, 1);
+	if (error == 0) {
+		val |= sc->dev_ctrl.pwr_off_mask;
+		error = rk8xx_write(sc->dev, sc->dev_ctrl.dev_ctrl_reg,
+		    &val, 1);
+
+		/* Wait a bit for the command to take effect. */
+		if (error == 0)
+			DELAY(100);
+	}
+	device_printf(sc->dev, "Power off failed\n");
+}
+
 int
 rk8xx_attach(struct rk8xx_softc *sc)
 {
@@ -117,6 +142,17 @@ rk8xx_attach(struct rk8xx_softc *sc)
 
 	rk8xx_attach_regulators(sc);
 
+	if (OF_hasprop(ofw_bus_get_node(sc->dev),
+	    "rockchip,system-power-controller")) {
+		/*
+		 * The priority is chosen to override PSCI and EFI shutdown
+		 * methods as those two just hang without powering off on Rock64
+		 * at least.
+		 */
+		EVENTHANDLER_REGISTER(shutdown_final, rk8xx_poweroff, sc,
+		    SHUTDOWN_PRI_LAST - 2);
+	}
+
 	return (0);
 }
 
diff --git a/sys/dev/iicbus/pmic/rockchip/rk8xx.h b/sys/dev/iicbus/pmic/rockchip/rk8xx.h
index 738209f5871e..739b57c5f0bb 100644
--- a/sys/dev/iicbus/pmic/rockchip/rk8xx.h
+++ b/sys/dev/iicbus/pmic/rockchip/rk8xx.h
@@ -85,6 +85,11 @@ struct rk8xx_rtc_reg {
 	uint8_t	ctrl_readsel_mask;
 };
 
+struct rk8xx_dev_ctrl {
+	uint8_t	dev_ctrl_reg;
+	uint8_t	pwr_off_mask;
+};
+
 struct rk8xx_softc {
 	device_t		dev;
 	struct mtx		mtx;
@@ -98,6 +103,7 @@ struct rk8xx_softc {
 	int			nregs;
 
 	struct rk8xx_rtc_reg	rtc_regs;
+	struct rk8xx_dev_ctrl	dev_ctrl;
 };
 
 int rk8xx_read(device_t dev, uint8_t reg, uint8_t *data, uint8_t size);