From nobody Mon Feb 28 10:11:49 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id F2E4819F7FBA; Mon, 28 Feb 2022 10:11:56 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6blJ0JN5z3By9; Mon, 28 Feb 2022 10:11:56 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ed1-f46.google.com with SMTP id x5so16779969edd.11; Mon, 28 Feb 2022 02:11:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=/yf9IYS1odl5b6yYsrBg2iWCmVAUlrbtId0aw8Urbaw=; b=LJqgnxU+dSsIUSIt+pP9+YHe+S2VtpiMfQYg96Rz0b9AI/4JXNt1chV0LqSvFxRQoN CAcOlBCzc2oVb1y/AE0ytFHy2CtmGDZi5agNUXBSCiB2c17dI0cjXKe+W5qlQJq+by9B fqPmx73+MnA8O4Ni++L0TbJQ9zd6fNnnXJPATBTTGwZwY3tqE6SBmYMVnEMTIlbf1lMF PTWWMoJuaD7nfqx0mQgCUPsu8bMjgLFm6K4hAkAtton5PgdkmL8J7O7/Sm2pbpSvklkd YEcj5gcplK46MtCaYVxfMrJ1tYSfi3EzZ5mBbWT/Bgc4ei0RZ9bnTTejvDGvrI59Df8f NoLA== X-Gm-Message-State: AOAM533E6HeRqAyCdM68JHfuDkfBF9VJD3fy3DX4wF4nwbazJqdHHphk jJNR8yEACmPm+rjexuNBwZOJvPSGn3c= X-Google-Smtp-Source: ABdhPJy5OgBxDdQGorX0f9Yyn0thguNMKJ1nFbHlk/tRF+s0X6Lh90UjtS7bOdIhsz5QbtiRxgL3NA== X-Received: by 2002:a05:6402:354a:b0:412:8976:82d2 with SMTP id f10-20020a056402354a00b00412897682d2mr19206195edd.213.1646043109134; Mon, 28 Feb 2022 02:11:49 -0800 (PST) Received: from ?IPV6:2a02:8109:9880:1d70:5e5f:67ff:fef4:ffd8? ([2a02:8109:9880:1d70:5e5f:67ff:fef4:ffd8]) by smtp.gmail.com with ESMTPSA id ck3-20020a0564021c0300b00413cd3eef2csm442607edb.2.2022.02.28.02.11.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Feb 2022 02:11:48 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 11:11:49 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: git: c068632981eb - main - Add ggated rc script Content-Language: en-US To: Alan Somers , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202202280416.21S4G8D0064972@gitrepo.freebsd.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> In-Reply-To: <202202280416.21S4G8D0064972@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4K6blJ0JN5z3By9 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-1.50 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-0.99)[-0.990]; NEURAL_SPAM_SHORT(0.49)[0.486]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.46:from]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.208.46:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-ThisMailContainsUnwantedMimeParts: N On 28/02/2022 05:16, Alan Somers wrote: > The branch main has been updated by asomers: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c068632981ebb7521859e3d2c0ec300a271f9b7e > > commit c068632981ebb7521859e3d2c0ec300a271f9b7e > Author: Alan Somers > AuthorDate: 2022-02-28 04:14:52 +0000 > Commit: Alan Somers > CommitDate: 2022-02-28 04:14:52 +0000 > > Add ggated rc script > > Reviewed by: asomers, peterj > Submitted by: Johannes Totz > Differential Revision: https://reviews.freebsd.org/D31709 > --- > libexec/rc/rc.conf | 3 +++ > libexec/rc/rc.d/Makefile | 1 + > libexec/rc/rc.d/ggated | 21 +++++++++++++++++++++ > 3 files changed, 25 insertions(+) > > diff --git a/libexec/rc/rc.conf b/libexec/rc/rc.conf > index 1812b099530a..23a397c3b4ad 100644 > --- a/libexec/rc/rc.conf > +++ b/libexec/rc/rc.conf > @@ -296,6 +296,9 @@ iscsictl_flags="-Aa" # Optional flags to iscsictl. > hastd_enable="NO" # Run the HAST daemon (YES/NO). > hastd_program="/sbin/hastd" # path to hastd, if you want a different one. > hastd_flags="" # Optional flags to hastd. > +ggated_enable="NO" # Run the ggate daemon (YES/NO). > +ggated_config="/etc/gg.exports" > +ggated_params="" # Extra parameters like which port to bind to. Shouldn't _params be _flags instead? > diff --git a/libexec/rc/rc.d/ggated b/libexec/rc/rc.d/ggated > new file mode 100644 > index 000000000000..dc31468920ef > --- /dev/null > +++ b/libexec/rc/rc.d/ggated > @@ -0,0 +1,21 @@ > +#!/bin/sh > + > +# PROVIDE: ggated > +# REQUIRE: NETWORKING > + > +. /etc/rc.subr > + > +name="ggated" > +desc="GEOM Gate network daemon" > +rcvar="ggated_enable" > +command="/sbin/${name}" > +pidfile="/var/run/${name}.pid" > + > +load_rc_config $name > +params="${ggated_params}" > +config="${ggated_config:-/etc/gg.exports}" Is it necessary to set the default here again if it is already set in /etc/defaults/rc.conf? Best, Mateusz