From nobody Mon Feb 28 00:37:23 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EA82619E0D1B; Mon, 28 Feb 2022 00:37:32 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6M0W5JTpz3CMQ; Mon, 28 Feb 2022 00:37:31 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtpclient.apple (174-20-86-156.mpls.qwest.net [174.20.86.156]) by smtp.vangyzen.net (Postfix) with ESMTPSA id 7D0C9564AF; Sun, 27 Feb 2022 18:37:24 -0600 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vangyzen.net; s=default; t=1646008644; bh=KVLWeEAGbiqY262+y7zWRMa6cA1LTbz8qBmFbd3spHo=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=c4K/9H9jkFCRRyI1I40PTIxG8wC8LccKsvZswXk+6Iy1YqnFZLk4y+MCI5vOQDcUb xPWtmDwHJ3DnF7KFBh51xzfKP5e84czHHtKlra9WAwpqyID7sC5Xk8f9jpaRStuGy0 6R2LXhC/5BXwco9KY+ACqMp1My9+WlGzg5hrhZ3t36DgHhIKMfU0Ou1rBtLz7xlSln wSwBV45Z9FkHCGQgXnZ2OICtF8RNcbRvgltiqWnvriytVPrYjIKwOL1clC61nLXjOl 7Pob0X19s/x9srRp/yFnNKuwiivMODTxjxzNlB1RRSZhUnrdwDmY5HhJQxEojwY/a3 wMhR3fhopJbCg== Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: git: 766c2466ff46 - main - mmap map_at_zero test: handle W^X From: Eric van Gyzen In-Reply-To: <5DF1CA02-6AF7-4588-A342-29F769CD5F23@freebsd.org> Date: Sun, 27 Feb 2022 18:37:23 -0600 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <7569EC4F-E047-44C2-9964-D261D820E7F7@vangyzen.net> References: <202202211546.21LFkKhX053274@gitrepo.freebsd.org> <5DF1CA02-6AF7-4588-A342-29F769CD5F23@freebsd.org> To: Jessica Clarke , arka_sharma@dell.com X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Rspamd-Queue-Id: 4K6M0W5JTpz3CMQ X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=vangyzen.net header.s=default header.b="c4K/9H9j"; dmarc=pass (policy=none) header.from=vangyzen.net; spf=pass (mx1.freebsd.org: domain of eric@vangyzen.net designates 199.48.133.146 as permitted sender) smtp.mailfrom=eric@vangyzen.net X-Spamd-Result: default: False [-3.50 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[vangyzen.net:s=default]; FREEFALL_USER(0.00)[eric]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:c]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[vangyzen.net:+]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_ALLOW(-0.50)[vangyzen.net,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:36236, ipnet:199.48.132.0/22, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[174.20.86.156:received] X-ThisMailContainsUnwantedMimeParts: N > If the test is just as legitimate without PROT_EXEC, what=E2=80=99s = the > justification for not just removing PROT_EXEC entirely rather than > making its behaviour depend on the sysctl, which could become = confusing > (and complicates the test)? IMO either the test should be skipped for > !allow_wx or it should always just make a RW mapping; this choice is > rather odd. The short answer is, we didn=E2=80=99t know whether PROT_EXEC was = essential, so this seemed like the safest change to preserve the intent = but also work correctly with W^X. It was also the easiest way to = increase test coverage of all these cases with the least code, since = some systems will run with W+X and others with W^X. Eric=