From nobody Sat Feb 26 18:16:49 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E703319E6BE0; Sat, 26 Feb 2022 18:16:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K5Zbj6Bl8z4SJB; Sat, 26 Feb 2022 18:16:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645899409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8+ZjEdDrIV946BUJn6E5jzhAIVqWy5aCH4E6d4qSTwU=; b=EEDVHhN0wHoY9/ySJWVB/QC7+X8LSdfBxWvLnqEQHfwhLKBdx8pTdexd9uEBJSoKg3xOv0 ZO7+kxJTD26uxkhFgA7fPG8miATP7fpIRMbBhwQGJpAuCED90jodZHq0KP/iZclWb5+Rv9 abwOTn/uHxyRluXjQex96/+negfygdyqvj1WGeoSp9uB7HWf54OX0QHw2T2ADjttVxpQH4 O2RdNESaxMvrE9nCPy9IhvVt/X3nYFsAbqZctW331fqc6hDeSqse5AX4Muhi9EutpkRwwl +R7F43Gdzqk4IVXR+itYK9aa1ifO4R/knCDaL4ei88fuSmBUZ6E+YsqE+MQjZA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B486A186CB; Sat, 26 Feb 2022 18:16:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21QIGnJm027057; Sat, 26 Feb 2022 18:16:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21QIGnqn027056; Sat, 26 Feb 2022 18:16:49 GMT (envelope-from git) Date: Sat, 26 Feb 2022 18:16:49 GMT Message-Id: <202202261816.21QIGnqn027056@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Scott Long Subject: git: b6ac753a881b - main - Fix "set but not used" in twe. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: scottl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b6ac753a881be1a72bfbdb0d7ce0b22347eda458 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645899409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8+ZjEdDrIV946BUJn6E5jzhAIVqWy5aCH4E6d4qSTwU=; b=ZFnoZ00sEWlsihLU+rfAkHXClu4eydqaVAVe+Z6v9kRLAwB3Pu0uVWHLUadzY4xgBlQmYI IaA6YrH31Wwi557WGIYa0UbqUd7tR4RbLrD5aq19jwBgSUdeX3RBbCyoX2QQnGy86Uk8O8 mkesTqf4W1Vuc9vPbfEedM65TJgrfMfSgrmUoxAbYZsGoEcKDCRRshNOkOCOxjlooB10gm t6OtRJV8eGktfnJkGu5fFeSh1B0O8aYN3z1NRPlb7tal2PbMk6kBpRaIDufzHNvxGLhWNP mlL8IBRCPJlVzN2BmVIGiNwvjrLUTutRxY6q+MJWpi+XRUEjcv6A+9rQQ+u6jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645899409; a=rsa-sha256; cv=none; b=pdHNyhgYlbYfpDxX5aY0guEeU6s+dySBNUGOH5+3s4u1s/uoqt3V9ZO+UVLeoaDAZ914Cc CwFdjtnBJKIOHLTN3I9kZtb8CKNUR+RzekL/44Nd7XmY9wo0eMFy4IQwayylRA76tedHy5 n3A56eVSJwnyN+wOLX9Ka8WNdYX/IpAZ9XsTwDDyW7ag336EXxX4hoWRhlCQKGT15zpj7u nZmUjG7SjC9VvagO8zXNzwwtt6Q+wF/hTruhSpoFV4KrwvUilM55J0ESvBvtRIy3oz6t33 5fzPtXStA06d1qiHI9HF29HiHzM1o0MLDjW7SJQbWldjeE2xv1V0W586tYAmOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by scottl: URL: https://cgit.FreeBSD.org/src/commit/?id=b6ac753a881be1a72bfbdb0d7ce0b22347eda458 commit b6ac753a881be1a72bfbdb0d7ce0b22347eda458 Author: Scott Long AuthorDate: 2022-02-26 18:16:31 +0000 Commit: Scott Long CommitDate: 2022-02-26 18:16:31 +0000 Fix "set but not used" in twe. --- sys/dev/twe/twe.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sys/dev/twe/twe.c b/sys/dev/twe/twe.c index 389c4c4ac4c4..c20393fa72b3 100644 --- a/sys/dev/twe/twe.c +++ b/sys/dev/twe/twe.c @@ -1108,7 +1108,9 @@ int twe_start(struct twe_request *tr) { struct twe_softc *sc = tr->tr_sc; +#ifdef TWE_DEBUG TWE_Command *cmd; +#endif int i; u_int32_t status_reg; @@ -1119,7 +1121,9 @@ twe_start(struct twe_request *tr) /* mark the command as currently being processed */ tr->tr_status = TWE_CMD_BUSY; +#ifdef TWE_DEBUG cmd = TWE_FIND_COMMAND(tr); +#endif /* * Spin briefly waiting for the controller to come ready @@ -1170,7 +1174,9 @@ static void twe_done(struct twe_softc *sc, int startio) { TWE_Response_Queue rq; +#ifdef TWE_DEBUG TWE_Command *cmd; +#endif struct twe_request *tr; int found; u_int32_t status_reg; @@ -1187,7 +1193,9 @@ twe_done(struct twe_softc *sc, int startio) found = 1; rq = TWE_RESPONSE_QUEUE(sc); tr = sc->twe_lookup[rq.u.response_id]; /* find command */ +#ifdef TWE_DEBUG cmd = TWE_FIND_COMMAND(tr); +#endif if (tr->tr_status != TWE_CMD_BUSY) twe_printf(sc, "completion event for nonbusy command\n"); tr->tr_status = TWE_CMD_COMPLETE; @@ -1279,7 +1287,6 @@ twe_wait_status(struct twe_softc *sc, u_int32_t status, int timeout) static int twe_drain_response_queue(struct twe_softc *sc) { - TWE_Response_Queue rq; u_int32_t status_reg; debug_called(4); @@ -1290,7 +1297,6 @@ twe_drain_response_queue(struct twe_softc *sc) return(1); if (status_reg & TWE_STATUS_RESPONSE_QUEUE_EMPTY) return(0); - rq = TWE_RESPONSE_QUEUE(sc); } }