From nobody Sat Feb 26 17:28:19 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 165C119DB760; Sat, 26 Feb 2022 17:28:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K5YWm02XHz3nyy; Sat, 26 Feb 2022 17:28:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645896500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=moRN3GcGZAtoa61yZ07bTRMe6Q+NHvcJR8koacuAK6A=; b=PhjU29OzRA5RYTWisbb7XIKCG1d/9fXRfzht9kbfQgM1AQS/Skck397SlUXYOeLzVJe7LK HBNVAChK9k8N0UJ0cKeiFK0vrK/B3JRJlcy5q+cStYKBMF6d0Bq9hd8Ns0U8u4wPB6wGkI 6feGTU2qQJE3vKVuCWkacZWev9rYTHfHHnoFOaFqCIzJ7yx8i2i939fhhPGB3wQqPpczzv Xj2l6uMPk2EODRbckcJoxPUiq5biaOCfOOB8eraF4tVQaEnoVpODKn6774IUSU3LaRMsNj F+DQqyY84L43KDxhqp7cL3W9JRJzUMENqH+6ZEO60faTVCMBTldwHxCNwukVDA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D528517BBB; Sat, 26 Feb 2022 17:28:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21QHSJdU059941; Sat, 26 Feb 2022 17:28:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21QHSJdJ059940; Sat, 26 Feb 2022 17:28:19 GMT (envelope-from git) Date: Sat, 26 Feb 2022 17:28:19 GMT Message-Id: <202202261728.21QHSJdJ059940@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Scott Long Subject: git: e28289ca8367 - main - Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: scottl X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e28289ca83673d753b7e479810947f6a1015ad39 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645896500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=moRN3GcGZAtoa61yZ07bTRMe6Q+NHvcJR8koacuAK6A=; b=yOffj5bpn89Xka0nYIwrr/2UQ3dz8F8Aeqdx4hnGh/UEM+SedJ/OhRVO6UtrABcJ6f+CPm lp8qWnPpekJl2tWTeDOsqRl1AUdKhMytv3gtmfQn7MOhGWRR79pWGatdGL6fXzoYYKJ1hy CxRQRh008yYT59Gpmt6lJ4/fZ2icdlTuZBYQWkttlquoNJke2iIukmFUkGAu5DFAm0kKhd WzZFA25zzDtDWIWlwBJoJQCbXjhg9ppD5SCyiGIrWa/M3Eb4U3LvDziqJ+uf++y5EO3Nnh ymylal4ACczauayP3c5BPVFoCLfyjK0q8gbT1KGi9/DE9YwhUg0DOmqcq+H9dw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645896500; a=rsa-sha256; cv=none; b=AS0+4s4aOuYNK621lI58Rsj38drxZekuFULzrt5pCXZAIFuErEXeAUddGGNJKujLa5o/w/ 4cK0w/XLPOPGxfvQY2XlomBZfbSC8wE054ikZhgrRYJnl6dqbOuxnCvTACrITjf/o7iFfe ZH7trjh0TAwznbJyaQkA1MDp9Yq500iHj/FMebfKSfp6fHeHM9MzbTiMSEZYIGUIdqKqAS 2+qJ6D5rlxdqlbhJICMTAYqYSIGRO1KGF3U9A9QPmr/zzFJHs2KqXOsF5dTGJbFiwdwbaw Tu+/eJG+NpcdLSHlJf/8l8LO4hDYJ7s9yC7yhUSDkhtod8z26q84P7+b1PZSYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by scottl: URL: https://cgit.FreeBSD.org/src/commit/?id=e28289ca83673d753b7e479810947f6a1015ad39 commit e28289ca83673d753b7e479810947f6a1015ad39 Author: Scott Long AuthorDate: 2022-02-26 17:25:43 +0000 Commit: Scott Long CommitDate: 2022-02-26 17:25:43 +0000 Fix "set but not used" in smartpqi. The PCI_MEM macros don't require a physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely. --- sys/dev/smartpqi/smartpqi_helper.c | 2 +- sys/dev/smartpqi/smartpqi_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/smartpqi/smartpqi_helper.c b/sys/dev/smartpqi/smartpqi_helper.c index 809677c7cc1e..b49fb2d5a718 100644 --- a/sys/dev/smartpqi/smartpqi_helper.c +++ b/sys/dev/smartpqi/smartpqi_helper.c @@ -98,7 +98,7 @@ void pqisrc_configure_legacy_intx(pqisrc_softstate_t *softs, boolean_t enable_intx) { uint32_t intx_mask; - uint32_t *reg_addr = NULL; + uint32_t *reg_addr __unused; DBG_FUNC("IN\n"); diff --git a/sys/dev/smartpqi/smartpqi_init.c b/sys/dev/smartpqi/smartpqi_init.c index 1f127cff21ec..6a9cca23f72d 100644 --- a/sys/dev/smartpqi/smartpqi_init.c +++ b/sys/dev/smartpqi/smartpqi_init.c @@ -590,7 +590,7 @@ pqisrc_process_config_table(pqisrc_softstate_t *softs) int ret = PQI_STATUS_FAILURE; uint32_t config_table_size; uint32_t section_off; - uint8_t *config_table_abs_addr; + uint8_t *config_table_abs_addr __unused; struct pqi_conf_table *conf_table; struct pqi_conf_table_section_header *section_hdr;