From nobody Fri Feb 25 18:56:47 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AE7EA19D4B05; Fri, 25 Feb 2022 18:56:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K4zXH4Zjcz3GPS; Fri, 25 Feb 2022 18:56:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645815407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xHuORYeViqSItSD6GzOOAnsUGm+9rZ1FV+JNIHqsjSw=; b=fpAZjrlgKTN86VmOJMXlfKrqzz66+6RMmiWOPwDsnXhqOO2I052mZ3zgKF84XtE877M+F6 EWXIczuIPYfw9gbRy3O4ObdPRBPmcqXudpJizfYUKESRzftRP2EUx4VR9fpWs7UzgsH1s/ /plVtA9bS22ju2mbGHAtqfWja91ECiIWvCIurbxDI7kFVexvQQJN7VEznKPzjmR0dP+Ng0 /AsGi2T5Tl51MsgpgNqQlzNLBuPS0kob5m33J8wuLAdg1cxpmvzBRo62DMcHyVTyOGXAxe KMlwbqFbICcSToJ4x5KYWh4C0+mUgas0pCFIHQ8IZaFrffLo9BnoR+jYX9Yhlg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7903524CCC; Fri, 25 Feb 2022 18:56:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21PIul8p046477; Fri, 25 Feb 2022 18:56:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21PIulJ5046476; Fri, 25 Feb 2022 18:56:47 GMT (envelope-from git) Date: Fri, 25 Feb 2022 18:56:47 GMT Message-Id: <202202251856.21PIulJ5046476@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: c84bb8cd771c - main - rmlock: Micro-optimize read locking List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c84bb8cd771ce4bed58152e47a32dda470bef23a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645815407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xHuORYeViqSItSD6GzOOAnsUGm+9rZ1FV+JNIHqsjSw=; b=owxny/9KnHNnPDzOmRThs7/T4Q4iLRVPzyC2HN8dqYxmbmK1DR5DT+jAusH5UWC9x8PCKG nP/nUVp9WaApbQiLTL90gdTBwWdcdcCtuseCNZKOEwPkEf0O/sNtTB2wKqhseYf2n8sgLI FJ2BCgQEat462bGYCXcg7CCGGl0hA91KdpbxjZJzogx+F3FKYdyQBh1rAY2urEKgL6rQ0e AfgXfljrpuIdTHSysg7O0o4la+HOUtO39yB7OktW/r5npFp0PoVrD8Pt4oeF8HdSurxuF2 RGm25VrE/J0bKthQigqXNVGUh3RI3Idbuk//R5hKsAgHslmliksEKzXXnHDecQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645815407; a=rsa-sha256; cv=none; b=ryMYPbBaVWj+TIdwtgT9cIOs/xW+7Ia3l3BsWCXZC48kD/VYyH16IwVQXAQSwOZVQp6Qi3 +hIZtoT7InSLFmTeTb7EqbiLJ+tYXuSmJIdYxv2Ahs7oiAmGp8eKG4tiFfRAxi3zKjhOpT 6pRidwQDHnzUyXiNTIsoIOy3ZS7e7AFtNW2hDyakXlvL7uz6+oUlsUfBHEPcJGIwt9xOP6 +JLuCHC1yG3eg8zZ8h0oUkonpH4iiFmLbZCKrXZ1pBTuzLAb+iaFxqCelvK27URxQWWUxC 3BzTkyw3KF0LaBzkKw3Pm5AO9zU9bRBKksTWkL5IyQFgTiRu7j+6awZ5MoB5Mw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c84bb8cd771ce4bed58152e47a32dda470bef23a commit c84bb8cd771ce4bed58152e47a32dda470bef23a Author: Mark Johnston AuthorDate: 2022-02-25 18:42:51 +0000 Commit: Mark Johnston CommitDate: 2022-02-25 18:55:24 +0000 rmlock: Micro-optimize read locking Use get_pcpu() instead of an open-coded pcpu_find(td->td_oncpu). This eliminates some memory accesses and results in a shorter instruction sequence. Note that get_pcpu() didn't exist when rmlocks were added. Reviewed by: jah, mjg MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34377 --- sys/kern/kern_rmlock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_rmlock.c b/sys/kern/kern_rmlock.c index 08a01fca9827..bbea8041360a 100644 --- a/sys/kern/kern_rmlock.c +++ b/sys/kern/kern_rmlock.c @@ -452,7 +452,7 @@ _rm_rlock(struct rmlock *rm, struct rm_priotracker *tracker, int trylock) atomic_interrupt_fence(); - pc = cpuid_to_pcpu[td->td_oncpu]; /* pcpu_find(td->td_oncpu); */ + pc = get_pcpu(); rm_tracker_add(pc, tracker); @@ -517,7 +517,7 @@ _rm_runlock(struct rmlock *rm, struct rm_priotracker *tracker) return; td->td_critnest++; /* critical_enter(); */ - pc = cpuid_to_pcpu[td->td_oncpu]; /* pcpu_find(td->td_oncpu); */ + pc = get_pcpu(); rm_tracker_remove(pc, tracker); td->td_critnest--; sched_unpin();