From nobody Sun Feb 20 19:14:39 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8859219DDC29; Sun, 20 Feb 2022 19:14:43 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K1w9G6sJVz4pKS; Sun, 20 Feb 2022 19:14:42 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645384483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8Jvwfz2G5O+3nOviOc5rSmuFtJS3MsY2xFChIFc+2U=; b=s6LmMj3GRlaZvbqQupnz3Y2IYRdHQN7UYM9p2JCMpIOkHoJZrl7sc1O4hV+lqGMeVHqha8 dDVDGKTm6ZJ0UfzmRSwHNygFUWSkYX2eKCnbq5rn3KkSudol4ViBAkVT8IVZqKt6BU5rx4 Ki+DgIuvZLrFIpHXv/gB15scDxIGObynrNVp5vp4Tq3mfd06+1yo5Ek3YuMwj3ut+9Rlkf YQZ8o1ELgla20aczu2Ll9FSWMf9ViE+nmnEFOPuJnctebUdCu1WKIxLxYCWzSJEzur67WR vXZWzrxfrGXb2106hYlvbD2Rv0XGJdxfEyPhz3RHleoXsKdW8CQCVVERMZvgSA== Received: from [192.168.1.10] (unknown [IPv6:2601:641:700:2831:f8f3:1268:aa1c:f271]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 542DD2B6E7; Sun, 20 Feb 2022 19:14:42 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.58.22021501 Date: Sun, 20 Feb 2022 11:14:39 -0800 Subject: Re: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters. From: Ravi Pokala To: Michal Meloun , , , Message-ID: Thread-Topic: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters. References: <202202201139.21KBd1qc072900@gitrepo.freebsd.org> In-Reply-To: <202202201139.21KBd1qc072900@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645384483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b8Jvwfz2G5O+3nOviOc5rSmuFtJS3MsY2xFChIFc+2U=; b=xrcevJAc5zGZ5pVWm7oYRv2KcvyrgmBUpWzmLJEmNDh+kXzjrUCLHLJ8rfkPRqIX4vBjKD vXY4WEQKHHmz6TPcm73BQ6oMqWkUfRColc5SeUCKrY0GvBVjjKfasj9qY8smD+RTZ4T3oW E3BNlzqZ4s700/PXqTa0ix73KYP24X1rDssREXF3qDdQ9XBt/MNapRLkNPApziqFpeBdIf F1ha8xghKkRiyWjSYEP3bdJ25vGSidja00zaC/K0vYkDdXmUocOSL1BzIm7S77Ml7MO+aF oPeq8TQ59IWQQHbZSXDoKt9Im61b+1wVpxIKoLD0PaDYoK7xKQ17awJVG76fAA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645384483; a=rsa-sha256; cv=none; b=FSGMeZrJbnnxSUDS72/r04r8UaxsduCdj4nMDEAddqfPeay/igYIV3IjYQAoFwNGxFcxMo LpsG4+I3LK+VnHM/o3xfAR6kRdW/4uDxMNZ2dAB+zApZ7Xk2PG00Re8aUrysCCsrd6QORj rpgumOOolEjSo3E1uUb8DWpECCBo/ovLS0YrMbCmuXnoGp+qFyWMmGKtOoeCsnG5kHwPUU cW44CCNAX0zWenGYsSevWSmJO67Hqqh9LjupQeB9RR9I0S6YIKGYbO16L9EXKi3yQSa55w pIC5VQUT5Y0ngGaNC80oHBsjwZOCSWMe35KQMtfGHGNMpDKtNb6xZPgI6G8bhQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N -----Original Message----- From: on behalf of Michal Meloun Date: 2022-02-20, Sunday at 03:39 To: , , Subject: git: 1bd3e8ba6966 - main - ofw_iicbus: Add method for manual setting of basic OFW parameters. The branch main has been updated by mmel: URL: https://cgit.FreeBSD.org/src/commit/?id=1bd3e8ba696633ccd7525030d951b58ade167814 commit 1bd3e8ba696633ccd7525030d951b58ade167814 Author: Michal Meloun AuthorDate: 2022-02-20 09:45:14 +0000 Commit: Michal Meloun CommitDate: 2022-02-20 11:25:58 +0000 ofw_iicbus: Add method for manual setting of basic OFW parameters. Some IIC multifunction devices may have multiple I2C addresses per chip, but only the primary address is listed in the DT (e.g. MAX776200). In this case, the sub-devices for the secondary addresses must be created manually with fixed OFW parameters (node, name, compatibility string, IIC address). Add a bus method to the ofw_iicbus interface that does this. Hi Michal, This change seems to have broken the arm/ZEDBOARD kernel build: ================================================================ [threepio:~/freebsd/src/clean-main] rpokala% less _.arm.ZEDBOARD ... >>> stage 3.1: building everything -------------------------------------------------------------- /usr/home/rpokala/freebsd/src/clean-main/sys/dev/fdc/fdc.c:1890:6: warning: variable 'unit' set but not used [-Wunused-but-set-variable] int unit; ^ 1 warning generated. /usr/home/rpokala/freebsd/src/clean-main/sys/dev/iicbus/ofw_iicbus.c:45:10: fatal error: 'ofw_iicbus_if.h' file not found #include "ofw_iicbus_if.h" ^~~~~~~~~~~~~~~~~ 1 error generated. --- ofw_iicbus.o --- *** [ofw_iicbus.o] Error code 1 make[8]: stopped in /usr/home/rpokala/freebsd/src/clean-main/sys/modules/i2c/iicbus ================================================================ Thanks, Ravi (rpokala@)