From nobody Tue Feb 08 18:36:48 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E6A7F19AA613; Tue, 8 Feb 2022 18:36:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JtWv44C3Pz3qNq; Tue, 8 Feb 2022 18:36:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644345408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N1kmqx/vX0yY4a/DpSNiGW16Y8tjhcDBcpEM7nMn2dM=; b=c5UCG1CW/81llyimA2YO4roHT7DcggzOfu4AoTfrlzw/aNfr6jmPBhQZfXHnPQQDkDjw/x jonofopIpVk+3c9TLRkMRbeXUMVcLTSx7YXwr7nsRUZTzGLsatm13EhwfdXa06CjUVHkP9 O1y8d+sMpyFDmK7q9QSBKxC+anaFijc7MlX9vkWEFv7TgtsiLNryxRa4sJaC6ntwZbaJYI K9dj+Fj8PWLocAlDnB5VZoCFnFIfD9YsGKr0fJIFdPgbYyAGf2qXr/8VtZVrzYbf9kjEBV ocZZNgNHNV1PmEBZTWWKsFYlRDawD9r15iHGGZPAAW3ioQeALzxECdJtnKR/hw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 510551E645; Tue, 8 Feb 2022 18:36:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 218IamqF089078; Tue, 8 Feb 2022 18:36:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 218IamC3089077; Tue, 8 Feb 2022 18:36:48 GMT (envelope-from git) Date: Tue, 8 Feb 2022 18:36:48 GMT Message-Id: <202202081836.218IamC3089077@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 927aa5fefd4c - main - bhyve: Fix getaddrinfo() error handling List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 927aa5fefd4c69e72d44189a04fadf80e42d0ad8 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644345408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=N1kmqx/vX0yY4a/DpSNiGW16Y8tjhcDBcpEM7nMn2dM=; b=VZbasiZWKpd5DwNKoy1nJVvO5csyyXJHIdENZBTGvbiRkFwn/qslicOIwk9bALX9AQrKjs 0a/q2LE/DWVl/PofLGAf4+mTXU4Oc1cnzX6LXX3XtOP1JRGO6gIzqrYitxEMnhuEfkqt2f IXbZa9wFm6ZfWU0uC2t2BCyq8f3NdfIAS9MPQeWuLfYj4vg2SKi5NG7c26oxgNrM4Cpv82 3Ar7K4HVJdZjeUzSjY90fwmgG9LU29u5C3KU06+Z6PvBOPNi+C6gtYQDCCkrd9dNZZDiy0 UQno1si2x3SvZLYgU5oaaxkvCLAzdFuBxUMdoIeRC34WsKhHv3yCE/ipjIka9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644345408; a=rsa-sha256; cv=none; b=EI8U4MgDug/v5+PJfy6QbgwnaxKhqCfitRhWRjI/w5P1yu4JSv403ISiCa9d5wKRvRfgwY R6XK4NwgHjmV+WOkP1Hp4Lbar7aXF4DNQDtf7KdkqokkZBV+DUkeFZQRtMxA4xn7mnZw1E yMvlsbFEsJY/0HrMKer3uPziuDNu0PcLxvZ82mCEYjcMgUbeER2y/9BLc0ZwFAnB+zF4bS c6j9uVV1jnOMd5AE/egpr9mIz2ADjRf1aZMRKyXWvMGKyk4OLQG59L5pvf/BnPGddAfhFD rl01rocFqOBJqjaWBoXg3Do3FU4XX1Y7cPqtVuUFOCu9AU9F2cLVA2ZMmSIsTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=927aa5fefd4c69e72d44189a04fadf80e42d0ad8 commit 927aa5fefd4c69e72d44189a04fadf80e42d0ad8 Author: Mark Johnston AuthorDate: 2022-02-08 17:34:03 +0000 Commit: Mark Johnston CommitDate: 2022-02-08 17:40:41 +0000 bhyve: Fix getaddrinfo() error handling - Use errx() since errno will not be set. - Print the message returned by gai_strerror(). MFC after: 1 week Sponsored by: The FreeBSD Foundation --- usr.sbin/bhyve/gdb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/usr.sbin/bhyve/gdb.c b/usr.sbin/bhyve/gdb.c index 0cee1c8f9543..3842a1d58dec 100644 --- a/usr.sbin/bhyve/gdb.c +++ b/usr.sbin/bhyve/gdb.c @@ -1858,8 +1858,9 @@ init_gdb(struct vmctx *_ctx) hints.ai_socktype = SOCK_STREAM; hints.ai_flags = AI_NUMERICSERV | AI_PASSIVE; - if (getaddrinfo(saddr, sport, &hints, &gdbaddr) != 0) - err(1, "gdb address resolve"); + error = getaddrinfo(saddr, sport, &hints, &gdbaddr); + if (error != 0) + errx(1, "gdb address resolution: %s", gai_strerror(error)); ctx = _ctx; s = socket(gdbaddr->ai_family, gdbaddr->ai_socktype, 0);