From nobody Tue Dec 27 22:56:55 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NhVQd5fwQz1LfK7; Tue, 27 Dec 2022 22:56:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NhVQd52d7z4bcn; Tue, 27 Dec 2022 22:56:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672181817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HeArVoPF++Ilb878D8QwrRbCp1L4L7seqcoHax3vic8=; b=e+2JGCROkNCk81FIuAjyCLeYideyUXppQ/yXeOHjHll8Q05ki2RddQUfKW6GbKY72lzN3K i3J+LEQjJ3EKcsJtOPM18ojQByjIFtHPWf2ZhQ/A7NQiGqkrvNsGaUGcQu6HwKpZUTDn/7 LThia0enHkT1BDsXHIDWkF4tUnk0rHH9shh26TW4LXtQQbX3LiWcsTmorvmZFvJkwtvckC nzIhz/+aLFNXENs557A7B+XltKeEHOQFwI1VzXw8XjVwu1CGqz97n+0yH2VIAtDvPMLSqE cMqXrJAr/9VmHTIXA+99e5zeOCJwGvQi8Mp5QN/55uixVwNQ1dtyxwvsZL68eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1672181817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HeArVoPF++Ilb878D8QwrRbCp1L4L7seqcoHax3vic8=; b=Cr0/yqqbLjyr6tYd4wx9bpic0hbvH9e9Q7+BuxZbw+Ji74CywcUh4n878oIm3PENieHDFX 9Ea3KzPIqdb+d08Uw9aXAzm6y2TslCfYIZLjFVNba6ELp4BBmng7Iin7jXolZ9SEQTVHfy ahvXc/mU1Rc3gETv8zZ1GlJcTWmTkglWe47Q/i+vPn0MtyUYj5Y3R0mm+Fz2RGcFjRf8mB eCLD5GhQXmTBZB3BffngrX46j4DQxyCnDu3TUmMVpQ5DKinP3VNCSAzanE1HlHm4NHYG4p VzwkThOAI26hY3YCAbx0mvs6SplR5+VHvah71U8pdiCoQO4hZUrt5c2mPfHM1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1672181817; a=rsa-sha256; cv=none; b=ow/vrCBQ1iwEyxOovN/VWV80ilyTWsJ0BJhKrd8nAAoi2jHSL2du8bc80CZGs7A119cpIk cxi9na1v9+5wklJ+JWy4wMBR8DVbUe89i91xxBc2M2Eucvu6z2c/UeJd4+jJho41DOgMQk Ej3MYr0hTsrEY7orVlvlP7NLTuv6RoVGK31dxPN/SnIqxVnIUEtkY6qTpGTmBFAuvNxouV H6I63BFsgN+aTcaf6mpSLIProFpak/7oxmWyZ3Xgs9YF3HU/JFXRApOYmOQVuvkKdrCFQg I5oa49mSQm9ABV+4WpIgQGFujcMoWP/iXRB+hrOM1cugXFIZ+q12OdzVpIET1w== Received: from [IPV6:2601:648:8680:16b0:50cd:f825:f146:c469] (unknown [IPv6:2601:648:8680:16b0:50cd:f825:f146:c469]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NhVQd0gX8z1PBf; Tue, 27 Dec 2022 22:56:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <6770be0e-5b3a-1c37-3e65-61711d608b94@FreeBSD.org> Date: Tue, 27 Dec 2022 14:56:55 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: git: 526f57bf85a2 - main - Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for clang 15. Content-Language: en-US To: Dimitry Andric Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202212251159.2BPBxmAG029954@gitrepo.freebsd.org> <5a772eb7-55c8-5e73-e346-5514ef144dc3@FreeBSD.org> <5AA0B3E0-4F11-4F8C-8950-028A59BB2955@FreeBSD.org> From: John Baldwin In-Reply-To: <5AA0B3E0-4F11-4F8C-8950-028A59BB2955@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 12/27/22 11:15 AM, Dimitry Andric wrote: > On 27 Dec 2022, at 18:40, John Baldwin wrote: >> >> On 12/25/22 3:59 AM, Dimitry Andric wrote: >>> The branch main has been updated by dim: >>> URL: https://cgit.FreeBSD.org/src/commit/?id=526f57bf85a2b9b113c55ded47b932abc8567bc5 >>> commit 526f57bf85a2b9b113c55ded47b932abc8567bc5 >>> Author: Dimitry Andric >>> AuthorDate: 2022-07-25 10:29:58 +0000 >>> Commit: Dimitry Andric >>> CommitDate: 2022-12-25 11:58:22 +0000 >>> Update CWARNFLAGS in bsd.sys.mk and CWARNEXTRA in kern.mk for clang 15. >>> MFC after: 3 days >>> --- >>> share/mk/bsd.sys.mk | 17 +++++++++++++++-- >>> sys/conf/kern.mk | 4 ++++ >>> 2 files changed, 19 insertions(+), 2 deletions(-) >>> diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk >>> index a220c9d173ed..43359fed29c7 100644 >>> --- a/share/mk/bsd.sys.mk >>> +++ b/share/mk/bsd.sys.mk >>> @@ -86,6 +94,11 @@ CWARNFLAGS.clang+= -Wno-unused-const-variable >>> .if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 130000 >>> CWARNFLAGS.clang+= -Wno-error=unused-but-set-variable >>> .endif >>> +.if ${COMPILER_TYPE} == "clang" && ${COMPILER_VERSION} >= 150000 >>> +CWARNFLAGS.clang+= -Wno-error=array-parameter >> >> I've fixed all these that GCC 12 finds. Do we really need to disable it for clang >> now after I've pushed those recent fixes? > > I didn't notice, but it's likely because I had the above in the > llvm-15-update branch for months now. I found some old build logs from > the beginning of December, and they still contained ~20 of these > warnings. But if they're all fixed now then sure, lets's remove the > -Wno-error= again. At least for amd64 they are clean for GCC (granted, sometimes GCC and clang find different sets of warnings for these, and I haven't gotten non-amd64 building with GCC 12 yet). If this is down to a small number on recent main I think it's worth fixing the remaining ones and enabling it. >>> +CWARNFLAGS.clang+= -Wno-error=deprecated-non-prototype >> >> I'm curious how many places are broken by this and how much it would be to fix? >> This is just adding '(void)' in place of '()', yes? > > 5859 instances, as of the last count. I committed a bunch of these, and > then got some negative feedback about it, so I decided to simply make > the warning non-fatal. Somebody else can go over these one by one and > fix them as drive-by commits. Indeed the fix is just replacing () in > declarations and definitions of C functions with (void). Ok, that seems like a lot, so squashing it for now is prudent. In general if folks are looking for simple but boring tasks, fixing the real warnings for some of the warnings we currently squash so we can enable them again would be nice. -- John Baldwin