Re: git: f2c8381fce9b - main - netlink: add snl(3) - simple netlink library

From: Shawn Webb <shawn.webb_at_hardenedbsd.org>
Date: Fri, 23 Dec 2022 17:47:29 UTC
On Fri, Dec 23, 2022 at 03:03:19PM +0000, Alexander V. Chernikov wrote:
> The branch main has been updated by melifaro:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=f2c8381fce9b87695ea448591e4412cbed38aa77
> 
> commit f2c8381fce9b87695ea448591e4412cbed38aa77
> Author:     Alexander V. Chernikov <melifaro@FreeBSD.org>
> AuthorDate: 2022-12-18 17:34:41 +0000
> Commit:     Alexander V. Chernikov <melifaro@FreeBSD.org>
> CommitDate: 2022-12-23 15:03:13 +0000
> 
>     netlink: add snl(3) - simple netlink library
>     
>     Reviewed by:    bapt, pauamma
>     Differential Revision: https://reviews.freebsd.org/D37736
> ---
>  share/man/man3/snl.3            | 303 ++++++++++++++++++++++++++++
>  sys/netlink/netlink_snl.h       | 435 ++++++++++++++++++++++++++++++++++++++++
>  sys/netlink/netlink_snl_route.h | 128 ++++++++++++
>  tests/sys/netlink/Makefile      |   3 +-
>  tests/sys/netlink/test_snl.c    |  92 +++++++++
>  5 files changed, 959 insertions(+), 2 deletions(-)

It seems this might have broken buildworld:

In file included from netlink_netlink_snl.c:1:                                                     
/usr/obj/usr/src/amd64.amd64/tmp/usr/include/netlink/netlink_snl.h:244:25: error: cast from 'char *
' to 'struct nlmsghdr *' increases required alignment from 1 to 4 [-Werror,-Wcast-align]           
        struct nlmsghdr *hdr = (struct nlmsghdr *)&ss->buf[ss->off];                               
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 

I'm getting tons of errors like these with `make -sj10 buildworld`.

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc