From nobody Thu Dec 22 12:29:35 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nd8l46N1dz1HGnS; Thu, 22 Dec 2022 12:29:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nd8l45vBhz4VQN; Thu, 22 Dec 2022 12:29:36 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1447c7aa004so2272963fac.11; Thu, 22 Dec 2022 04:29:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pA419NlahKwHOo2t6HBP8ACj5cuJXQIRNXWv70BCLvs=; b=P8ypUFXdg001Nd4tPJqELY9SPT0A87UlHg+Ycs2TWlIl+ZM7UvQfwA/78pcZAuhCl1 5zHFktp7tg/FqQDuXxxFac8954NQRmtLTANlL8efZmeZYNR254O9gvAa1K3Cg1XIy3FX SYdzi2O1hBAqq7SiEc7jbCTMxrL+6fZ6aRhAynx4d/t3QoEP5rh7/p9creVVlUvk64c3 r+QxxTB/QqCML44zrwzXFqWUbuiW1rhNka3r/zV29afyOEWQ35t3rXsmTHa3zBHetEp1 oqrH6rv9GoNGy69PZIVdt3Vb8zVTNH8biqIJcBc020uVQ3svPa65QLj53Zh8tvSBAYbY 6MOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pA419NlahKwHOo2t6HBP8ACj5cuJXQIRNXWv70BCLvs=; b=4yZDVUT4q3KEVwT1tTDhq7d0KocHhwM70iQEaG8s5idQ6Zyt0mfE6hwKp7zWPSFSnu sgjdm/Y5jE1s4+bCPSf7ahXUJFjUvS9RymqD25ZjsV9RJjLILs/32b5MSE9xilEZmp+0 7llzFjW3lCqMA+1e94PryOX9wZsSm79aFZddD6t9JNDt5I6Qeb/pE8+f4HV+sZ3T9Ftv VFC+NZRl/XRDba1LDwEytXhIdYr935FcaucknyCO9uF1gY/HFzn3xvx2Ow+141AiQvMS dntmdjXanutQu4sAk5on72s6xDJR91SosmOzgubiyjJxE4ZaXnSY8Kj2gjv7dkexgdpw 1neQ== X-Gm-Message-State: AFqh2kqsGxBSmQMdmtlTH32UYJPLtsJ9C8whaFcbVJT9Y2kK+okcrdA3 6bG8DB7Qm1/aprDL0F2ELr5XoJfisGQF4Tk6Bgo/Xyym X-Google-Smtp-Source: AMrXdXv7lijsc/D1Ku0jABqq4kfnoIPpmtc7MPc2KXf2KG5fdzXRCrpFnLU1NRWacO9evN9jtiaYMaQQ/l2wgyfx7Sw= X-Received: by 2002:a05:6870:e9a:b0:144:68b8:88eb with SMTP id mm26-20020a0568700e9a00b0014468b888ebmr375231oab.159.1671712175956; Thu, 22 Dec 2022 04:29:35 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:77d5:0:b0:491:8368:9bdd with HTTP; Thu, 22 Dec 2022 04:29:35 -0800 (PST) In-Reply-To: <80ce4bdc-70b9-fb4e-a248-a9be0d453dd4@FreeBSD.org> References: <202212190814.2BJ8EcoL052955@gitrepo.freebsd.org> <80ce4bdc-70b9-fb4e-a248-a9be0d453dd4@FreeBSD.org> From: Mateusz Guzik Date: Thu, 22 Dec 2022 13:29:35 +0100 Message-ID: Subject: Re: git: 269c564b90d3 - main - vfs: retire NDFREE To: Renato Botelho Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Nd8l45vBhz4VQN X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N diff -ru open-vm-tools-stable-12.0.0/open-vm-tools/modules/freebsd/vmblock/vfsops.c open-vm-tools-stable-12.0.0.patched/open-vm-tools/modules/freebsd/vmblock/vfsops.c --- open-vm-tools-stable-12.0.0/open-vm-tools/modules/freebsd/vmblock/vfsops.c 2022-03-04 21:01:24.000000000 +0000 +++ open-vm-tools-stable-12.0.0.patched/open-vm-tools/modules/freebsd/vmblock/vfsops.c 2022-12-22 12:27:51.897759000 +0000 @@ -174,11 +174,14 @@ NDINIT(ndp, LOOKUP, FOLLOW|LOCKLEAF, UIO_SYSSPACE, target, compat_td); error = namei(ndp); if (error) { - NDFREE(ndp, 0); uma_zfree(VMBlockPathnameZone, pathname); return error; } +#if __FreeBSD_version < 1400075 NDFREE(ndp, NDF_ONLY_PNBUF); +#else + NDFREE_PNBUF(ndp); +#endif /* * Check multi VMBlock mount to avoid `lock against myself' panic. On 12/22/22, Renato Botelho wrote: > On 19/12/22 05:14, Mateusz Guzik wrote: >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=269c564b90d3f95ac3afbd4bd1adad36681f2b93 >> >> commit 269c564b90d3f95ac3afbd4bd1adad36681f2b93 >> Author: Mateusz Guzik >> AuthorDate: 2022-11-17 16:59:20 +0000 >> Commit: Mateusz Guzik >> CommitDate: 2022-12-19 08:07:54 +0000 >> >> vfs: retire NDFREE >> >> There are no consumers anymore. Interested parties can NDFREE_PNBUF >> and vput or vrele relevant vnodes. >> >> Tested by: pho > > Hello Mateusz! > > This change broke open-vm-tools. If you have any advice about a proper > fix please let me know, otherwise I'm going to take a look at it when I > have some spare time. > > https://pkg-status.freebsd.org/beefy17/data/main-i386-default/p3a8cf525382f_s54b96380f5/logs/open-vm-tools-nox11-12.1.5,2.log > > -- > Renato Botelho > > -- Mateusz Guzik