From nobody Wed Dec 14 00:37:41 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NWxKM4hw9z4kFv4; Wed, 14 Dec 2022 00:37:43 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from glebi.us (glebi.us [162.251.186.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4NWxKM1kjwz43FC; Wed, 14 Dec 2022 00:37:43 +0000 (UTC) (envelope-from glebius@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: by glebi.us (Postfix, from userid 1000) id DBC492E3FE; Tue, 13 Dec 2022 16:37:41 -0800 (PST) Date: Tue, 13 Dec 2022 16:37:41 -0800 From: Gleb Smirnoff To: Mateusz Guzik Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 67e628b7a643 - main - kref: replace hand-rolled atomic ops with refcount API Message-ID: References: <202212130925.2BD9PNWE090002@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212130925.2BD9PNWE090002@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4NWxKM1kjwz43FC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, Dec 13, 2022 at 09:25:23AM +0000, Mateusz Guzik wrote: M> The branch main has been updated by mjg: M> M> URL: https://cgit.FreeBSD.org/src/commit/?id=67e628b7a6432c1ab296b0c936dffc42df357d82 M> M> commit 67e628b7a6432c1ab296b0c936dffc42df357d82 M> Author: Mateusz Guzik M> AuthorDate: 2022-12-05 17:38:45 +0000 M> Commit: Mateusz Guzik M> CommitDate: 2022-12-13 09:24:57 +0000 M> M> kref: replace hand-rolled atomic ops with refcount API M> M> Sponsored by: Rubicon Communications, LLC ("Netgate") M> Differential Revision: https://reviews.freebsd.org/D37608 M> --- M> sys/compat/linuxkpi/common/include/linux/kref.h | 22 +++++++++++----------- M> 1 file changed, 11 insertions(+), 11 deletions(-) M> M> diff --git a/sys/compat/linuxkpi/common/include/linux/kref.h b/sys/compat/linuxkpi/common/include/linux/kref.h M> index 3b5645bf139b..9a6814175223 100644 M> --- a/sys/compat/linuxkpi/common/include/linux/kref.h M> +++ b/sys/compat/linuxkpi/common/include/linux/kref.h M> @@ -44,35 +44,35 @@ M> M> struct kref { M> /* XXX In Linux this is a refcount_t */ M> - atomic_t refcount; M> + volatile u_int32_t refcount; M> }; A nitpick: use standard uint32_t instead of BSD u_int32_t in new code. -- Gleb Smirnoff