From nobody Fri Dec 09 14:11:08 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NTCcD5GjCz4jNxj; Fri, 9 Dec 2022 14:11:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NTCcD4XB2z46lk; Fri, 9 Dec 2022 14:11:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670595068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=66khLuZP4Jln64ZMk60899/qlVafV8Gy6w3TdndOtc8=; b=nPG1d+S5uxCzAGDE0UbW79NinWFYOCOfHWHdkCoMPcQLUBSjyOGPILQLG3ZBVAxeAvJylZ C1iRIKuS62MVvEzPCVaUN3Xp5/Bd4wOxX6Faldhl/raSHyuPkbZzTX1jNgFUYjMhFSNDgt PQvvpU03u6PgwiGxXNt9D2iNQwgX12AjlgFv7Rjhyn9Dd6mSxT/FkgtNnhkr8JsbSdkEOd 2S9++8SJLg1c7wvZ8jQsMFO1luXG/zgCc2J1nwzyTRoAeAsMUqeJdXIZG7oEq0VKL69Gdj kDnE3x/RtWpq7RZoyZpxxj2SgCipUoKiuGuimw9YBtmC7DIq9NALg1+qA4y44w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670595068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=66khLuZP4Jln64ZMk60899/qlVafV8Gy6w3TdndOtc8=; b=g5daUfks+7sX/G5IUAxKjg5CK/vEc52rTeDZjvShaMnLTKacAA/q6LIFXLLs7w99hx2UBm 7/WiykmwoBsqYnK3ZC3U1OcubH0Gk6Fq6Ib7aOG71Wmd0p5wxcRKQuZa9igYsMf4IvK27f Uh4P9HgwDGzQGU8Qjpeq/N4vycYdhQ4g/i7KWKJlRgpV+veEc9MLikk5TxA1dvnQ7q+cnE v+2UFlAUZaea1Wd271EiZJGVaw4bXMrF6ACkZ2oYjVreEzbeAIG+VzLL3E+eYtbn9wrEKf 9m0Yx1WniJBaDfBOioMIngyUB2cLpeajS9ftgecoxmow5/M3W9FB3Ixlk1p4Tw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670595068; a=rsa-sha256; cv=none; b=qQRAWI1H3HsizR30LEzLLtC/v0zzK7y7sLinFoTpY5pRP6sRLXWyJR7CgAMNRYBzih4DS5 2oeXCtTZLp5x8Gxw3FP4nPGuyeft92mD0W6ibASeREN/MrNJcmrUkJIFhhRXXDWy1Gs+my XkACH72C9vdfuvV8mU2B3h9mSc3W2XhQ0d2GRUGBRI4/0fLgTTE28gtNINCxIgySXIUcPm 9BzrCKDyc3O/59FfudtriLlwp3+9+/ZjQmArCkRQXGnfhQsqSJAZbaUyi9YzNJEBc0dg5R gerfnBarLzThJa+w8iKdb66PD4/2X0itucfSuicqgB1bTbXKomX3YzVdDkzsbQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NTCcD3f2Vzf34; Fri, 9 Dec 2022 14:11:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2B9EB8N7052918; Fri, 9 Dec 2022 14:11:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2B9EB8Wt052917; Fri, 9 Dec 2022 14:11:08 GMT (envelope-from git) Date: Fri, 9 Dec 2022 14:11:08 GMT Message-Id: <202212091411.2B9EB8Wt052917@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: f6d5d31cd5d5 - main - heimdal: kadm5_c_get_principal() should check return code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f6d5d31cd5d5b409851b3bf82c41a477a643a486 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=f6d5d31cd5d5b409851b3bf82c41a477a643a486 commit f6d5d31cd5d5b409851b3bf82c41a477a643a486 Author: Cy Schubert AuthorDate: 2022-12-09 14:06:04 +0000 Commit: Cy Schubert CommitDate: 2022-12-09 14:09:54 +0000 heimdal: kadm5_c_get_principal() should check return code kadm5_c_get_principal() should check the return code from kadm5_ret_principal_ent(). As it doesn't it assumes success when there is none and can lead to potential vulnerability. Fix this. Reported by: rtm@csail.mit.edu MFC after: 3 days --- crypto/heimdal/lib/kadm5/get_c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/kadm5/get_c.c b/crypto/heimdal/lib/kadm5/get_c.c index 3c31a515b2f3..3cbfefdbf334 100644 --- a/crypto/heimdal/lib/kadm5/get_c.c +++ b/crypto/heimdal/lib/kadm5/get_c.c @@ -77,7 +77,7 @@ kadm5_c_get_principal(void *server_handle, ret = tmp; krb5_clear_error_message(context->context); if(ret == 0) - kadm5_ret_principal_ent(sp, out); + ret = kadm5_ret_principal_ent(sp, out); krb5_storage_free(sp); krb5_data_free (&reply); return ret;