From nobody Wed Dec 07 20:46:08 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NS8Sy4l8Vz4jn73; Wed, 7 Dec 2022 20:46:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NS8Sy4GNrz3mtX; Wed, 7 Dec 2022 20:46:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670445970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+y4mV+CjJsDRNz1+rhYDokAuUfWK2B/YTDkECbAOFYk=; b=yYPcPPcqnMV0TDKGCEFNp8rEzrwW7rn/fEmfpcodPbDLCNJUN7Ca8Lst4nSKpxx5Dsr17P KkcnBiA3wYcd8jeFjKa0SXFu2BnBmb1Lvevjvg2iaQZCX9Yn1a1MtVZ3zFj80rTmrQOGJQ ahYd6+mn9f9gjCELgukJqQE4z0wrB6rvP+X1zqCyjIz6QXbzfEja0pOSSf1ZKaCD97r4xw QTQ+gOj3AdxbCtM6J7i52TU6vxt0SiApuxA9aR7cv2Dk7p+dFk6psRbcbBO+qSIh4Gjr3F 3CgHpbCi7FwNfx+PyWmrL6+5EiL0fTni2HQTi97eZJ4IQDT1pcoHfyk+CsPedg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670445970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+y4mV+CjJsDRNz1+rhYDokAuUfWK2B/YTDkECbAOFYk=; b=grFlek5ZJzzkK6RKuMGCeRvjkzog4drgrr2pvryfUQXipz3wzX2LO0RNl5zmVcPr3myMqy Q43k2vVM3QfDYYNlWbng0V/VVj14uGuQZRfzWLSypxRIwbR6vfnMFgPfZ7zTdHkVR7PDU3 6kjpzjX+vZ24SUnDD+lKY+uXSfGYOcW6Lp2LOmTRfIX5sQ6hJA0lR4SFxjb542goUvFKgq cSwz4t9so2e7yrINjX9YslsWuwG/ZbcOr01x37+AZL4l9sGPnrGl5mNeph2P/6/pIfkOIF O8RcE1trPSF/87Ihl2OKcFWLl9dQduwV+2HXurHBMzPfoETspuJLzU+JS9xXgg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670445970; a=rsa-sha256; cv=none; b=HdZE7zeCSeeIKnfDZYs53S20X9vUmGIepAFFBMdJFtNaV3N8sCNLTu/4uOv7xtFmY9Ej1N 3nturgWoPTtOz1AuI3AUlDlaiWmDKP1dqYO2tEAua+vhO2G0svBCSaDFA5JDSZTY/AZsGj LnC336laSKafGQmUVfj+ItSMNTepkNi6yfLKdJp6YjmSvYgZcxUQ3YTth67wgsQuekt4Da 1E134i9SZxg/t+dV3gajqzrZJLSGS8wqSSHYBJ0KhGIF8cWgcH9JEwx5c48xKdl1hmglrz sErxbIIOjbfB896tIbigRFnV1qUuD7TZUZly0Vrj7SVMhYubVsaRDs5FfwM0aA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NS8Sx67NFz11Bw; Wed, 7 Dec 2022 20:46:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <150105f9-313d-c25e-33b2-891c2a8b6d8b@FreeBSD.org> Date: Wed, 7 Dec 2022 12:46:08 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: git: eb6f48854df2 - main - Fix a typo in the binmisc option name Content-Language: en-US To: Gleb Smirnoff , Doug Rabson Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202212071354.2B7DsAgE012788@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 12/7/22 9:45 AM, Gleb Smirnoff wrote: > Doug, > > On Wed, Dec 07, 2022 at 01:54:10PM +0000, Doug Rabson wrote: > D> commit eb6f48854df20441b384ca36b6b31558ada087c9 > D> Author: Doug Rabson > D> AuthorDate: 2022-12-07 13:40:18 +0000 > D> Commit: Doug Rabson > D> CommitDate: 2022-12-07 13:51:34 +0000 > D> > D> Fix a typo in the binmisc option name > D> > D> This should be spelt IMGACT_BINMISC to match the filename. The option > D> name does not appear outside of sys/conf and this module is typically > D> used via the kernel module imgact_binmisc.ko. > D> > D> MFC After: 2 weeks > > My custom kernel has been broken by this change. I don't think you want to > MFC that and you might think of reverting it at all. The option has been > used for quite a long time to change its name. May be rename the file > instead? No, it was a clear typo. All the other image activators follow the existing pattern (imgact_elf.c, imgact_aout.c, imgact_shell.c). Maybe a note in UPDATING, but I suspect there are very few users compiling this into custom kernels in practice. -- John Baldwin