From nobody Tue Dec 06 02:09:51 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NR3lN2G8Rz4jL5N; Tue, 6 Dec 2022 02:09:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NR3lN1T7qz4Mqj; Tue, 6 Dec 2022 02:09:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670292592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lYdpd4UIlEtHLE8BfkyxXgoXX4bFTly+OrR1MdMz6r0=; b=kmq4t9NqKR/3xONtfIIa0AQPLdsTXJqR0LarkDV5AksruZE7RMma+yLdrp4Vxx0eGPbrMK gR6uN748VoZQQPUKnicitUX09h4RW1YtA/1Oxzvy6v05Frj29GFoYr7bvt6l29LKmILJYp 8ygmICWX1s4bvIfGnfDGCCNS4Z3HkLvr5IVxtoAVFR+dPObpQFidZjkSu81L7URb2sfSC/ 4F7Pir9zloRnXTCu5C4b9If1C1ePt9VUzn6uqFg4ntyXdVyEY+i+ydpiFjOJ1xqh1I1Wux 2OVsESbGGI6WEs2cXyXC8Jyn5AqSNA7Op06e3QzBMtB3vQCQtdzdVEmw8aDLfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1670292592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lYdpd4UIlEtHLE8BfkyxXgoXX4bFTly+OrR1MdMz6r0=; b=Nm4bjP4J1yjxJ3qYG8Cy8b4g/8/Y0MBCVy0VKv257u9OAlblgXpNrPxS+zhIfB/2txDNDY 1gbJIrlGdFEWQN+NUTNm8yEHtCAEJhZzups+fI5HeK1NandVV1usIyGoU0rnaQioDiaMoS Y8X7S5wBKzZGsVTEPooKtsUWUz/0FtNE9zYiBpiypdmvIK9D95uREnGO336D1UAbxdJStI owd/XwG5sv7srE3CytFhMl97Lz1884XD6PRHOnD/gHNMIKV39e2uLh70Yjsbv7HOu+oVSC c8BEajwvbeGnC5pgkEyb1Uhnb3WlI4FkD3PQ0jm5EyiFqWh4boRhkgw400P62A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1670292592; a=rsa-sha256; cv=none; b=DIgrCHo7/oJ+ydx550IfpZg3Tc8GKW0cCz0Cikke3FcXHfR1m0RovNYbJ/eOqo05Efi8BK QhZa4qc4km+YmiKfnvDCkt8STmU75wVv7wWS5hr0m5dzVGojuDnyMxwY2S7tkPYC7O+Bb8 I7972EIyVQT1zIXmPEDAa5E6IZosS105l+el7wgwDVnIh64+iHOTQuyDmxmpHljBZKbWr9 zraHY/54J7zcRluXrWzU8/ADn8r21UxJWV6VMhVlt5Qtt0Ii4ZGhUG42AMZtjxqRmfPK8P mKRV8toLAkF4oh9vy08bH3fc14Rb0ThWe8kakbLMiErtyl5Gsq8GP9RTh4BCrA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4NR3lN0ZD7zKgd; Tue, 6 Dec 2022 02:09:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2B629pYD053880; Tue, 6 Dec 2022 02:09:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2B629pnu053879; Tue, 6 Dec 2022 02:09:51 GMT (envelope-from git) Date: Tue, 6 Dec 2022 02:09:51 GMT Message-Id: <202212060209.2B629pnu053879@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 3cf97e91fac5 - main - Revert "newbus: Change attach failure behavior" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3cf97e91fac5f53fc0375bc816cc541a8864ffc4 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=3cf97e91fac5f53fc0375bc816cc541a8864ffc4 commit 3cf97e91fac5f53fc0375bc816cc541a8864ffc4 Author: Warner Losh AuthorDate: 2022-12-05 23:57:58 +0000 Commit: Warner Losh CommitDate: 2022-12-06 00:00:26 +0000 Revert "newbus: Change attach failure behavior" This reverts commit 68c3f0302106643207dcdfe3b414810e245228e5. There are some weird crashes when KVMs switch caused by this, so revert this commit until they are sorted out. Reported by: cy@ Sponsored by: Netflix --- UPDATING | 2 ++ sys/kern/subr_bus.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/UPDATING b/UPDATING index 099066031b8e..001ec9f6de3a 100644 --- a/UPDATING +++ b/UPDATING @@ -43,6 +43,8 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 14.x IS SLOW: needs to use devctl to re-enable the device, and reprobe it (or set the sysctl/tunable hw.bus.disable_failed_devices=false). + NOTE: This was reverted 20221205 due to unexpected compatibility issues + 20221122: pf no longer accepts 'scrub fragment crop' or 'scrub fragment drop-ovl'. These configurations are no longer automatically reinterpreted as diff --git a/sys/kern/subr_bus.c b/sys/kern/subr_bus.c index 6a5ec4efc38d..b9615b033007 100644 --- a/sys/kern/subr_bus.c +++ b/sys/kern/subr_bus.c @@ -69,7 +69,7 @@ SYSCTL_NODE(_hw, OID_AUTO, bus, CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, SYSCTL_ROOT_NODE(OID_AUTO, dev, CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, NULL); -static bool disable_failed_devs = true; +static bool disable_failed_devs = false; SYSCTL_BOOL(_hw_bus, OID_AUTO, disable_failed_devices, CTLFLAG_RWTUN, &disable_failed_devs, 0, "Do not retry attaching devices that return an error from DEVICE_ATTACH the first time");