From nobody Mon Aug 29 16:31:23 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MGbY925zgz4bRrB; Mon, 29 Aug 2022 16:31:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MGbY91fjNz3H5P; Mon, 29 Aug 2022 16:31:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661790685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GpoHMskh0/xLocnW1nRzcbQEMQ6ZlGZ32GrD2U5q0OE=; b=BUCjrNwYjcENscPhl3CbZc3awYB5X7yTjQExbZ6B0JTvdYpiZjvRF4t4F4EmLvtp9lU0Eh PX8msDiUKvoPf7DZv4qkS0GB3etIxU5XvRyzUIBG99cOxwuHuPqjmC6ErCpas6mZzG+07A 45RN7CbeOtDLsn9JMtyBBJn8YDL1iFTWBChzabbOMmHYvqdNzGChwkA6xPJc7gvS9hJTBJ V3oY9sTSwE0CRMYnx7O4p8w4Q50Poeyu1KLLWm75azJSNPSgfIUvY5Ty0t4fbNrMUuYyl+ 7MmyjiVLiZ7XK69+U+eH1oOp3ww4DLAdgxsir30uZzFOatbdSPJbpFOc4t0+Cg== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4MGbY84HHZz1JND; Mon, 29 Aug 2022 16:31:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <66d0a30a-a52d-f770-8c08-d223b5c5824a@FreeBSD.org> Date: Mon, 29 Aug 2022 09:31:23 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: e66390736613 - main - Define _NPCM and the last PC_FREEn constant in terms of _NPCPV. Content-Language: en-US To: Warner Losh Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202208232031.27NKVT2H033895@gitrepo.freebsd.org> <9108301c-5035-440f-0db0-a98b7465e297@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1661790685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GpoHMskh0/xLocnW1nRzcbQEMQ6ZlGZ32GrD2U5q0OE=; b=EiqRO9IFT8JHRUk5LYeWna9y4bJoatD8bdZE0yAeg6xvU1OZdfCs8DfkJOMRuM/y1ndhBV t5avfc9f1yYZguXNwspbOnR2vKUHP5EpxwRPVkKsfS9Sh1nSjY6wOShWNwK4jRF3IgkdCE iwp3/UgnuJFgd/r5MeqJkF6Ay6Dza5fRQEvzLsKJfkhYbjAhR4isZ9yCJxG0XEnyRiMmPa 8/XBhcf+8Bs4PHGvEitNgK5HzZduvBX6oJRc28jEC+8A6+O9m4Rf0l5hXWSRMq/j4ZhtVq WlJh92knNKITZ0XYF+dxN6B8DN0LNI/HAOkkwrFtajX9oKuEJpoZcFeqkumWqQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1661790685; a=rsa-sha256; cv=none; b=AHN1+hFef/8GHAbu25f2dqeR6VjdkjcxHGXtZKPtCQwXQh8wJz8AAUf3A3mcQ2n6Qmguqu F1pe/d3ijExgMtKF5cQ/XVUzsmgQZY7fhey0/YSOwFdFpnCXG4XM4Wzt6WNaVdssHZm278 FLexb45snGDRNezHUab8GG6O4pbyUJUIVai2pK+UBkX3dSbCdINXP+l6IdzzUO6LlePoEN RlBYUwM0HrA5+p+haLtOsZOZXk3NNmCUE7C/AdQ/pihK/rXXJwIS4V9IHzXn4j9iE+3ERx SyqbGdJiAZ59vlmcbRn9VTMUbC7ap3hJunY3aNI/dVqGKck+m34hYm3yanDtqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 8/26/22 2:27 PM, Warner Losh wrote: > Hey John, > > On Fri, Aug 26, 2022 at 12:10 PM John Baldwin wrote: > >> On 8/23/22 1:31 PM, John Baldwin wrote: >>> The branch main has been updated by jhb: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=e66390736613a452238531f64bb9f674ebd4c3a6 >>> >>> commit e66390736613a452238531f64bb9f674ebd4c3a6 >>> Author: John Baldwin >>> AuthorDate: 2022-08-23 20:31:02 +0000 >>> Commit: John Baldwin >>> CommitDate: 2022-08-23 20:31:02 +0000 >>> >>> Define _NPCM and the last PC_FREEn constant in terms of _NPCPV. >>> >>> This applies one of the changes from >>> 5567d6b4419b02a2099527228b1a51cc55a5b47d to other architectures >>> besides arm64. >>> >>> Reviewed by: kib >>> Sponsored by: DARPA >>> Differential Revision: https://reviews.freebsd.org/D36263 >> >> So this actually broke emulators/qemu because now >> requires . I have a patch to fix the port available at >> https://reviews.freebsd.org/D36362. What I don't know is if there are >> other ports broken by this that might change how to address this? I >> would mostly hope that wouldn't be a header that userland >> would need to use and that adding in a few places would >> be the end of it. However, if there's wider-spread breakage then I >> would hack on this to avoid the need for . >> > > This will break qemu building on FreeBSD in the 7.1 release. It's almost > out (last > rc is out and that's expected to be the actual release). Any chance we can > fix > this in our sources? Humm, maybe. I have a followup change I need to runtime test (it passes tinderbox) to add a that deduplicates much of this such that the 'howmany' is now in a single place and could perhaps be worked around more centrally. The new patch file I have would also apply to 7.1 and could eventually be dropped in the future if 7.2 adds ? For now, I'm more trying to understand how many ports are affected. -- John Baldwin