From nobody Fri Aug 12 16:51:40 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M48pQ1N9Jz4Z35P; Fri, 12 Aug 2022 16:51:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M48pQ0wzQz3DV5; Fri, 12 Aug 2022 16:51:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660323102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/cCaPunTW1ihREbyiS/LAWTmiRRt1xEtY//MlL2L7B0=; b=gccH7gzzmLIrnLA0oTq2wjQLEQL7fOBjQkCtSval9V2lQVGv4QawQ75S1dAarlojCp/mpv 7UcP6skUVHs95PviITL9N7PW1fMUmKAPu+wn0b7yVE6freXDV/Veqey9G5aE/w+Tg18zGV cCKVFtnsd26ZredemErMOTB2vqAnTe4XNOO8rtavngxBzikWDydFsMPRAsnD5pZSUTgnl+ BcadCsl4dOXgXcmXr1mrYTFZ/rVkCr9MTUzVAzimFOCnCd5e2QUblb5q1JvPPOOdkFMNBJ +SsFFRlPyJf3jKeWGBxJjnBpedxJu4cwMjEVIy49wQM9VvyBrhPB0KU61HEMaA== Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4M48pP3n4Hz1LXl; Fri, 12 Aug 2022 16:51:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9d8000f5-029d-033e-5b81-ae71951fa2f6@FreeBSD.org> Date: Fri, 12 Aug 2022 09:51:40 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: git: 4c8ea3efe73c - main - stand: Go back to a.out format for /boot/loader Content-Language: en-US To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202208112330.27BNU0nN026141@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202208112330.27BNU0nN026141@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660323102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/cCaPunTW1ihREbyiS/LAWTmiRRt1xEtY//MlL2L7B0=; b=H1cWlp02tRuv00gaaPccZINzJnAjcuxHxEECXWeQ2Q14j7au2vifCUsFYnR6ufotp3e1ZQ bybhfK+CS9mgEgXza99M6YqspZgrcIXvKKMT9s9TfyYYOkHww0+R4qxWRN/tenOJMvCdc6 RbHCpKNNKo6O3qWRsnB4S7hCpmFbt5UXe2IaRxrZK3W6uoWQ63QtL0ZRfVzrx87m3U1DH1 MwVyyD0eakVcr5x0OSPlaJf4kLslEw/VAmbargy0VOZ2OiQPGGHXW3EowXywMgO1CNm5ia 3BYpLPJZRtoQ/MYEbVviEvEIG9xnfKxSTZ2c8WCJTJiT0s6paqWZKLyOaSm2fQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660323102; a=rsa-sha256; cv=none; b=YXmRPE3M5maYEnIU0r0Wly4fRq3QA3+p4wjdR1DkHtyi0nGwzgWEGVs/uo52tR4a4K+ueM ej9I5MOunvv3fLz94i7QmpFJswDjyv/thzMJ870HgSARqFWwynhBghRR3Ggw8iQIhpM/3a h4SAPcHxllHRSScYBleIgoHtjpmztMq9HitAckQYsqkmNaKVHdYMHwZKhQXvpOaUHp6OMo MZ8Zs0aoXsUyu/dNSac6XWhOKIKnMGEooMO7k52+a+uwGry7iv7aeE+8zFG4t6zD7xbQG/ tQfXX/5yrZ8BSY2q2MlBgq+N9mma8/dreThVni0ZWpln06uQT1x5PZpBJ7IonA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 8/11/22 4:30 PM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c8ea3efe73c12d595472a7fc37177432a77858e > > commit 4c8ea3efe73c12d595472a7fc37177432a77858e > Author: Warner Losh > AuthorDate: 2022-08-11 23:29:10 +0000 > Commit: Warner Losh > CommitDate: 2022-08-11 23:29:10 +0000 > > stand: Go back to a.out format for /boot/loader > > Turns out there's two hidden a.out dependencies. pxeldr.S assumes it has > access to the a.out header from /boot/loader and cdboot.S assumes that > /boot/loader is also a.out and doesn't use boot2. > > So, go back to making a.out files for these and adjust the size checks > to use ls, but we only need to check loader.bin. Trim the size we check > against by 2,000. The difference in size between loader and loader.bin > is about 3000 bytes, but clang15 produces binaries that are a smidge > bigger so we need to relax the check just a little and accept some > additional risk for the moment. > > Add some comments to loader's Makefile about this. > > Sponsored by: Netflix > Reviewed by: emaste > Differential Revision: https://reviews.freebsd.org/D36142 Thanks! -- John Baldwin