From nobody Fri Aug 05 17:48:21 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4LztP165hGz4YY5G; Fri, 5 Aug 2022 17:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LztP15Xznz3kG2; Fri, 5 Aug 2022 17:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659721701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vnl7atGAJeXOK5gKgnm6pRWouNyvO4o75O0XJkmCvMk=; b=DTkNIiE+3dXCjwfnbaSKcH0UpVLtLyVNKSq3V8TH9x8m0HlCCYMkYjGA5LIVmtxpP4gFJw GdnaqG/vi0p1M4/cldhLeK/qbPQJ+tFf/SKTMBg+21/g3DRT7CN79sc0yYwWKYQ4QuZNmS aYa4MJbj1vSZEsg+0OsAlHJBNUfX2hjGKuOL2cTsSUZJUuWMt+gy/mDXqAytzGYzy03xc9 NYPxFtyxvsRQfWnDyk4nfu5bu67wE63ja/szAZibdMzOMTR0eWVWF15Oy11QrHjqQyuWE+ OvczxJYHLKuMgNIlEGvzBGqguWfzLr/bi5+gFILQFekX1yhf6/kebbdLPtsVjQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4LztP14XMdz12yH; Fri, 5 Aug 2022 17:48:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 275HmLso025768; Fri, 5 Aug 2022 17:48:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 275HmL3C025767; Fri, 5 Aug 2022 17:48:21 GMT (envelope-from git) Date: Fri, 5 Aug 2022 17:48:21 GMT Message-Id: <202208051748.275HmL3C025767@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: 52a54b96ed1b - main - acpi_apei: Add sysctl to mute corrected errors. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 52a54b96ed1b7c0a1c04fc7651a1fc036bdc5bbc Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1659721701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vnl7atGAJeXOK5gKgnm6pRWouNyvO4o75O0XJkmCvMk=; b=Rdg4RGabWSF4yb9f4POEZVcFzrvzLDUq/fuimUeLnJ2XIyxry4s8fleZDUjMGjA0tWhGgw +Ah+9XzYi5oXMPcik8iZ47c2C7IAAzz8xzP+JZBK7bA/XDvJqDT29s9B69+W0z+6x8Bjoo l3/EDyWWcV0f352B1AyXylJ+tdkFuiwJnp1KHzS8c1xQn0mbdsoDfcUMDJEd8XoyvPJsB6 xBhtWxZD/b4fEnSJb3eXdrUs1muCCAqPrw6mU0OfKs+P8uGJgZbAW679r9ueSPlcbObaCf JzaMRou5/zvc9xx7Ia6bXvnDgKSeRbb203605SXtz27NKPckyZYrQ6RSxDVKyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1659721701; a=rsa-sha256; cv=none; b=gwNlW4g1mxOs5YNoV5Y6nU6MXvZEB0ljWWUADl4I+qYBybTt+5T8PtGUu5lkujhlHvJThW xYgXkh8PXfbfncswvAIKuLzlW6W6htMMNkc48ySFE4d1Fzq7hlfz2bW09htgkI41NdQRui NOrpVPVMcceOf0h1CHPCGBVM6T7uEI/XR7qwiZNU2VVNeuwzNiyWD1rxTXopom+uxDKZSA YMgaARY+4Uf8dDFOp7QUS8Ul6zmJU06NMDO43VDSmkneEgTEbyw42hJo2X9zJ9hpkSL0PW jiGi0QrLGt3enhGXagSJHkxFN4j1mGJQlKCzv3C6CmnBK+bt5YX5Xq4/wtmIPw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=52a54b96ed1b7c0a1c04fc7651a1fc036bdc5bbc commit 52a54b96ed1b7c0a1c04fc7651a1fc036bdc5bbc Author: Alexander Motin AuthorDate: 2022-08-05 17:45:35 +0000 Commit: Alexander Motin CommitDate: 2022-08-05 17:48:05 +0000 acpi_apei: Add sysctl to mute corrected errors. Setting hw.acpi.apei.log_corrected to 0 will mute corrected errors logging. MFC after: 1 week --- sys/dev/acpica/acpi_apei.c | 58 ++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 54 insertions(+), 4 deletions(-) diff --git a/sys/dev/acpica/acpi_apei.c b/sys/dev/acpica/acpi_apei.c index 8349d81b9060..5c442d59972d 100644 --- a/sys/dev/acpica/acpi_apei.c +++ b/sys/dev/acpica/acpi_apei.c @@ -157,6 +157,10 @@ apei_bus_write_8(struct resource *res, bus_size_t offset, uint64_t val) #define PGE_ID(ge) (fls(MAX(1, (ge)->v1.Notify.PollInterval)) - 1) +static struct sysctl_ctx_list apei_sysctl_ctx; +static struct sysctl_oid *apei_sysctl_tree; +static int log_corrected = 1; + int apei_nmi_handler(void); static const char * @@ -180,6 +184,11 @@ apei_mem_handler(ACPI_HEST_GENERIC_DATA *ged) { struct apei_mem_error *p = (struct apei_mem_error *)GED_DATA(ged); + if (!log_corrected && + (ged->ErrorSeverity == ACPI_HEST_GEN_ERROR_CORRECTED || + ged->ErrorSeverity == ACPI_HEST_GEN_ERROR_NONE)) + return (1); + printf("APEI %s Memory Error:\n", apei_severity(ged->ErrorSeverity)); if (p->ValidationBits & 0x01) printf(" Error Status: 0x%jx\n", p->ErrorStatus); @@ -234,10 +243,10 @@ static int apei_pcie_handler(ACPI_HEST_GENERIC_DATA *ged) { struct apei_pcie_error *p = (struct apei_pcie_error *)GED_DATA(ged); - int h = 0, off; + int off; #ifdef DEV_PCI device_t dev; - int sev; + int h = 0, sev; if ((p->ValidationBits & 0x8) == 0x8) { mtx_lock(&Giant); @@ -266,6 +275,11 @@ apei_pcie_handler(ACPI_HEST_GENERIC_DATA *ged) return (h); #endif + if (!log_corrected && + (ged->ErrorSeverity == ACPI_HEST_GEN_ERROR_CORRECTED || + ged->ErrorSeverity == ACPI_HEST_GEN_ERROR_NONE)) + return (1); + printf("APEI %s PCIe Error:\n", apei_severity(ged->ErrorSeverity)); if (p->ValidationBits & 0x01) printf(" Port Type: %u\n", p->PortType); @@ -308,7 +322,7 @@ apei_pcie_handler(ACPI_HEST_GENERIC_DATA *ged) printf("\n"); } } - return (h); + return (0); } static void @@ -333,6 +347,11 @@ apei_ged_handler(ACPI_HEST_GENERIC_DATA *ged) } else if (memcmp(pcie_uuid, ged->SectionType, ACPI_UUID_LENGTH) == 0) { h = apei_pcie_handler(ged); } else { + if (!log_corrected && + (ged->ErrorSeverity == ACPI_HEST_GEN_ERROR_CORRECTED || + ged->ErrorSeverity == ACPI_HEST_GEN_ERROR_NONE)) + return; + t = ged->SectionType; printf("APEI %s Error %02x%02x%02x%02x-%02x%02x-" "%02x%02x-%02x%02x-%02x%02x%02x%02x%02x%02x:\n", @@ -645,11 +664,24 @@ static int apei_attach(device_t dev) { struct apei_softc *sc = device_get_softc(dev); + struct acpi_softc *acpi_sc; struct apei_pges *pges; struct apei_ge *ge; ACPI_STATUS status; int rid; + if (!apei_sysctl_tree) { + /* Install hw.acpi.apei sysctl tree */ + acpi_sc = acpi_device_get_parent_softc(dev); + apei_sysctl_tree = SYSCTL_ADD_NODE(&apei_sysctl_ctx, + SYSCTL_CHILDREN(acpi_sc->acpi_sysctl_tree), OID_AUTO, + "apei", CTLFLAG_RD | CTLFLAG_MPSAFE, 0, + "ACPI Platform Error Interface"); + SYSCTL_ADD_INT(&apei_sysctl_ctx, SYSCTL_CHILDREN(apei_sysctl_tree), + OID_AUTO, "log_corrected", CTLFLAG_RWTUN, &log_corrected, 0, + "Log corrected errors to the console"); + } + TAILQ_INIT(&sc->ges); TAILQ_INIT(&sc->nges.ges); TAILQ_INIT(&sc->iges.ges); @@ -778,5 +810,23 @@ static driver_t apei_driver = { sizeof(struct apei_softc), }; -DRIVER_MODULE(apei, acpi, apei_driver, 0, 0); +static int +apei_modevent(struct module *mod __unused, int evt, void *cookie __unused) +{ + int err = 0; + + switch (evt) { + case MOD_LOAD: + sysctl_ctx_init(&apei_sysctl_ctx); + break; + case MOD_UNLOAD: + sysctl_ctx_free(&apei_sysctl_ctx); + break; + default: + err = EINVAL; + } + return (err); +} + +DRIVER_MODULE(apei, acpi, apei_driver, apei_modevent, 0); MODULE_DEPEND(apei, acpi, 1, 1, 1);