From nobody Thu Apr 21 20:57:09 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3466511DF920; Thu, 21 Apr 2022 20:57:18 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mx2.catspoiler.org (mx2.catspoiler.org [IPv6:2607:f740:16::d18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "amnesiac", Issuer "amnesiac" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kkqbx2rc1z3pXN; Thu, 21 Apr 2022 20:57:17 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received-SPF: pass (mx2.catspoiler.org: 76.212.85.177 is whitelisted) receiver=mx2.catspoiler.org; client-ip=76.212.85.177; helo=gw.catspoiler.org; envelope-from=truckman@FreeBSD.org; x-software=spfmilter 2.001 http://www.acme.com/software/spfmilter/ with libspf2-1.2.10; Received: from gw.catspoiler.org ([76.212.85.177]) by mx2.catspoiler.org (8.16.1/8.16.1) with ESMTPS id 23LKvEuv092168 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=FAIL); Thu, 21 Apr 2022 20:57:15 GMT (envelope-from truckman@FreeBSD.org) Received-SPF: pass (gw.catspoiler.org: 192.168.101.2 is whitelisted) receiver=gw.catspoiler.org; client-ip=192.168.101.2; helo=mousie.catspoiler.org; envelope-from=truckman@FreeBSD.org; x-software=spfmilter 2.001 http://www.acme.com/software/spfmilter/ with libspf2-1.2.10; Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.16.1/8.16.1) with ESMTPS id 23LKv91S031236 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 21 Apr 2022 13:57:09 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Date: Thu, 21 Apr 2022 13:57:09 -0700 (PDT) From: Don Lewis Subject: Re: git: c00d34566536 - main - Install unwind.h into /usr/include To: =?iso-8859-1?Q?T=C3=84=C2=B3l_Coosemans?= cc: Dimitry Andric , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-ID: References: <202202101802.21AI2gHO001258@gitrepo.freebsd.org> <20220421195054.21f5a179@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=iso-2022-jp Content-Disposition: INLINE X-Rspamd-Queue-Id: 4Kkqbx2rc1z3pXN X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=softfail (mx1.freebsd.org: 2607:f740:16::d18 is neither permitted nor denied by domain of truckman@FreeBSD.org) smtp.mailfrom=truckman@FreeBSD.org X-Spamd-Result: default: False [-3.05 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[truckman]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.992]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.96)[-0.960]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:36236, ipnet:2607:f740:16::/48, country:US]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 21 Apr, Don Lewis wrote: > On 21 Apr, T$(D)F(Bl Coosemans wrote: >> On Wed, 20 Apr 2022 18:35:15 -0700 (PDT) Don Lewis >> wrote: >>> My only remaining question is why the selftest fails before the recent >>> padding fix. I would expect the tests to pass with the incorrectly >>> placed padding as long as everything was compiled with the same >>> structure definition. >> >> Are you building with devel/libunwind installed? It installs its own >> unwind.h which does not have the alignment changes so it does not induce >> padding in __cxa_exception. So you're not actually compiling with the >> same structure definition. > > Bingo! libunwind is getting pulled in by the gstreamer dependency. Not > sure how to fix this because some of the other dependencies are not > getting built with libunwind. ... and in view of the above, why does adding the padding to the system unwind.h header fix the self test since that will introduce a mismatch?