git: 914dc91d1219 - main - stand: zfs: handle holes at the tail end correctly

From: Kyle Evans <kevans_at_FreeBSD.org>
Date: Thu, 21 Apr 2022 19:57:59 UTC
The branch main has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=914dc91d12198352b7878a88d30e2a6373a936e1

commit 914dc91d12198352b7878a88d30e2a6373a936e1
Author:     Kyle Evans <kevans@FreeBSD.org>
AuthorDate: 2022-04-21 19:57:24 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2022-04-21 19:57:24 +0000

    stand: zfs: handle holes at the tail end correctly
    
    This mirrors dmu_read_impl(), zeroing out the tail end of the buffer and
    clipping the read to what's contained by the block that exists.
    
    This fixes an issue that arose during the 13.1 release process; in
    13.1-RC1 and later, setting up GELI+ZFS will result in a failure to
    boot.  The culprit is this, which causes us to fail to load geom_eli.ko
    as there's a residual portion after the single datablk that should be
    zeroed out.
    
    PR:             263407
    Reviewed by:    tsoome
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D35019
---
 stand/libsa/zfs/zfsimpl.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/stand/libsa/zfs/zfsimpl.c b/stand/libsa/zfs/zfsimpl.c
index ceaeeb2e77f3..2240eb765c41 100644
--- a/stand/libsa/zfs/zfsimpl.c
+++ b/stand/libsa/zfs/zfsimpl.c
@@ -2349,6 +2349,19 @@ dnode_read(const spa_t *spa, const dnode_phys_t *dnode, off_t offset,
 		return (EIO);
 	}
 
+	/*
+	 * Handle odd block sizes, mirrors dmu_read_impl().  Data can't exist
+	 * past the first block, so we'll clip the read to the portion of the
+	 * buffer within bsize and zero out the remainder.
+	 */
+	if (dnode->dn_maxblkid == 0) {
+		size_t newbuflen;
+
+		newbuflen = offset > bsize ? 0 : MIN(buflen, bsize - offset);
+		bzero((char *)buf + newbuflen, buflen - newbuflen);
+		buflen = newbuflen;
+	}
+
 	/*
 	 * Note: bsize may not be a power of two here so we need to do an
 	 * actual divide rather than a bitshift.