From nobody Mon Apr 18 21:09:35 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9429611D2F2C; Mon, 18 Apr 2022 21:09:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Kj01W3TDjz3GBm; Mon, 18 Apr 2022 21:09:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650316175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d0KByYSRtURJN+SLnwgMfc+TI4lifD3pb0hXw4/b6Zg=; b=rt3zskO2zF5OrgWVzUkJpGzddyDE8iKBxyO7ddG5JxTcFUsN7YNG374dlVYwta/fZPLAO3 C0P6kuZ3ZmAR0fTRz7D0YzFBJZBoILYSzRhSD/bcQG4LvEoJQiBWxCZ2ogus2k7M1HY3dU 1VnO1YBQdWj0CD/6IE+n7VziiYIa+Kvzk22jPezf/k77VWJjQfZRt3tJYecVKyCaQcrNG4 DQQ0MQXm3Qh8lxwhgtsnMWBL0zn489pOHCJA9dOr3z9iIceQqe7lh/yQDQkFgGNf1qcrPR sNiGs/hipHgfm8WtmX7peXFMTWVIWjRHviZ+6UeGpulkUY9dFu+ABXDBq7XSXg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 588771A39D; Mon, 18 Apr 2022 21:09:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 23IL9ZPK051349; Mon, 18 Apr 2022 21:09:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 23IL9ZVD051348; Mon, 18 Apr 2022 21:09:35 GMT (envelope-from git) Date: Mon, 18 Apr 2022 21:09:35 GMT Message-Id: <202204182109.23IL9ZVD051348@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: ecbe50447d04 - main - arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ecbe50447d04d7e9e042a20d88e7773d03b4f68e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650316175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=d0KByYSRtURJN+SLnwgMfc+TI4lifD3pb0hXw4/b6Zg=; b=oaKzTZFKhVYTFJlj98g4fU3pScyLB5IVHbfK5ZOt/2ix7ArpjGs+B4jSitbLbfpkMyHaqD /rdDYD3eT3M15y89DWYRc5p8C99mfAlh94WaMBQPUDz6tXnaKTQNv0J4niSmElqjdzgAh4 jPNw4kWGMZHF4q3H9AtVP8+q0LA6yKjMTbVzxVEntcvAzaN4qpF//UhFClVwVcdsTg5UVL HEHxYjDxkFg/4wawrlsN4x5k9+ZXBAwy2/RoYfohEspTZEee2wrbytSnGKzHTEO6B4qsDg o3TUH7wk1jvEGP4gdAz0rFB9qz4xYDXOVhMzbd5bOzBX2NHyyGjXInRi9ULGUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650316175; a=rsa-sha256; cv=none; b=yj6V16HBBnGwmZrUDcX/3paid7bd2D+hnlFRRG3f+9f35MG3MczrIX4GpW9VWK+5zOqOO0 N7CtV3HafaquSrPDGqDGdkT3pgYUqoWiCSuCc3Y5fut5YVQPIGfz/bbnP0nUhkG6DXYLin EXiiuKKN3C9+n/ylyL0KpJDKrYdHGUyH+cPIE1d62I4UmBZm2alRHGSb6dRrRrGtyNQAqn TkUuACGE8dyJ+NgjJvjT4qgxd36ovVN7NLMBBUFt5eVod++AepnM57g1Kp8LRCMjl8Ik5W w6auwU75N8L73oGmPJ1DEVkzvfOkNDSuzoelKr5JEe15q1eUZy4eBxyNeJVpLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ecbe50447d04d7e9e042a20d88e7773d03b4f68e commit ecbe50447d04d7e9e042a20d88e7773d03b4f68e Author: John Baldwin AuthorDate: 2022-04-18 21:09:20 +0000 Commit: John Baldwin CommitDate: 2022-04-18 21:09:20 +0000 arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset. This variable was flagged as a set but unused warning as its value was read from a register and then modified to set a bit (TI_MBOX_SYSCONFIG_SOFTRST). After the variable is modified, the code then loops waiting for the SOFTRST bit to go clear in the TI_MBOX_SYSCONFIG register. Presumably merely reading from the register does not request a reset as other places in the driver read this register, so most likely the updated value of sysconfig setting the reset bit is supposed to be written to the register to request a reset before the polling loop that waits for the reset to finish. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D34856 --- sys/arm/ti/ti_mbox.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/arm/ti/ti_mbox.c b/sys/arm/ti/ti_mbox.c index 864b245ad7d1..93364aa5093c 100644 --- a/sys/arm/ti/ti_mbox.c +++ b/sys/arm/ti/ti_mbox.c @@ -174,6 +174,7 @@ ti_mbox_attach(device_t dev) sysconfig = ti_mbox_reg_read(sc, TI_MBOX_SYSCONFIG); DPRINTF("initial sysconfig %d\n", sysconfig); sysconfig |= TI_MBOX_SYSCONFIG_SOFTRST; + ti_mbox_reg_write(sc, TI_MBOX_SYSCONFIG, sysconfig); delay = 100; while (ti_mbox_reg_read(sc, TI_MBOX_SYSCONFIG) & TI_MBOX_SYSCONFIG_SOFTRST) {