From nobody Wed Apr 13 01:06:57 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 49C9D11D07C2; Wed, 13 Apr 2022 01:07:00 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdPZD1bVGz4bRM; Wed, 13 Apr 2022 01:07:00 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649812020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xV6jKQvAJ6Cx68VvHUQ/37MhBKCLiMvQgCO4gZmLzu8=; b=VgO+NoDrd4ndHpGQhz+WDtQbi6oevUvoMpdHEB75HcOwDSp3qd3tDWk6gEcyaunquLadTM wqtrybwtYWY4A2enzqIC9bomlWEXoQ/dHRB7Sd3us2JuaM0uQ67gyAPZq++odsfhdCk6vD w+B9QThOh8exkXLH+xXmAQK0UsBcxPXakl7OZAbelbOcw3jkmtX9xDhcacgthtbAZ/fVay W8BTLg9M8uPAUJ0h4o5OgauP+sJgHvlBVsBqnZMIlNgaLX8sVoq1Lg5BtZyJjUkgB1Lh6J 4KluJpSbVhpauiRDUWhS9dEqBjwpC6quF+X/A3CriZ0IzudbMniYUi4APswGKQ== Received: from [172.17.133.71] (unknown [207.141.91.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 9BB5324D96; Wed, 13 Apr 2022 01:06:59 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.59.22031300 Date: Tue, 12 Apr 2022 18:06:57 -0700 Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around From: Ravi Pokala To: Kyle Evans CC: src-committers , "" , Message-ID: <12E7AA6A-F14E-4A34-9807-467A5D1CD251@panasas.com> Thread-Topic: 454630c72556 - main - stand: libefi: swap /Pci() printing around References: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> In-Reply-To: List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649812020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xV6jKQvAJ6Cx68VvHUQ/37MhBKCLiMvQgCO4gZmLzu8=; b=v6NDT+71jcrCK9FsgusQVBPV6P2/Sd0L/55H+gEpurITB9At/iZdrUgqgmjYQGvJk5VV23 QoMyMs9jiC6blCO/sLipZ9x3dCaXga6Ntau9AfIaB6fytXMdGrV2KJjJBRDD7H5Um8RwTf kP6JcnCjlkcz8DNCSTWvzdyDKnAJKHLIaTFtVtlFkCEFXniCUG/JWAHKX5ZWbhfZeQwgw9 0sEJwLal+UTw54hHdJB2NStp4SI0yangcpXZTxWmmKLX3XlTMEjBDI7jLsjzlbKB7BYcvO nE1fzYBzrHyI01CQkhz0rJR8ujSQCmnQnZF0+ncvn/CmT+bTT4ZrIwoEgGyohg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649812020; a=rsa-sha256; cv=none; b=PaiECMr2HUj7pgBxBiuRLjhjYcLtvQSf6UCNGTKM5PNd0cMv4vD6w748/JBGFquxfAwFYG zi51BjSJIpFzMwv8lI0T7XGH9poM97R2xMhem6ROHONoWXbL3MXrj+sqLdGRUlJQ0kWLNJ T9+q8Kbb4ibfXLVN3YwEZHVForDdcvPjmXSYH7DtIW2Xng8IsKxzsCJ7pBfWg4nqglKFzg Kjvkuzslfg/hV8JiOhRDZWH2nJR/4owJ9JxPDv7k+c889rI+I3Wir1J47ERiEx90MvlDWp D2ZI1bP8h0Y4LSsYh+5CDWRlhB87lA7jWe9D+KvINtROUng4jpMDP95EzgqaQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N -----Original Message----- From: Kyle Evans Date: 2022-04-12, Tuesday at 18:04 To: Ravi Pokala Cc: src-committers , "" , Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala wrote: > > -----Original Message----- > From: on behalf of Kyle Evans > Date: 2022-04-12, Tuesday at 17:34 > To: , , > Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() printing around > > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0 > > commit 454630c72556d45e401f29f56b3317c2fb0499a0 > Author: Kyle Evans > AuthorDate: 2022-04-13 00:29:54 +0000 > Commit: Kyle Evans > CommitDate: 2022-04-13 00:30:30 +0000 > > stand: libefi: swap /Pci() printing around > > Printing device followed by interface matches, e.g., edk2. Note that > this is only a fallback, many firmware implementations will provide the > protocol that we'll use to format device paths. > > "(device,function)" makes more sense anyway, since that's the logical organization (i.e. each unique device may have multiple functions). > > What was the rationale for doing "(function,device)" in the first place? > Based on tsoome's reaction when I pointed it out, the rationale was "whoops" :-) That's a perfectly valid rationale! ;-) -Ravi (rpokala@)