From nobody Wed Apr 13 01:04:14 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2BC5811CE4F4; Wed, 13 Apr 2022 01:04:28 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdPWJ0Kfmz4Ysj; Wed, 13 Apr 2022 01:04:28 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649811868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ecXEEFDRX2NLZ9os6y3Dxtrjtb17q70BDWXYZGt2FjU=; b=gEQbovpqG9feRVu/VSX5D5OZAt3OTsDAUprmggspUestxLmy4OuRNBkE6238XeNHzpYkzS TG7Wh2eBbhn8QNY7OqAYy0Pa/qZQxIm0sMRbrW4UDQ0VAc3dsJmQP0cF5WKxbZlTXDq3mQ T4XLfcwjM8AQzAObA9wI46G76ZQczkKhXn4z++OlZGnK45roPGHaHPwtY1b5xpInvA1rAO SKcCwBLEDD1iv4CJvc7aA1wedDHP4DnP3HYfwSmvnHVq+c4pegmMKA+CGh80GS9KNx7JLh vafdWQR7CoqNBxgbIpq1A9RXV3BYJ2mb0nU6uQTxzYIL3/PGyNjq1uHE7aCx6w== Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D9C1424EDB; Wed, 13 Apr 2022 01:04:27 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f54.google.com with SMTP id k5so788501lfg.9; Tue, 12 Apr 2022 18:04:27 -0700 (PDT) X-Gm-Message-State: AOAM531Ro1T8j0zDzlVCl4Z940g7y2Cadyg4vmr/m3hpm4+pUEeyyR/T xqIZQsuPOhChf+HMdUUqJC0n5P8aYgTshFQuIJQ= X-Google-Smtp-Source: ABdhPJz9hy81majXCI/wPkfLNRqZgw5ZrCAb93sLD2hfJ5P3EL5iCxF5nfLd21ajlR6PDwg5JjmhBIZuUI3/dF3zGHA= X-Received: by 2002:a05:6512:39c6:b0:46b:a21c:e342 with SMTP id k6-20020a05651239c600b0046ba21ce342mr9895192lfu.466.1649811866257; Tue, 12 Apr 2022 18:04:26 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> In-Reply-To: <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> From: Kyle Evans Date: Tue, 12 Apr 2022 20:04:14 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around To: Ravi Pokala Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649811868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ecXEEFDRX2NLZ9os6y3Dxtrjtb17q70BDWXYZGt2FjU=; b=mpYh6mXT+J/RHhvVtceM66+NuYJDwb6V3wtxZF/xiU9WBBeuObv6+e1gWxfDStRcj4l2pZ JY6FgcHMHWWJJQTmFaPBaac+/m4tx5sUF8T/ra7PppJY+B2d8sIhLwemkSF7syXUrg5yh4 dyrGU/zrljoQVRW8PCol+rFn669EYeeDm9BX4xYwPW0qBb7r046ZTRT146C0Tv7PooFDy9 ihhmHBX862dEqSNAyh+ivKA3DCpuGbHsgzZHF5nAz8vk3psymaRsE0iwxXZ6Kf36u5QclL sY8vsBil4kCRqlJ8UM8+UAbQiwGTFgjfH8cUUwAwEk5LW0640IDCBiapQTZxLA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649811868; a=rsa-sha256; cv=none; b=V7YOM33VYG3M8HFHjVM0AVhShRSLxUZVf3FtsvCt6AwXQFAlXhTuAJViCJW+RlkcauF5uB N5Zo/fyqB42TXxizCTL+rwFJTdSMLpTLbKivw1JvZ5uXdNSK1ITDxbhd3bDRL5SSP8HMAc A/z+vfYXg51nqPqkwQ+c8mZ1gHb9yAyTSXiL1HMhwLSUu5hBzHNBai88xf8dZoYwIctLrC OPqW1sGb48KieA7pDQD9b3Zly0tlYGuKd1Snt5lIHmuipA9lvYPEM7nbgtfsYfx5lmwQRb dIFc1l/onwLRuHv/FDdygo84Y/vEATKLk+bgYUc3Z9/n2jozcz7WN3f7esSjxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Tue, Apr 12, 2022 at 7:57 PM Ravi Pokala wrote: > > -----Original Message----- > From: on behalf of Kyle Evans > Date: 2022-04-12, Tuesday at 17:34 > To: , , > Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() printing around > > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0 > > commit 454630c72556d45e401f29f56b3317c2fb0499a0 > Author: Kyle Evans > AuthorDate: 2022-04-13 00:29:54 +0000 > Commit: Kyle Evans > CommitDate: 2022-04-13 00:30:30 +0000 > > stand: libefi: swap /Pci() printing around > > Printing device followed by interface matches, e.g., edk2. Note that > this is only a fallback, many firmware implementations will provide the > protocol that we'll use to format device paths. > > "(device,function)" makes more sense anyway, since that's the logical organization (i.e. each unique device may have multiple functions). > > What was the rationale for doing "(function,device)" in the first place? > Based on tsoome's reaction when I pointed it out, the rationale was "whoops" :-)