Re: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd.

From: Pokala, Ravi <rpokala_at_panasas.com>
Date: Fri, 08 Apr 2022 22:58:35 UTC 
-----Original Message-----
From: John Baldwin <jhb@FreeBSD.org>
Date: 2022-04-08, Friday at 12:27
To: Ravi Pokala <rpokala@freebsd.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Subject: Re: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd.

    On 4/7/22 6:40 PM, Ravi Pokala wrote:
    > -----Original Message-----
    > From: <owner-src-committers@freebsd.org> on behalf of John Baldwin <jhb@FreeBSD.org>
    > Date: 2022-04-07, Thursday at 17:03
    > To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
    > Subject: git: 885db9301ef9 - main - qlnx: Comment out remaining references to tx_data_bd.
    > 
    >      The branch main has been updated by jhb:
    > 
    >      URL: https://cgit.FreeBSD.org/src/commit/?id=885db9301ef9dfe420eff3c09aca497b7fc60924
    > 
    >      commit 885db9301ef9dfe420eff3c09aca497b7fc60924
    >      Author:     John Baldwin <jhb@FreeBSD.org>
    >      AuthorDate: 2022-04-08 00:01:27 +0000
    >      Commit:     John Baldwin <jhb@FreeBSD.org>
    >      CommitDate: 2022-04-08 00:01:27 +0000
    > 
    >          qlnx: Comment out remaining references to tx_data_bd.
    > 
    > Why comment out, as opposed to removing outright (like most of the other unused-but-set cleanup)?
    > 
    > Thanks,
    > 
    > Ravi (rpokala@)

    In general I have commented out code for variables if the only uses of those variables
    are in commented out code vs removing it (as one would need to also remove the commented
    out code to remove it entirely) in case someone wanted to resurrect the commented out
    code.

Ah! That makes sense.

Thanks,

Ravi (rpokala@)

    -- 
    John Baldwin