git: b0aa20bec5db - main - bhyve: validate e82545 checksum offset field
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 05 Apr 2022 22:58:40 UTC
The branch main has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=b0aa20bec5db244980a0248e24dd6b8e1e68c4d0
commit b0aa20bec5db244980a0248e24dd6b8e1e68c4d0
Author: Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2022-04-05 22:58:28 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-04-05 22:58:28 +0000
bhyve: validate e82545 checksum offset field
Reported by: Mehdi Talbi, Synacktiv
---
usr.sbin/bhyve/pci_e82545.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/usr.sbin/bhyve/pci_e82545.c b/usr.sbin/bhyve/pci_e82545.c
index 85c02889ad51..1df2f31be200 100644
--- a/usr.sbin/bhyve/pci_e82545.c
+++ b/usr.sbin/bhyve/pci_e82545.c
@@ -1276,9 +1276,7 @@ e82545_transmit(struct e82545_softc *sc, uint16_t head, uint16_t tail,
goto done;
}
if (sc->esc_txctx.cmd_and_length & E1000_TXD_CMD_TCP) {
- if (hdrlen < ckinfo[1].ck_start + 14 ||
- (ckinfo[1].ck_valid &&
- hdrlen < ckinfo[1].ck_off + 2)) {
+ if (hdrlen < ckinfo[1].ck_start + 14) {
WPRINTF("TSO hdrlen too small for TCP fields "
"(%d) -- dropped", hdrlen);
goto done;
@@ -1290,6 +1288,11 @@ e82545_transmit(struct e82545_softc *sc, uint16_t head, uint16_t tail,
goto done;
}
}
+ if (ckinfo[1].ck_valid && hdrlen < ckinfo[1].ck_off + 2) {
+ WPRINTF("TSO hdrlen too small for TCP/UDP fields "
+ "(%d) -- dropped", hdrlen);
+ goto done;
+ }
}
/* Allocate, fill and prepend writable header vector. */