From nobody Sat Apr 02 13:40:09 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 36B551A577C6; Sat, 2 Apr 2022 13:40:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KVypK6bRMz4lC0; Sat, 2 Apr 2022 13:40:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648906810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HpNxR6PyOIq3skJYxceJazeM2IKe2QWfb/LkShinb0g=; b=ndB4v59UI3oykQpWwQfF6RNrnzePsSfbBT3BjYG5M/SRcO+vTdOTk4c2qtqpWVaN5r6tzu fSTs3EjDhAReLFxKo7VETNxr/+2X/RHjronbZDWTne/SId9sT0bIpWp/QzPKp8XmuXpAdV VyHUk77ffF4Dqo8pt3R/QkZ5Gkjar2KaL9tMW81BQmYwkEwcFDQyCRrVq52OiwUrhgPUrG KU1Qte3DVNBZWLaVQ/7X180ovy+KIMNx0UyY25Zqk6dPUw+gencOMmKKGs4ZHB2KB/GUkT 3r6Q3sdwTrOO/e0b2Eh7l4FWE8IFvPMkAzXMz5XbPcjj6A5BrIsYctpN2rysfQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AC59219E8; Sat, 2 Apr 2022 13:40:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 232De9Vu006925; Sat, 2 Apr 2022 13:40:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 232De9CR006922; Sat, 2 Apr 2022 13:40:09 GMT (envelope-from git) Date: Sat, 2 Apr 2022 13:40:09 GMT Message-Id: <202204021340.232De9CR006922@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 0f3163162003 - main - sctp: remove a test, which isn't safe List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0f316316200386986de7ac72cf717c13b28f387e Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648906810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HpNxR6PyOIq3skJYxceJazeM2IKe2QWfb/LkShinb0g=; b=K5dwKiRdVg+b/D8hgOISqZNNiDXH6T90cuOZEFGlzWymIC+mEaUdsQevdySEc9QOiJzVUQ T8OBBBMhZqV6hDvzej0JOowPDj7J14XrFa8KnBRE2BpHvl2b5OzDbXUcKjBoIpKtrwEjtA eDqb9jZDX/qKLcfLtRjC2xBCkfEXN7cI4hN8wL9nEro0VwG7XmBT7BsM6ACNT6HibJ0RaO pg1eecgJFr6T6wd5jP1rNmDxUoyi5o4iNpj5bkcb43/gsl9bEyNFk1ioCXGnQkS9eFRYYN rsas8QJxSym8n77W4+JyzXdbnpUHL9d0Yb1lu5GqYiY7d67kjpyGWr09JgDOyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648906810; a=rsa-sha256; cv=none; b=d8j+fFuXAmlPa9GQ8dD+r3pdxPXVBsuRcjlA3TXIKQWH0x5m1QDnq74F6PXjM/Fa0PYvnD xKvWj+YiYjmNDbWzitS9Vq+Xb0j/oz+caLpV2ZJ/eFICLEi8anxUi5o6sE10gxvdA6oWh0 iZgdGGMQr1ip9hJCZM/8InVYO1ZIH9i+zGRuyI5yu2bM87hH9Kc1613wVRK7tlbTJUu4oI czM6VKyj1FT2oY1RaS5ViMLzaLZ6IgBWyQv5nyR1KRXpbwrSpMrLZD1848gKFC3/6GbwhI qHK4ZXgwG/Rq1s7jaREjLwPt0LCi2qVvwQ+DhobyaV9cx6h1OF/YkbXMRYO+ag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0f316316200386986de7ac72cf717c13b28f387e commit 0f316316200386986de7ac72cf717c13b28f387e Author: Michael Tuexen AuthorDate: 2022-04-02 13:09:50 +0000 Commit: Michael Tuexen CommitDate: 2022-04-02 13:09:50 +0000 sctp: remove a test, which isn't safe We can't ensure the stcb is still around. This issue was found by syzkaller. MFC after: 3 days --- sys/netinet/sctp_output.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/netinet/sctp_output.c b/sys/netinet/sctp_output.c index 5f205b1c3af4..4ef771b0cc1a 100644 --- a/sys/netinet/sctp_output.c +++ b/sys/netinet/sctp_output.c @@ -13657,11 +13657,6 @@ out_unlocked: if (free_cnt_applied) { atomic_subtract_int(&asoc->refcnt, 1); } -#ifdef INVARIANTS - if (mtx_owned(&stcb->tcb_mtx)) { - panic("Leaving with tcb mtx owned?"); - } -#endif } if (top != NULL) { sctp_m_freem(top);