From nobody Thu Oct 28 16:22:32 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D6E5F18277F0; Thu, 28 Oct 2021 16:22:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hg9nm5r6xz4vNH; Thu, 28 Oct 2021 16:22:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 8FC539C1D; Thu, 28 Oct 2021 16:22:36 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 2783A2978F; Thu, 28 Oct 2021 18:22:33 +0200 (CEST) From: Kristof Provost To: John Baldwin Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 62d2dcafb7f3 - main - if_epair: delete mbuf tags Date: Thu, 28 Oct 2021 18:22:32 +0200 X-Mailer: MailMate (1.14r5818) Message-ID: In-Reply-To: <451456f3-6a1f-78b3-4c34-01c6cf681cd0@FreeBSD.org> References: <202110280850.19S8ocCH079483@gitrepo.freebsd.org> <451456f3-6a1f-78b3-4c34-01c6cf681cd0@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On 28 Oct 2021, at 17:45, John Baldwin wrote: > On 10/28/21 1:50 AM, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D62d2dcafb7f33fe8f47e9d5= dd519d665f7af140e >> >> commit 62d2dcafb7f33fe8f47e9d5dd519d665f7af140e >> Author: Kristof Provost >> AuthorDate: 2021-10-26 07:57:56 +0000 >> Commit: Kristof Provost >> CommitDate: 2021-10-28 08:41:16 +0000 >> >> if_epair: delete mbuf tags >> Remove all (non-persistent) tags when we transmit a packet. R= eal network >> interfaces do not carry any tags either, and leaving tags attache= d can >> produce unexpected results. >> Reviewed by: bz, glebius >> MFC after: 3 weeks >> Sponsored by: Rubicon Communications, LLC ("Netgate") >> Differential Revision: https://reviews.freebsd.org/D32663 > > Wireguard has similar functionality FWIW, so it might be worth exposing= a generic > "mb_free_tags". Wireguard also tries to reset some other state like th= e status > of checksum offload since it is moving mbufs between an ifnet and a soc= ket. Not > sure if epair also needs to clear all the same things? > Something like https://reviews.freebsd.org/D32710 ? I stuck with the =E2=80=98clear=E2=80=99 terminology to distinguish it fr= om the existing free functions, and because the use case is slightly diff= erent. Kristof