Re: git: 548ada00e54a - main - LinuxKPI: add bcd.h
- Reply: Bjoern A. Zeeb: "Re: git: 548ada00e54a - main - LinuxKPI: add bcd.h"
- In reply to: Bjoern A. Zeeb: "git: 548ada00e54a - main - LinuxKPI: add bcd.h"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 25 Oct 2021 21:02:31 UTC
On Mon, 2021-10-25 at 20:23 +0000, Bjoern A. Zeeb wrote: > The branch main has been updated by bz: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=548ada00e54a9e7745d041b1ec7f68f3bd493365 > > commit 548ada00e54a9e7745d041b1ec7f68f3bd493365 > Author: Bjoern A. Zeeb <bz@FreeBSD.org> > AuthorDate: 2021-10-25 18:14:08 +0000 > Commit: Bjoern A. Zeeb <bz@FreeBSD.org> > CommitDate: 2021-10-25 20:20:53 +0000 > > LinuxKPI: add bcd.h > > Add bcd2bin() as linuxkpi_bcd2bin(). Libkern does provide a > bcd2bin() > > [...] > + * We could use libkern, but we need the argument truncating. > + * What does that mean, "we need the argument truncating"? It looks to me like the only functional difference between the linux implementation and ours is that for invalid bcd data (nybble values in the range 0xA - 0xF) the linux version returns a crazy result and our lookup table returns 0. I doubt our code relies on that. -- Ian