From nobody Wed Oct 20 17:11:05 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 79F15180400E; Wed, 20 Oct 2021 17:11:12 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HZHFX1xdlz4thR; Wed, 20 Oct 2021 17:11:12 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 19KHB6GJ005593 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 20 Oct 2021 10:11:06 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 19KHB5VO005592; Wed, 20 Oct 2021 10:11:05 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 20 Oct 2021 10:11:05 -0700 From: Gleb Smirnoff To: Emmanuel Vadot Cc: Slawa Olhovchenkov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 225639e7db68 - main - vt: Disable bell by default Message-ID: References: <202110190738.19J7cFtw067994@gitrepo.freebsd.org> <20211019112132.GC80160@zxy.spb.ru> <20211019133700.77c0ca7ac488eb99df50551b@bidouilliste.com> <20211020095206.GA77338@zxy.spb.ru> <20211020134237.17596440e1fabda5d40f6985@bidouilliste.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020134237.17596440e1fabda5d40f6985@bidouilliste.com> X-Rspamd-Queue-Id: 4HZHFX1xdlz4thR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N Emmanuel, On Wed, Oct 20, 2021 at 01:42:37PM +0200, Emmanuel Vadot wrote: E> Stop using POLA for "This is a change that I don't agree with". A change that just changes the system behaviour and nothing else, is a POLA violation. E> In the past weeks we had commits that changed mixer(8) cli in a E> non-backward compatible way and changed the root shell. For both you E> haven't complain so it means that either you don't care or you agree E> with those changes. Mixer and root shell weren't like your change. Mixer is a complete rewrite which has some technical background to justify it. Root shell is also different to what you did. It is not flip of a binary switch. E> I agree that the bell is clearly a user preference and also I could E> have left the review opened for more time (but I've been there and E> usually you have review/feedback the first day and after it's silent). E> I wish there was an easy way for developer (and community member) to E> create a poll for changes like that but we don't have one right now. E> Now based on the number of people who reviewed and the people who sent E> me private message to thanks me for this change I think that more E> people are annoyed by the bell than people who wants it and we want E> sane default that most users agrees on in base FreeBSD. If you don't E> agree with the defaults we have a way to change them. To me this looks like abuse of committer priveleges. I got commit bit, so I can change the defaults. Speaking of the bell itself. It is of course very annoying on some laptops, especially if the laptop is used by someone else, not you. But it is extremely useful when working in a loud server room on a console, reviving a crashed machine, usually in a very stressful environment. Gives feeling of machine being responsive or not being responsive. So it is more a question of server vs desktop default. Okay, let's ignore the biased opinion that FreeBSD is a server OS. But I would assert that vt(4) is a way more used on servers, rather than on laptops. If somebody is using vt(4) instead of X on a laptop, then this person is special. Either really impared, as Shawn suggested, or just a geek who hates GUI. In the latter case, they should tweak the configuration. -- Gleb Smirnoff