From nobody Tue Oct 05 20:00:54 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AB5F512B92E2; Tue, 5 Oct 2021 20:01:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HP7kc4Jtyz3Cbg; Tue, 5 Oct 2021 20:01:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f51.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so330515ota.6; Tue, 05 Oct 2021 13:01:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cxAckdlNsHic/jQpN1vA8gkWikty3hOcJFuf5S8euqI=; b=FMH476O1aPv3Lip3GZrcpL8bgplMeP84f7hQ8G9QUfn0FKUmff2KkmoV5G/jBe637o 4qxIwO2UXowyuTPIMpGk1vxbky8muP6vxauylkkURk3Y1m+glv4tZhT1ZXblMhbK+T9C Ga0O6V+MrmIXW8h2LWmyp3UoXORxvBrG12BChzuSOgZNDnewGJk1Gbo5lHAv6bwPfcoD xE7YicK2nXRmWhSQFdnLTcGwQqGWmmo1KslJTgDauJmtJi7ZYdepHcjzo/KmVJz1PpSY Q1D93g9b2My6iq3eksudvIazM1PDpw7o5VT1Yzl82aNvYolM6xhLzCD+Hlhz50HovYMs xEoA== X-Gm-Message-State: AOAM530suzyTzYnTIR3ha3e4tDtWmODyk4V48b9Hcffktr0b69XGgQJA FjBq7H6dYwVtpNMvAhC/DSfsPu23U6lpgJxVMdAoLSS3 X-Google-Smtp-Source: ABdhPJxRVL5XWHYlrfYP+HUd4uHJ3FETW50cvVVe+dRbOrq3jvPlERn0Qqfs8fHae9+EIlNZYCmq/RVwjn+VLLic4ko= X-Received: by 2002:a05:6830:44ab:: with SMTP id r43mr1133740otv.371.1633464065709; Tue, 05 Oct 2021 13:01:05 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202110051904.195J48iO062191@gitrepo.freebsd.org> <99fe068a-356c-7d58-8c70-6ecdf504ab25@FreeBSD.org> In-Reply-To: <99fe068a-356c-7d58-8c70-6ecdf504ab25@FreeBSD.org> From: Alan Somers Date: Tue, 5 Oct 2021 14:00:54 -0600 Message-ID: Subject: Re: git: 730ea72c706e - main - cam(4): Limit search for disks in SES enclosure by single bus To: Alexander Motin Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4HP7kc4Jtyz3Cbg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, Oct 5, 2021 at 1:55 PM Alexander Motin wrote: > > On 05.10.2021 15:48, Alan Somers wrote: > > On Tue, Oct 5, 2021 at 1:41 PM Alexander Motin wrote: > >> > >> On 05.10.2021 15:14, Alan Somers wrote: > >>> On Tue, Oct 5, 2021 at 1:04 PM Alexander Motin wrote: > >>>> > >>>> The branch main has been updated by mav: > >>>> > >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=730ea72c706ef8e025616772cfd86fd89ed3d42e > >>>> > >>>> commit 730ea72c706ef8e025616772cfd86fd89ed3d42e > >>>> Author: Alexander Motin > >>>> AuthorDate: 2021-10-05 19:01:16 +0000 > >>>> Commit: Alexander Motin > >>>> CommitDate: 2021-10-05 19:01:16 +0000 > >>>> > >>>> cam(4): Limit search for disks in SES enclosure by single bus > >>>> > >>>> At least for SAS that we only support now disks are typically > >>>> connected to the same bus as the enclosure. Limiting the search > >>>> scope makes it much faster on systems with multiple buses and > >>>> thousands of disks. > >>>> > >>>> Reviewed by: imp > >>>> MFC after: 2 weeks > >>>> Sponsored by: iXsystems, Inc. > >>>> Differential Revision: https://reviews.freebsd.org/D32305 > >>>> --- > >>>> sys/cam/scsi/scsi_enc_ses.c | 8 ++++++++ > >>>> 1 file changed, 8 insertions(+) > >>>> > >>>> diff --git a/sys/cam/scsi/scsi_enc_ses.c b/sys/cam/scsi/scsi_enc_ses.c > >>> > >>> > >>> Sounds juicy. Do you have any benchmarks? > >> > >> I don't think we've benchmarked that system with payload yet, if that is > >> what you mean, polishing usability. But I don't think there can be too > >> much interesting, since big speeds don't require so many HDDs these > >> days, but much smaller number of SSDs instead. This particular system > >> is about capacity -- ~20PiB raw on 1248 disks in one ZFS pool. :) > > > > 1248 disks? That's huge. But I'm not asking about throughput. Your > > commit message said "much faster". What operation is "much faster"? > > Enumerating disks at startup? That would be useful. > > I don't think you notice the difference on startup, too many other > things going on, but during idle it reduces periodic CPU load spikes by > enc_daemon processes by several times, proportionally to the number of > HBAs/buses. More annoyance than a real problem though. > > -- > Alexander Motin Yeah, I've noticed those occasional enc_daemon spikes. I was never sure what it was doing. Thanks for the fix! I'm looking forward to 13.1 a little bit more now.