From nobody Thu Nov 25 17:14:17 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5692718A5955; Thu, 25 Nov 2021 17:14:41 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J0Pcw0kVpz3KNg; Thu, 25 Nov 2021 17:14:40 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-qt1-f171.google.com with SMTP id n15so6771729qta.0; Thu, 25 Nov 2021 09:14:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yJYvEcejCdF4Wi9yu3ypDDLEIq9XD5JzT4RFzMRKaBY=; b=WAJDTjuTeIhr7DvQzrXWJV4PkrKcRRmi4SkVB+XtLO7cRaeZj90GQTwjO556yxqLJe D2sDrRoMVzW2vFy63AKZ1xlcPD3N1or+VwOBc1jQuCUmui+QykeLHHveaSvoavYYiAfO qrCVDLipYhlzOQAn2jSCE6JWPmPy9R+mjUVSMWcTIqNZThKuDp1h/QVaL8RkNX0e6jil GJn7ukIMSS6yZEkcn8Dbtsbq1xjoi0AuJZRSvB3AmyJ8EbuKFdu5LKWwyB/qTT9RLnPd 02IS51s2uVD6O7MZ4cgkzZ3u390ZR9KDK4sU8F8m99BTU8w4gym9n3HIKSlndkAx6xCJ 1z/g== X-Gm-Message-State: AOAM532VzYMJIJx19+u+t4w2GpxBrGFxnNz1LO8TIHRhgHj0PMo4vEOV vnXugaQjSl2kCpS7htOW51f4J+NNwfgxUw== X-Google-Smtp-Source: ABdhPJzz8zqEL61CZnl36Pg0bmPldkW0cmoyeCIWut6GrXaE3joqsO5GbtB1y1U1MbrYtTN+bMdAww== X-Received: by 2002:a05:622a:350:: with SMTP id r16mr19633608qtw.389.1637860472469; Thu, 25 Nov 2021 09:14:32 -0800 (PST) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id h5sm1795685qkn.62.2021.11.25.09.14.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Nov 2021 09:14:32 -0800 (PST) Received: by mail-yb1-f176.google.com with SMTP id v138so13487475ybb.8; Thu, 25 Nov 2021 09:14:32 -0800 (PST) X-Received: by 2002:a5b:d41:: with SMTP id f1mr7853795ybr.447.1637860471746; Thu, 25 Nov 2021 09:14:31 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202106300806.15U86pGq037942@gitrepo.freebsd.org> <20210706090311.aomxh4n45tkpktdc@aniel.nours.eu> <20211125142339.zxkjpbohkxk4hete@aniel.nours.eu> <9226a616-d279-9702-f13f-cee7299afc7a@FreeBSD.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 25 Nov 2021 18:14:17 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 0a0f7486413c - main - man: Build manpages for all architectures To: Kyle Evans Cc: Andriy Gapon , Baptiste Daroussin , Ed Maste , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4J0Pcw0kVpz3KNg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, Nov 25, 2021 at 4:57 PM Kyle Evans wrote: > > On Thu, Nov 25, 2021 at 9:28 AM Fernando Apestegu=C3=ADa wrote: > > > > On Thu, Nov 25, 2021 at 4:15 PM Kyle Evans wrote: > > > > > > On Thu, Nov 25, 2021 at 8:30 AM Andriy Gapon wrote: > > > > > > > > On 25/11/2021 16:23, Baptiste Daroussin wrote: > > > > > On Thu, Nov 25, 2021 at 03:57:41PM +0200, Andriy Gapon wrote: > > > > >> Looking at the output I got another thought: do we need architec= ture sub-dir > > > > >> links at all now that we install manpages to a main directory? > > > > >> Is there any benefit to having the same manpage in a directory (= like man4) > > > > >> and its immediate subdirectory (like man4/arm) ? > > > > >> > > > > > Hardlink not in the same directory is imho a fragile setup anyway= , what if a > > > > > user has different mount points here, the hardlink would be broke= n. while there > > > > > is little chances someone is doing that, history told me people a= re doing weird > > > > > things and if they haven't yet, they will soon. > > > > > > > > > > I continue to think this kind of links should be 1/ symlinks, 2/ = relative > > > > > symlinks if they are in a situation which can become a cross devi= ce issue. > > > > > > > > Yeah... but are they needed at all? :-) > > > > > > > > > > It's handy in the sense that it'd be nice to install all arch manpage= s > > > > Not also handy. From the original commit: > > ---------- > > Building and installing architecture-specific man pages only > > raises a number of > > problems: > > > > * The https://www.freebsd.org/cgi/man.cgi is incomplete. As an > > example, it does not show results for pae(4). The reason for th= is is > > that the cgi interface runs on FreeBSD amd64. > > > > * In FreeBSD amd64 some manual pages have broken X-refs. See hptr= r(4) > > for an example. > > > > * Also, we have broken links in our Release Notes. This is a > > consequence of the first point. See > > https://www.freebsd.org/releases/13.0R/hardware/#proc-i386. > > #1 and #3 are a broken man.cgi, and we should fix it or replace it. #2 I think man.cgi is perfectly able to deal with this. The impression I got the first time I asked about this[1] was the problem is that we do not ship all the man pages in the released packages. man.cgi can not show manpages that are not installed. [1] https://lists.freebsd.org/pipermail/freebsd-doc/2021-March/035449.html > is arguably not a real problem, the xref makes it clear it's an i386 I'm sorry, I don't know what you mean here. Do you mean from hptrr(4) x-ref it is clear that PAE is a i386 thing? > concept and we reference, e.g., ports manpages that are inherently > broken with some frequency anyways; see: `find *bin | xargs mandoc > -Tlint | grep Xr`, a subset of those are ports, although I haven't > counted. > > > > > Would anyone try this patch > > https://people.freebsd.org/~fernape/fix-dnoroot.patch? > > > > It seems to work(around) the problem, at least with: > > > > makefs -D -B little -o label=3DFreeBSD_root -o version=3D2 ufs.part MET= ALOG > > and > > tar -c -f archive.tbz @METALOG > > > > Cheers. > > > on some machines, e.g., I develop arm stuff on amd64 and there are > > > some drivers that simply aren't applicable to amd64, I'd like to be > > > able to find those. I think the implementation is a bit odd, though, > > > leading into: > > > > > > > I mean, whichever way we install manpages they are always installed= into manX. > > > > I do not see a point / benefit of having another copy / link / what= ever in > > > > manX/arch. > > > > > > > > > > I guess I haven't read the context much here, but I don't see why > > > either. /usr/bin/man's built-in search behavior checks > > > $mandir/$machine and $mandir/$machine_arch before $mandir, it seems > > > like we should be leaving them there and letting man do its thing. If > > > you need a non-native arch then you can hopefully just poke around th= e > > > arch subdirs (presumably mostly section 4 pages) to figure it out. > > > There's a reason they're arch subdirs, and trying to install links or > > > arch-specific pages into the main $mandir is asking for trouble when > > > we actually have conflicting pages for whatever reason between archs. > > > > > > Thanks, > > > > > > Kyle Evans